COCKOS
CONFEDERATED FORUMS
Cockos : REAPER : NINJAM : Forums
Forum Home : Register : FAQ : Members List : Search :

Go Back   Cockos Incorporated Forums > Cockos and Friends Software Discussion > WDL users forum

Reply
 
Thread Tools Display Modes
Old 03-10-2017, 12:51 AM   #1
Nowhk
Human being with feelings
 
Join Date: Mar 2016
Posts: 190
Default Last fork of WDL-OL introduces these "new" warnings in VS2015...

I've forked the actual WDL-OL and made my own WDL-Nowhk (for custom edits).

Now it seems that every time I include the IPlugStructs.h header, it show me these "new" warnings at every compile unit:

Code:
1>d:\development\c++\wdl-nowhk\wdl\iplug\IPlugStructs.h(223): warning C4244: 'initializing': conversion from 'float' to 'int', possible loss of data
1>d:\development\c++\wdl-nowhk\wdl\iplug\IPlugStructs.h(225): warning C4244: 'argument': conversion from 'float' to 'int', possible loss of data
1>d:\development\c++\wdl-nowhk\wdl\iplug\IPlugStructs.h(231): warning C4244: 'initializing': conversion from 'float' to 'int', possible loss of data
1>d:\development\c++\wdl-nowhk\wdl\iplug\IPlugStructs.h(233): warning C4244: 'argument': conversion from 'float' to 'int', possible loss of data
Before the fork I didn't see it. Is it that normal? I don't think so.

How should I fix it? I wouldn't add a "4244;" on "Disable Specific Warning" within VS2015.

Should I manually cast these lines to (int) and send a "pull-request" change?
Sorry I'm a novice of Git
Nowhk is offline   Reply With Quote
Old 03-10-2017, 02:51 AM   #2
Youlean
Human being with feelings
 
Youlean's Avatar
 
Join Date: May 2015
Location: Serbia
Posts: 367
Default

Just cast them to int.
Youlean is offline   Reply With Quote
Old 03-10-2017, 03:56 AM   #3
Nowhk
Human being with feelings
 
Join Date: Mar 2016
Posts: 190
Default

Quote:
Originally Posted by Youlean View Post
Just cast them to int.
Yes, that's pretty easy! But later? Pull-request from my fork? Or "I don't care about the other who will fork WDL-OL and use Visual Studio?"

I'm new to Git, not sure how to "move" in this case... ehhe
Nowhk is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 01:50 AM.


Powered by vBulletin® Version 3.8.9
Copyright ©2000 - 2017, vBulletin Solutions, Inc.