Any code with Lua "repeat", "until", "while" crashes REAPER

[mpl]

Can anyone confirm?

[Lazarus]

No, using while loops here no probs. You can create infinite loops quite easily with this type of code though, so have a check that your exit condition is being met.

[mpl]

Ok. If you not really bussy, can you please check this (snap notes of selected items to scale of opened MIDI Editor)? Here repeat/until crashes Reaper, though it looks like everything is Ok here.

PHP Code:

  midieditor = reaper.MIDIEditor_GetActive() 
  if  midieditor ~= nil then
    is_scale_enabled = reaper.MIDIEditor_GetSetting_int(midieditor, "scale_enabled")
    if is_scale_enabled == 1 then
    
      --form pattern table
      scale_root = reaper.MIDIEditor_GetSetting_int(midieditor, "scale_root")
      retval, scale_pat_original = reaper.MIDIEditor_GetSetting_str(midieditor, "scale", "")
      scale_pat = string.sub(scale_pat_original, 13-scale_root).. string.sub(scale_pat_original, 0, 12-scale_root)
      scale_pat_t={} 
      scale_pat:gsub(".",function(c) if c ~= "0" then c = "1" else c = "0"end table.insert(scale_pat_t,c)end)
      
      --loop through selected items notes
      sel_item_count = reaper.CountSelectedMediaItems(0)
      if sel_item_count ~= nil and scale_pat_t ~= nil then
        for i = 1, sel_item_count do
          item = reaper.GetSelectedMediaItem(0, i-1)
          count_takes = reaper.CountTakes(item)
          if count_takes ~= nil then
            for j = 1, count_takes do
              take = reaper.GetTake(item, j-1)
              if take ~= nil then
                table_to_insert = {}
                retval, notecnt = reaper.MIDI_CountEvts(take)
                if notecnt ~= nil then
                  for k = 1, notecnt do
                    retval,selected, muted, startppqpos, endppqpos, chan, pitch, vel = reaper.MIDI_GetNote(take, k-1)
                    pitch_norm = pitch % 12                    
                    if scale_pat_t[pitch_norm+1] == "0" then
                       set_pitch = pitch
                       m = 1
                       repeat 
                         set_pitch = set_pitch + m 
                         pitch_norm = pitch % 12 
                       until 
                         (scale_pat_t[pitch_norm+1] == "1") 
                      else
                       set_pitch = pitch
                    end
                    temp_table = {selected, muted, startppqpos, endppqpos, chan, set_pitch, vel}
                    table.insert(table_to_insert, temp_table)
                    
                  end                    
                end
                reaper.MIDI_Sort(take)
                
                -- delete notes from take
                if notecnt ~= nil then
                  for o = 1, notecnt do
                    reaper.MIDI_DeleteNote(take, 0) 
                    reaper.MIDI_Sort(take)
                  end
                end       
                
                -- insert new notes from table
                if table_to_insert ~= nil then
                  for n = 1, #table_to_insert do
                    temp_table = table_to_insert[n]
                    selected, muted, startppqpos, endppqpos, chan, pitch, vel = 
                      temp_table[1],temp_table[2],temp_table[3],temp_table[4],temp_table[5],temp_table[6], temp_table[7],
                    reaper.MIDI_InsertNote(take, selected, muted, startppqpos, endppqpos, chan, pitch, vel, true)
                  end
                end  
              end
              reaper.MIDI_Sort(take)
            end
          end
          reaper.UpdateItemInProject(item)
        end
      end      
    end
  end 


UPD. You`re right, it is my fault with understanding condition, right code is

PHP Code:

until (scale_pat_t[pitch_norm+1] == "0") 


[Lazarus]

Cool, sometimes you need to stop looking at it for a while.

I haven't tried it, but this is a nice script idea. Can I borrow some of it for my transpose stuff?

[mpl]

Sure)
Actually I did this because of other thing: for some reason we can`t do changes in scale directly to item chunk, so I rewrite "Midi Editor: Force Selected notes into snap scale" in Lua as I understood this action.