Old 03-12-2014, 04:23 PM   #1
Reaktor:[Dave]
Human being with feelings
 
Reaktor:[Dave]'s Avatar
 
Join Date: Jun 2010
Location: Berlin
Posts: 425
Default Multi-MIDI breaks undo (FIXED)

The liceap demonstrates the steps needed to make the undo system forget certain states:


Note: the edited notes have to be in an item without the green arrow activated. Transposing notes is done via key commands.
Transposing the notes via mouse works fine.

This is a serious bug. I've lost lots of editing because of it.

The following project file was used in the video above:
http://stash.reaper.fm/20003/multi-m...aks%20undo.RPP
  1. Open both items in the ME
  2. Select notes from the clip without the green arrow activated
  3. Move them up/down via key command (actions)
  4. Undo until the notes are back
  5. Redo - notes won't be moved again (though moving notes may be there in the undo history, it doesn't work)

Bug Report here, please confirm: http://forum.cockos.com/project.php?issueid=5117

Last edited by Reaktor:[Dave]; 03-18-2014 at 06:32 AM.
Reaktor:[Dave] is offline   Reply With Quote
Old 03-18-2014, 05:04 AM   #2
Reaktor:[Dave]
Human being with feelings
 
Reaktor:[Dave]'s Avatar
 
Join Date: Jun 2010
Location: Berlin
Posts: 425
Default

Nobody to confirm this?
Reaktor:[Dave] is offline   Reply With Quote
Old 03-18-2014, 05:56 AM   #3
DarkStar
Human being with feelings
 
DarkStar's Avatar
 
Join Date: May 2006
Location: Surrey, UK
Posts: 16,379
Default

Not quite - I get slightly different results. Maybe I was doing it differently?

But there is something odd going on - - it feels like the Undo/Redo actions are gettting confused. For example, at one stage, "Undo / Redo Move notes down (or up) one semitone" appear in the Edit menu but selecting them does nothing.
__________________
DarkStar ... interesting, if true. Inspired by ...

My top 40 FRs, as voted by you (updated for August 2016)
DarkStar is offline   Reply With Quote
Old 03-18-2014, 06:07 AM   #4
Reaktor:[Dave]
Human being with feelings
 
Reaktor:[Dave]'s Avatar
 
Join Date: Jun 2010
Location: Berlin
Posts: 425
Default

I edited the first post to include a step-by-step recipe with important steps highlighted.
Reaktor:[Dave] is offline   Reply With Quote
Old 03-18-2014, 06:19 AM   #5
DarkStar
Human being with feelings
 
DarkStar's Avatar
 
Join Date: May 2006
Location: Surrey, UK
Posts: 16,379
Default

Yep, I did that and eventually got a "Can't Redo".

I tired various things (note select, move by dragging and transpose with keyboard shortcuts) with the Undo History window open. I saw that various actions sometimes did not appear the the Undo List. This would upset the Undo/Redo functions.
__________________
DarkStar ... interesting, if true. Inspired by ...

My top 40 FRs, as voted by you (updated for August 2016)
DarkStar is offline   Reply With Quote
Old 03-18-2014, 06:32 AM   #6
Reaktor:[Dave]
Human being with feelings
 
Reaktor:[Dave]'s Avatar
 
Join Date: Jun 2010
Location: Berlin
Posts: 425
Default

I opened a bug report here: http://forum.cockos.com/project.php?issueid=5117
Reaktor:[Dave] is offline   Reply With Quote
Old 06-03-2014, 03:53 AM   #7
Reaktor:[Dave]
Human being with feelings
 
Reaktor:[Dave]'s Avatar
 
Join Date: Jun 2010
Location: Berlin
Posts: 425
Default

Bugs breaking undo are so ugly ... is there any insight about the priority that such a big trouble has for the devs? I mean, anyone using the midi editor to edit multiple items is certain to experience this bug...
Reaktor:[Dave] is offline   Reply With Quote
Old 05-28-2016, 07:26 AM   #8
Reaktor:[Dave]
Human being with feelings
 
Reaktor:[Dave]'s Avatar
 
Join Date: Jun 2010
Location: Berlin
Posts: 425
Default

Still happening in v5.20.
Reaktor:[Dave] is offline   Reply With Quote
Old 05-28-2016, 10:26 AM   #9
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 10,161
Default

Fixing!
Justin is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 03:34 AM.


Powered by vBulletin® Version 3.8.9
Copyright ©2000 - 2017, vBulletin Solutions, Inc.