'implode items across tracks into takes' bug

[nofish]

https://i.imgur.com/53C32lT.gif

The item in the lower track gets only imploded until the first split occurs, after that's it's truncated.

R4.76 x32, Win 8.1 upd1 x64

Anyone can confirm ?
If not, I could also upload a small test project.

(I think the factor is trying to implode an item in another one where already splitted takes occur and these splits happen before the full length of the imploded item, as said above).

===

Tracker:
http://forum.cockos.com/project.php?issueid=5488

[nofish]

bump

Any comments ?

Should I expect the item only being imploded until the first split or bug ?

[nofish]

Anyone please ?

I'm giving another example.

Initial situation:



Situations like this happen frequently here, e.g. with online collaborations I'm doing. I have two takes of something already edited and comped (splitted), than the artist decides to send me another take I'd like to implode.

Current result after after imploding:




Desired would be something like this I think (manually done):



Item gets enlarged until the beginning of the new imploded take, full length and inherits the splits of the original item.

Makes sense ?

[Tod]

Item gets enlarged until the beginning of the new imploded take, full length and inherits the splits of the original item.

Makes sense ?

Hi nofish, I never implode tracks like that but yeah, I'd say your bottom picture displays a more correct result.

[heda]

imploding to takes has several bugs. this is certainly one of them. I don't see any easy solution for this.

[serr]

Isn't that the desired effect of that feature (ie. the take recording mode that makes multiple audio streams in the same item instead of separate items)? The original edits are preserved.

Not sure. I never use this (and was baffled as to what kind of workflow this feature was aimed at exactly). I use the 'new recorded items make their own lane' option for overdubs and comping. New takes are their own item as expected and are not linked together in any weird ways for editing when you don't want them to be. You can always record new takes no matter how elaborate of a comp you already have going on and add to it.

I think the idea behind the multiple takes in a single item thing is more a live performance thing where someone would want to switch between alternate versions but always keep the same edit/loop points and trigger it with MIDI controls.

[nofish]

Thanks.

Put into tracker:
http://forum.cockos.com/project.php?issueid=5488


serr, topic is not about Reaper's recording modes but current behaviour when imploding items into takes.

btw (a bit unrelated but anyway), I also used the 'new recorded items make their own lane' very long until I finally made friends with the 'create new takes' mode. Advantage using this mode when comping is you don't have to mute items manually, just split and select takes. Much faster imo, might be worth revisiting this (only works good when all takes have the same length though, not e.g. classical music).

I also suggest having a look of this nice overview from Coachz about recording modes, takes etc.

http://forum.cockos.com/showpost.php...1&postcount=36

[Fergler]

I don't consider this a bug. If I had audio before the take items it would get overrun with that.

If you're imploding onto a track it usually implies the recordings are similar. If they are not similar due to areas of silence you trim them intuitively. With your proposed changes I'd still have to trim them anyway. This would just get in my way.

[Fergler]

My compromise:

Before:


After:

[nofish]

Fergler, thanks for bringing this up.
Actually I thought about it too (but didn't bother to mention).

I see your point (I think), when the item is trimmed already it's reasonable to assume the trimming should stay intact when imploding (and also assuming takes are similar, I admit my example wasn't 'real life')

Agreed, or better said this part isn't that important for me how it's handled (I can trim the beginning manually after imploding if desired), important part for me is that ALL splits get carried across the imploded item which currently isn't the case (it's truncated after first split).

Could you go along with this ?

[spk77]

Nofish, try this EEL thing:

This is how it differs from the native action "Take:Implode items across tracks into takes":


(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)

Download from the stash:
https://stash.reaper.fm/23003/Split%2...o%20takes2.eel

[heda]

rescued again by the already legendary spk77!!!

[spk77]

Originally Posted by heda

rescued again by the already legendary spk77!!!

Thanks, I hope it works
(I haven't tested it very much)

[nofish]

Originally Posted by spk77

Nofish, try this EEL thing:

This is how it differs from the native action "Take:Implode items across tracks into takes":


(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)

Download from the stash:
https://stash.reaper.fm/23003/Split%2...o%20takes2.eel

Wow, blown away !

Looks like this is exactly what I'm loking for.

Will test and report back.
Thanks so much spk77 !

[nofish]

spk77, since I can't send you PM's currently (inbox full) I hope you see this:

I think you can disregard the test project I just sent you.
Seems to work totally fine now, maybe it was a temporal glitch or something before.

Thanks again, much appreciated.

[Fergler]

What about this case?





Ok to add a new split into the takes?

[nofish]

Originally Posted by Fergler

What about this case?





Ok to add a new split into the takes?

I don't have this case.
Usually I have single full length items I need to be imploded.

So I'm indefferent, meaning fine with me.

[spk77]

Originally Posted by nofish

spk77, since I can't send you PM's currently (inbox full) I hope you see this:

I think you can disregard the test project I just sent you.
Seems to work totally fine now, maybe it was a temporal glitch or something before.

Thanks again, much appreciated.

Tested your project - I noticed that the script is quite slow when there are a lot of items in a project. Well, I hope it will work. (this is quite a hack )

[goldec]

Sadly the script doesn't seem to work for me. Could anyone confirm it working for them?

Is there any way to do it still? I really like the idea pf exploding all takes, cleaning them up and then imploding again but there doesn't seem to be any way to do it atm.

[spk77]

goldec,

Do you have the SWS extension installed? ("SWS: delete empty MIDI takes/items" is used to delete all empty items that the script creates.)


It seems to work for me (win 8.1 64bit, REAPER v5.03pre1):





(I tested with this version)

// Split and implode items across tracks into takes, keeping item positions.

buf = 10000;

function split_and_implode_across_tracks()
(
  i = 0;
  sel_item_count = CountSelectedMediaItems(0);
  sel_item_count ? (
    max_split_pos = 0;
    last_item_number = 0;
    dest_track_sel_item_cnt = 0;
    cursor_pos = GetCursorPosition();

    Undo_BeginBlock();
    PreventUIRefresh(1);
    //Main_OnCommand(40299, 0); // move items to source preferred position
    loop(sel_item_count,
      (sel_item = GetSelectedMediaItem(0, i)) ? (

        buf[i * 2] = GetMediaItemInfo_Value(sel_item, "D_POSITION");
        buf[i * 2 + 1] = buf[i * 2] + GetMediaItemInfo_Value(sel_item, "D_LENGTH");
        buf[i * 2 + 1] > max_split_pos ? max_split_pos = buf[i * 2 + 1]; // selection end pos
        i == 0 ? (
          first_track = GetMediaItemTrack(sel_item);
          min_split_pos = buf[i * 2];
        );
        buf[i * 2] < min_split_pos ? min_split_pos = buf[i * 2]; // selection start pos
      );
      dest_track_sel_item_cnt == 0 && GetMediaItem_Track(sel_item) != first_track ? dest_track_sel_item_cnt = i;
      i += 1;
    );
    
    // Add temporary track
    InsertTrackAtIndex(0, 1);
    
    temp_track_id = GetTrack(0, 0); 
    i = 0;
    loop(dest_track_sel_item_cnt + 1,
      // empty items will be added to the temp track
      new_item = AddMediaItemToTrack(temp_track_id);
      
      // add empty item if first selected item's start pos > item selection start pos
      i == 0 && min_split_pos < buf[0] ? (
        SetMediaItemInfo_Value(new_item, "D_POSITION", min_split_pos);
        SetMediaItemInfo_Value(new_item, "D_LENGTH",  buf[0] - min_split_pos);
      );
      
      // fill all gaps with empty items
      i > 0 && (i < dest_track_sel_item_cnt) && (buf[i * 2 - 1] < buf[i * 2]) ? (
        SetMediaItemInfo_Value(new_item, "D_POSITION", buf[i * 2 - 1]);
        SetMediaItemInfo_Value(new_item, "D_LENGTH", buf[i * 2] -  buf[i * 2 - 1]);
      );
     
      // add empty item if last selected item's end pos < item selection end pos
      i == dest_track_sel_item_cnt && buf[i * 2] < max_split_pos ? (
        SetMediaItemInfo_Value(new_item, "D_POSITION", buf[i * 2 - 1]);
        SetMediaItemInfo_Value(new_item, "D_LENGTH", max_split_pos - buf[i * 2 - 1]);
      );
      
      SetMediaItemSelected(new_item, 1);
      i += 1;
    );
    
    // split all items at start/end pos of items
    i = 0;
    loop(sel_item_count * 2,
      SetEditCurPos(buf[i], 0, 0);
      Main_OnCommand(40757, 0); // split and keep selection
      i += 1;
    );
  
    Main_OnCommand(40438, 0); //implode items across tracks into takes
    SetEditCurPos(cursor_pos, 0, 0);

    i = 0;
    loop(CountSelectedMediaItems(0),
      (sel_item = GetSelectedMediaItem(0, i)) ? (
      MoveMediaItemToTrack(sel_item, first_track) ? i -= 1;
      i += 1;
      );
    );
    Main_OnCommand(NamedCommandLookup("_S&M_DELEMPTYTAKE2"), 0); // SWS: delete empty MIDI takes/items
    //Main_OnCommand(NamedCommandLookup("_S&M_DELEMPTYTAKE"), 0); // SWS: delete empty takes/items
    DeleteTrack(temp_track_id);
    PreventUIRefresh(-1);
    Undo_EndBlock("Implode items across tracks into takes", -1);
  );
);
split_and_implode_across_tracks();

[G-Sun]

Originally Posted by spk77

Nofish, try this EEL thing:

This is how it differs from the native action "Take:Implode items across tracks into takes":


(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)

Download from the stash:
https://stash.reaper.fm/23003/Split%...o%20takes2.eel

Thanks a lot for this one!
Really what I was looking for

[spk77]

Thanks G-Sun! It's an old script - I hope it still works

[Fabian]

Over the years, I have posted several issues with the "Implode items across tracks:
https://forum.cockos.com/showthread.php?t=91936
https://forum.cockos.com/showthread.php?t=118417

Probably a few more I cannot find just now, before I gave up...

It works in a very counter-intuitive way, I would say.

[G-Sun]

Originally Posted by Fabian

Over the years, I have posted several issues with the "Implode items across tracks:
https://forum.cockos.com/showthread.php?t=91936
https://forum.cockos.com/showthread.php?t=118417

Probably a few more before I cannot find just now, I gave up...

It works in a very counter-intuitive way, I would say.

spk77's script worked out of the box for me for merging takes on two tracks

[Fabian]

Originally Posted by G-Sun

spk77's script worked out of the box for me for merging takes on two tracks

I'll check it out. Thanks for the tip.

[Fabian]

And I'm back again with the same issue. Can we hope to get this fixed for v6?



I expected to get 8 items with three takes each. That's not what happens, and I cannot for the life of me figure out the logic.

spk77's script... I'll try that.

EDIT: Nope, spk77's script generated the exact same thing.

[Fabian]

Actually, spk77's script was even stranger. If I select the three first items across the three tracks, this happens with spk77's script:



All of them disappear!

Here, Reaper does the expected thing:

[schwa]

This is happening because the items overlap slightly. We'll look at improving this behavior.

[Fabian]

Originally Posted by schwa

This is happening because the items overlap slightly. We'll look at improving this behavior.

Aha!
Great.
Thanks.
Looking forward to it.

[juliansader]

v6.05 includes this update:

[*]+ Takes: implode items into tracks only if at least half of the item overlaps [p=2207040]

Could someone give a bit more information about this update? Perhaps an example of an implosion that previously failed but now works?

As I commented a few months ago for v6.0+dev1204, the implosions that I tried all still failed.

[antiClick]

Originally Posted by spk77

Nofish, try this EEL thing:

This is how it differs from the native action "Take:Implode items across tracks into takes":


(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)

Download from the stash:
https://stash.reaper.fm/23003/Split%...o%20takes2.eel

that SAVED MY DAY..... thank you

[nofish]

^^ That's how it should be natively imo.

[antiClick]

Originally Posted by nofish

^^ That's how it should be natively imo.

I,d swear this was the native behaviour some versions ago.

[amagalma]

I think my script amagalma_Implode items across tracks into takes (found in ReaPack) should fix the behavior. In the test project I attach, the native action doesn't do anything, and spk77's script deletes the items.


Test Project

[lexaproductions]

hey amagalma,
I tried your script but nothing happens.
I select the items
Fire your script
the times gets unselected but nothing happens...
What am I doing wrong???

[X-Raym]

Bump,


Seems I got a related issue today (nofish leads me here)





Items are perfectly at same pos as snap is active, yet only some items are imploded.

[nofish]

^ May try the alternative solutions posted here (#20,#34) in the meantime (in case you missed them) until it's fixed natively.

[lexaproductions]

Yeah, I’ve been using Amagalma’s script for a while now.
Gets the job done great.

[nofish]

Fix in pre-release of today (no tested yet), thanks devs!