View Single Post
Old 09-08-2016, 01:11 AM   #1
cfillion
Human being with feelings
 
cfillion's Avatar
 
Join Date: May 2015
Location: Québec, Canada
Posts: 4,937
Default MIDI Duplicate Filter stop accepting notes after receiving two note offs (FIXED)

I've been chasing around a seemingly random issue in my live setup where MIDI_DuplicateFilter would suddenly decide to stop accepting specific notes until it's manually reset.

Here's an easy way to trigger the symptoms:
  1. Put the included MIDI_DuplicateFilter JSFX on a track with MIDI input
  2. Press a note on the keyboard (don't release it)
  3. Start transport -> REAPER sends a note off
  4. Release the note previously held -> another note off is sent
  5. Current: MIDI_DuplicateFilter won't accept that note anymore
    Expected: MIDI_DuplicateFilter ignores the second note off so further note on are accepted
Suggested fix:
Code:
Line 80, original:
tracker[note] -= 1;

Modified:
tracker[note] > 0 ? tracker[note] -= 1;

Last edited by cfillion; 08-22-2018 at 02:32 PM. Reason: updated line number
cfillion is offline   Reply With Quote