Thread: WDL in the wild
View Single Post
Old 08-23-2010, 03:54 AM   #26
Tale
Human being with feelings
 
Tale's Avatar
 
Join Date: Jul 2008
Location: The Netherlands
Posts: 2,985
Default

Quote:
Originally Posted by cc_ View Post
Oh yeah, the other thing that I didn't like about your code (last time I looked) is you have duplicated code at the end of the edit in Cocoa, Carbon and Win that could be in IGraphics.cpp . I have the function IGraphics::SetFromStringAfterPrompt(char *txt) to do that stuff. Actually, I guess that's the code that ended up in your Carbon and Cocoa code.
Actually there is a lot of duplicate code in the IGraphicsWin.cpp, IGraphicsCarbon.cpp, and IGraphicsCocoa.mm. This could use some cleaning up (move duplicate defines over to IGraphics.h, move some member variables to IGraphics, perhaps even move some code to IGraphics and add a couple of pure virtual methods). However, my original goal was to let the Windows version be, and to make the Carbon and Cocoa verions as much like the Windows version as possible.
__________________
Martinic Kee Bass - Scanner Vibrato - Elka Panther - Tale's JSFX Pack
Tale is offline   Reply With Quote