Thread: WDL in the wild
View Single Post
Old 08-23-2010, 10:21 AM   #28
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 12,494
Default

Sorry if I got overzealous.

Quote:
Originally Posted by Tale View Post
I noticed that you have merged all of my changes, which fine by me. But I should perhaps warn you about a couple of changes, because they may break compatibility with existing projects:

8da3756 When state chunks are enabled, use SerializeState() for a patch, and SerializePresets() for a bank.
Before this change SerializeState() was called for both patches and banks.
Yeah, on this maybe there should be a default implementation of () that just calls SerializeState()?

Quote:

178c4fe Drop JPEG support.
I have completely dropped JPEG support in IPlug, because I only use PNG images.
Yeah, I sort of figured "who uses JPG?" .. maybe it makes sense to have two projects with varying levels of inclusion. Or include the jpeglib files and have them unused and let the linker do the work.

Quote:

964e261 Customized Xcode project file
Although I have added some useful stuff (macro defines), I have also dropped a bunch of code I don't need (e.g. JPEG stuff), but which others may need.
This is why I included those updates, mostly -- the VST_FORCE_DEPRECATED definitions, etc..

Anyway, I guess I'll do some customization for our tree relating to the JPEG support.

Edit: OK, I've updated our next tree with JPEG support returned, but keeping the other project edits. So now we just need to find a good backwards compatible way of handling SerializePresets() and we should be good, eh?

Last edited by Justin; 08-23-2010 at 10:50 AM.
Justin is offline   Reply With Quote