Thread: WDL in the wild
View Single Post
Old 08-23-2010, 02:17 PM   #30
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 12,438
Default

Quote:
Originally Posted by Tale View Post




Right. I don't think SerializePresets() is used anywhere else, so it is tempting to simply change it to:

Code:
bool IPlugBase::SerializePresets(ByteChunk* pChunk) { return SerializeState(pChunk); }
However, this could still break compatibility with an existing project if it happens to call SerializePresets() internally. So I guess it would be better to leave SerializePresets() be (and make it non-virtual again), and add a new virtual method instead, and call that new method for effGetChunk.

EDIT: Tried it here locally, it seems to work. Now I have to figure out how to pull the Cockos WDL's next branch without messing up my own master branch. And then what? Should I publish my own next branch, so you guys at Cockos can pull it, or can I push things to you?
You can fetch our stuff (assuming we're a remote called "cockos"), then look at our logs (git log cockos/next). Once you have that, you can merge our branch in, or cherry-pick our edits. I'll keep an eye on your branch and see if there's stuff that makes sense to merge in.

I've just updated ours with support for defining IPLUG_NO_JPEG_SUPPORT, which prevents IPlug from loading JPEGs (which should also cause the linker to throw away all the JPEG related code on link, hopefully).
Justin is offline   Reply With Quote