MAJOR BUG: Incorrect or totally missing shortcut keystrokes in REAPER menus on Mac - Page 2

cohler · 12-05-2021, 06:15 AM

Thank you @Justin for responding to this bug report!

Quote:

Originally Posted by Justin

Some of the missing indicators are due to the fact that macOS only allows the keyboard assignment for a menu item to appear on one item in the menu, so if there are duplicate items, it will only be displayed in one location. So, for example, if you have an action in the view menu with a binding of "X", and run it, its instance in the view menu may still show "X", but if it appears in the actions menu, it will not show a key binding there. (Or vice-versa, it's the OS doing this). I haven't been able to find any way around this OS limitation.

I am aware of this issue, BUT I believe that NONE of the dozens of specific examples I have reported here are related to it. Please correct me if I am wrong.

Quote:

Originally Posted by Justin

Some keys are simply not able to be represented by the macOS keyboard assignment system. E.g. space-bar. Or Home.

Certainly, the Mac OS displays keystrokes such as Command-Space and other keystrokes involving Space without any trouble, for example:

When you say "some keys are simply not able to be represented by the macOS keyboard assignment system" where is that documented?

Quote:

Originally Posted by Justin

There are probably some instances where a key-combination IS able to be represented by the macOS keyboard assignment system, and REAPER translates it poorly. If we can figure out which are _these_ instances, I'd be happy to try to fix them.

I believe nearly all of the ones noted in my OP fall into this category.

Justin · 12-05-2021, 06:50 AM

Quote:

Originally Posted by cohler

Certainly, the Mac OS displays keystrokes such as Command-Space and other keystrokes involving Space without any trouble, for example:

Can you show me somewhere where it displays that in a menu?

cohler · 12-05-2021, 07:22 AM

Quote:

Originally Posted by Justin

Can you show me somewhere where it displays that in a menu?

Here's one example from Chrome:

Justin · 12-05-2021, 07:27 AM

Ah thanks, I stand corrected on that one! Fixing this and a number of other cases.

cohler · 12-05-2021, 07:32 AM

Quote:

Originally Posted by Justin

Ah thanks, I stand corrected on that one! Fixing this and a number of other cases.

Thank you. Is there something special about the Home/End keys?

On the standard large Mac keyboard there is a bank of six keys in between the normal keyboard and the numeric keypad:

Code:

fn        home     page up
delete    end      page down

These keys are used standardly by virtually all Mac applications. Is it really true that they don't allow them in the menus? I'll see if I can find some examples of those as well.

cohler · 12-05-2021, 07:42 AM

Another problem also related to menu keystroke display is that when you enter multiple keystrokes for a single action, the FIRST of those keystrokes shows in the menus, which is fine and makes perfect sense.

BUT the problem is that the order of those keystrokes is NOT maintained when you restart REAPER.

So, I believe the problem is that REAPER is not consistently loading those keystrokes in the exact SAME order they appear in

Code:

reaper-kb.ini

This makes menus change randomly each time you restart REAPER for any function that has multiple keystrokes assigned. Clearly, this is a bug as well.

cohler · 12-05-2021, 07:47 AM

Here's a menu showing the ESCAPE key using the standard Apple symbol (⎋):

cohler · 12-05-2021, 08:17 AM

Here's a CORRECTLY displayed REAPER menu using both the Delete key and the End key (directly below the Home key) from the middle six keys of the keyboard.

So if Delete and End display correctly, why shouldn't Home, Page Up, and Page Down?

cohler · 12-05-2021, 08:30 AM

Correction on my last post regarding End. Here are all the official Apple keystroke symbols:

https://support.apple.com/en-ke/guid...p/cpmh0011/mac

Page Up and Page Down are supposed to be ⇞ and ⇟
REAPER is not displaying those at all

Home and End are supposed to be ↖︎ and ↘︎
REAPER is displaying those incorrectly as ⤒ and ⤓

MonkeyBars · 12-05-2021, 08:38 AM

Nice investigative work on this, Cohler! +1

cohler · 12-05-2021, 08:46 AM

Quote:

Originally Posted by MonkeyBars

Nice investigative work on this, Cohler! +1

Thank you @MonkeyBars

cohler · 12-05-2021, 08:52 AM

Shift-[ (⇧[) and Shift-] (⇧]) display in the REAPER menus incorrectly as F12 and F14.

All modifier key combinations with those do so as well. In other words:

⌥⇧[ shows as ⌥F12
⌘⇧[ shows as ⌘F12
^⌥⇧[ shows as ^⌥F12

etc..

cohler · 12-05-2021, 08:55 AM

All modified versions of ⌘- and ⌘= show incorrectly or not at all

cohler · 12-05-2021, 08:59 AM

All versions of < (⇧,) and > (⇧.) fail to display.

Justin · 12-05-2021, 09:28 AM

Quote:

Originally Posted by cohler

Correction on my last post regarding End. Here are all the official Apple keystroke symbols:

https://support.apple.com/en-ke/guid...p/cpmh0011/mac

Page Up and Page Down are supposed to be ⇞ and ⇟
REAPER is not displaying those at all

Home and End are supposed to be ↖︎ and ↘︎
REAPER is displaying those incorrectly as ⤒ and ⤓

I can't get any of those characters in my menus, do you have any screenshots of other apps displaying them in their menus?

cohler · 12-05-2021, 09:41 AM

Quote:

Originally Posted by Justin

I can't get any of those characters in my menus, do you have any screenshots of other apps displaying them in their menus?

I will check and get back to you, but for what it's worth, the title of the article I gave you from the official Apple support site

https://support.apple.com/en-ke/guid.../12.0/mac/12.0

is "What are those symbols shown in menus on Mac?" [emphasis added]

cohler · 12-05-2021, 09:43 AM

By the way, if you don't have a Mac keyboard that has those keys on it, you can generate the same keystrokes using

Fn-Left for Home
Fn-Right for End
Fn-Up for Page Up
Fn-Down for Page Down

cohler · 12-05-2021, 11:50 AM

@justin here are the Unicode characters for those symbols:

And here are the Apple developer instructions on how to assign a menu item's key equivalent:

https://developer.apple.com/library/...uKeyEquiv.html

Isn't that all you need?

cohler · 12-05-2021, 12:00 PM

And for Shift-[ and Shift-] which are "{" and "}" respectively:

{ = U+007B
} = U+007D

cohler · 12-05-2021, 12:28 PM

I see that 642+dev1205 has addressed several of these problems already. Thank you!

I'll go through and see what's remaining...

cohler · 12-05-2021, 12:44 PM

The solution in 6.42+dev1205

+ Menus: preserve consistent keyboard shortcut display when multiple shortcuts assigned [p=2503236]

is not implemented correctly. Now it does not allow the user to specify the order of the shortcuts. It keeps them in one presorted order. The user needs to be able to specify which ONE he/she wants to be the ONE to be displayed in the menus.

cohler · 12-05-2021, 12:46 PM

The "Save" button is now missing from the Customize menus/toolbars window

MonkeyBars · 12-05-2021, 12:51 PM

Quote:

Originally Posted by cohler

The user needs to be able to specify which ONE he/she wants to be the ONE to be displayed in the menus.

+1 helpful

cohler · 12-05-2021, 01:49 PM

@Justin, I've checked through everything and here are the remaining issues:

Cannot specify order of keystrokes in Action List, or at least choose which ONE should be listed in the menus
Save button missing in Customize menus/toolbars window.

Less important
The keystrokes showing for Page Up, Page Down, Home, and End are not the official Apple keystrokes (This is not a horrible problem, and I have seen the keystroke icons you used also used in other apps...)
As Justin noted previously, if the same function appears in multiple top level menus, the keystroke only appears in one of them. (@Justin, Are you sure this is a Mac system bug? If so, there may be no solution to this.)

But the changes made already represent a HUGE IMPROVEMENT in the professionalism and useability of any Mac-based REAPER menu system!

Thank you @Justin!!

schwa · 12-05-2021, 01:55 PM

Quote:

Originally Posted by cohler

[*]Save button missing in Customize menus/toolbars window.

v6.42+dev1120 - November 20 2021
+ Menus/Toolbars: replace Save/Close buttons with OK/Cancel

cohler · 12-05-2021, 02:00 PM

Quote:

Originally Posted by schwa

v6.42+dev1120 - November 20 2021
+ Menus/Toolbars: replace Save/Close buttons with OK/Cancel

I see. Thank you for pointing that out.

I actually preferred the Save/Close buttons, because when you are developing a menu system you often make several changes, one step at a time, and you don't want to have to necessarily close and reopen the window each time, which the OK/Cancel version now requires.

But it's not a huge issue. You probably have other reasons why you changed it.

_Stevie_ · 12-05-2021, 03:41 PM

If you are already fixing some keyboard issues, I would like to point you to this thread:
https://forum.cockos.com/showthread.php?t=232318

It’s about keys not working on non-English layouts.

cohler · 12-06-2021, 04:27 AM

Quote:

Originally Posted by cohler

Cannot specify order of keystrokes in Action List, or at least choose which ONE should be listed in the menus

6.42+dev1205a fixed this. Thank you @justin and @schwa!!

akademie · 12-06-2021, 05:50 AM

Quote:

Originally Posted by cohler

<...snip>
I actually preferred the Save/Close buttons, because when you are developing a menu system you often make several changes, one step at a time, and you don't want to have to necessarily close and reopen the window each time, which the OK/Cancel version now requires.
<snip...>

schwa,
I have to agree with cohler here, that for building/customizing toolbars, the 'Save' button was very useful and keeping only 'OK/Cancel' buttons which close the window is a bad move in terms of user friendliness

Then what about adding an automatic updating of the toolbar when adding actions? Then we would not need the save to preview of course.

(It is really pain e.g. if you need to edit the length of the 'text icon' and you have to close and re-open the window over and over just to see the result and justify the text repeatedly so it fits the buttons etc.)

schwa · 12-06-2021, 06:46 AM

Quote:

Originally Posted by akademie

(It is really pain e.g. if you need to edit the length of the 'text icon' and you have to close and re-open the window over and over just to see the result and justify the text repeatedly so it fits the buttons etc.)

Changes appear immediately in the toolbar preview area in the customize window, don't they?

cohler · 12-06-2021, 06:46 AM

@schwa & @justin there is a new significant graphics bug in the latest 6.42+1205a

See bug report here: https://forum.cockos.com/showthread.php?p=2503509

cohler · 12-06-2021, 06:49 AM

Quote:

Originally Posted by schwa

Changes appear immediately in the toolbar preview area in the customize window, don't they?

For menus, changes don't appear now until you click OK.

Before, you could click Save to immediately see menu changes.

Now, if you want to make five menu changes, you need to open and close the window five times.

akademie · 12-06-2021, 08:43 AM

Quote:

Originally Posted by schwa

Changes appear immediately in the toolbar preview area in the customize window, don't they?

They didn't when I tried on latest Linux dev. version (+dev1205 I think) before I wrote my post, to be sure.
(But I can try again in Windows and Linux to confirm.)

EDIT: OK schwa, installed +dev1205a in Windows, and now I know what you mean. Yes, the preview bar in customize window, sure, there are things happening, yes.
But this preview does not take in account the size (width and height) of the real toolbar, so its buttons may be spread over 2 or 3 rows, not just in one row. Then it begins, which buttons set to double-width (and which ones not) to fit all of them nicely in context of the toolbar and group of functions, and also with separators.
So yes, it has basic visual feedback (and it was always there), but being able to see the result in real toolbar (while still in 'edit mode') was very friendly in older releases.

akademie · 12-06-2021, 09:10 AM

Just now I tried the v6.41 and wow, what a pleasure with the (old) 'Save' and 'Close' buttons. pure pleasure.
I definitely don't know the background for this change decision, but from the user perspective it's no good

cohler · 12-06-2021, 10:18 AM

Quote:

Originally Posted by akademie

Just now I tried the v6.41 and wow, what a pleasure with the (old) 'Save' and 'Close' buttons. pure pleasure.
I definitely don't know the background for this change decision, but from the user perspective it's no good

Ditto for the exact same reasons when editing menus.

+1

_Stevie_ · 12-06-2021, 04:08 PM

Yep, ran into this just yesterday and it really makes it harder / takes more time.
Maybe add an „apply“ button? Just a thought.

cohler · 12-06-2021, 07:14 PM

Quote:

Originally Posted by _Stevie_

Yep, ran into this just yesterday and it really makes it harder / takes more time.
Maybe add an „apply“ button? Just a thought.

Thank you @schwa for fixing this in 6.42+dev1206 and adding the Apply button!

akademie · 12-06-2021, 09:02 PM

^^^^^ yes, thanks schwa for 'Apply' button on board

_Stevie_ · 12-06-2021, 10:59 PM

Wow wow, thank you Justin!!!