Theming: MIDI editor: Some elements not visible in dark themes

[juliansader]

Main MIDI editor:

In the main MIDI editor, the horizontal line between tempo markers with gradual transitions is apparently a fixed dark color, instead of following the theme color for "MIDI editor ruler text". As in the next post, this makes the line invisible when using dark themes.


EDIT: I discovered that the linear transition lines are actually themeable, but surprisingly, they use "Time signature lane BACKGROUND" color. This is probably not the best choice, since the lines are scarcely visible in themes that use similar colors for the Arrange view and MIDI editor ruler backgrounds.

Perhaps the lines should use "Time signature change marker", similar to the arrange view? Or "MIDI editor ruler text", similar to the rest of the MIDI editor ruler?

[juliansader]

Inline: FIXED!

Inline MIDI editor:

The background color of the inline editor's CC lanes uses the "MIDI editor ruler background" theme element, but the CC lane names and the lane dividers don't follow "MIDI editor ruler text" color, or any other theme element that I could find.

By default, the CC lane names and the lane dividers seem to be darker shades of the background color. This works fine when using light colored themes, but when dark themes are used, the CC lane names and lane dividers are difficult or impossible to distinguish.

[juliansader]

Example of gradual transition in a bright theme:


Not visible in dark theme:

[juliansader]

CC lane names in the inline editor has been fixed (in some version before v6.12), and these now use "MIDI editor ruler text" color.

Gradual transitions are still not visible in dark themes, though.

[juliansader]

I discovered that the linear transition lines are actually themeable, but surprisingly, they use "Time signature lane BACKGROUND" color. This is probably not the best choice, since the lines are scarcely visible in themes that use similar colors for the Arrange view and MIDI editor ruler backgrounds.

Perhaps the lines should use "Time signature change marker", similar to the arrange view? Or "MIDI editor ruler text", similar to the rest of the MIDI editor ruler?