[IPlug1] Fixed scratch buffers for disconnected I/O

[Tale]

I recently ran into a nasty but apparently obscure bug (it's >10 years old) in IPlug1: If the audio buffer size changes (increases) while inputs/outputs are disconnected, then the old pointer is still used instead of the new pointer. This resulted in crashing the host (Adobe Audition) along with the plug-in (tested with Martinic Lem Echo Music and Scanner Vibrato, as well as Schwa Bitter).

I have pushed a simple fix to the next branch of my IPlug fork:

https://github.com/TaleTN/WDL/commit...7d42b774d59d60

[Nonlinear]

Thank you for posting this “heads up” and fix.

Yes, it is frustrating when issues like this pop up after long periods of thinking “all is well”. I have found VST3 the most troublesome. What format did you see this in - or was it all?

[Tale]

Originally Posted by Nonlinear

Thank you for posting this “heads up” and fix.

You're welcome.

Originally Posted by Nonlinear

Yes, it is frustrating when issues like this pop up after long periods of thinking “all is well”.

Well, I didn't think it was frustrating... More surprising that we can still find bugs after such a long time.

Originally Posted by Nonlinear

I have found VST3 the most troublesome. What format did you see this in - or was it all?

VST 2.4 on Windows.

[Nonlinear]

Originally Posted by Tale

Well, I didn't think it was frustrating....

I bet your customer did when it crashed his/her project.

Originally Posted by Tale

VST 2.4 on Windows.

Now that IS a surprise! I have found VST2 very solid being so well established. Some hosts still don’t support VST3.

[Tale]

Originally Posted by Nonlinear

I bet your customer did when it crashed his/her project.

Yeah, probably...

Originally Posted by Nonlinear

Now that IS a surprise! I have found VST2 very solid being so well established. Some hosts still don’t support VST3.

Well, this is a bug in IPlugBase, so it has nothing to do with any plug-in API. I.e. there is no reason to assume this will not happen with VST3 as well.

However, I don't currently support VST3 at all, and since I mainly do virtual instruments (which require MIDI), I don't think I will add VST3 support anytime soon.

[Nonlinear]

Originally Posted by Tale

However, I don't currently support VST3 at all, and since I mainly do virtual instruments (which require MIDI), I don't think I will add VST3 support anytime soon.

Steinberg is pushing to “kill off” VST2 and VST3 supports MIDI too (supposedly better) so why avoid it? Take the plunge! 😩

Steinberg dropping VST2 actually created a nice side effect for plugin developers in that a ”line in the sand” has been drawn. VST2 is what it is - no future updates with changes or regression errors to worry about!