Old 03-04-2018, 12:11 PM   #41
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

ok going to reapack now

OK got it... yeah fixed

but still prob's

IF the colors is set to 3 then the crash still happens as soon as a trak is selected in the tcp
EDIT: only 0 for colors will not crash...!!!

Also... I still see Original... instead of just the name I enter in the pop up... is that changed for this version???

the rt clk menu while hovering over the name does seem to work fine now

EDIT: Ok so on the Original thing... I can't even delete the Original unless I first rename it... so this something for me I'm not loving...

I would much rather just not have the Original... but rather just a named entry like Red Trk 1 that I type in the name popup...

even more ideal [maybe] would be for it to just grab the track name???
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain

Last edited by hopi; 03-04-2018 at 12:38 PM.
hopi is online now   Reply With Quote
Old 03-04-2018, 01:03 PM   #42
spk77
Human being with feelings
 
Join Date: Aug 2012
Location: Finland
Posts: 2,488
Default

Very nice, Sexan!

The script crashes when saving an unclosed folder:


I had the same bug in "Track Tags" -script, this might help:
Code:
----------------------------------------------------------------------
--    FUNCTION GET FOLDER CHILDS -------------------------------------
---------------------------------------------------------------------- 
function get_folder(tr)
  if reaper.GetMediaTrackInfo_Value(tr, "I_FOLDERDEPTH") <= 0 then return end -- ignore tracks and last folder child
  local depth, children =  0, {}
  local folderID = reaper.GetMediaTrackInfo_Value(tr, "IP_TRACKNUMBER")-1
    for i = folderID + 1 , reaper.CountTracks(0)-1 do -- start from first track after folder
      local child = reaper.GetTrack(0,i)
      local currDepth = reaper.GetMediaTrackInfo_Value(child, "I_FOLDERDEPTH")
      children[#children+1] = reaper.GetTrackGUID(child)--insert child into array
      depth = depth + currDepth
      if depth <= -1 then break end --until we are out of folder 
    end
  return children -- if we only getting folder childs
end
spk77 is offline   Reply With Quote
Old 03-04-2018, 01:14 PM   #43
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Ok new pre up, new user option for storing original track data and fix that color crash again.

spk77 dont quite understand whats happening there? Its a simple folder ? never had that crash ever



What are we doing differently here?
Sexan is offline   Reply With Quote
Old 03-04-2018, 01:22 PM   #44
spk77
Human being with feelings
 
Join Date: Aug 2012
Location: Finland
Posts: 2,488
Default

It's a simple folder, but the last track doesn't "close" the folder. The last track is not toggled to "last track in a folder".
That is kind of special case, though.

Last edited by spk77; 03-04-2018 at 01:29 PM.
spk77 is offline   Reply With Quote
Old 03-04-2018, 01:25 PM   #45
spk77
Human being with feelings
 
Join Date: Aug 2012
Location: Finland
Posts: 2,488
Default

spk77 is offline   Reply With Quote
Old 03-04-2018, 01:29 PM   #46
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

is it still ver. 0.52 on reapack? just updated to that and with colors set to 3 I get this when selecting a simple single track on TCP

...ble\Scripts\Sexan_Scripts\Alpha\Sexan_Track versions.lua:959: attempt to index a nil value (field '?')


the only thing don't crash is colors set to 0

also still get the Original by defaut... would love to see that gone

and again... since we can select multiple tracks to save that are not in a folder, I think there needs to be some way to see that in the list as distinct from both individual tracks and\or folders...

without that things get very confusing, ...just my opinion of course

PS nice to see ya here SPK... since your trak tags and this will really like to work together...
maybe you can give Sexan the code to make his lua always dock in a given docker?
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-04-2018, 01:33 PM   #47
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

I've pushed 5 more version latest is 0.56 and it SHOULD be fixed or I will burn down my studio!

You have now option to store or not original

spk77 thx for the folder fix

EDIT: ok enough coding for today, I had like 15 stupid mistakes in 15 min
Sexan is offline   Reply With Quote
Old 03-04-2018, 01:37 PM   #48
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

yeah kewl Sexan... time for a rest.... tomorrow is another day

and reaper can ruin your life some more then...
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-04-2018, 01:45 PM   #49
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

uploaded last pre for today, removed store original ATM because i need to modify little more things in order to work. And please tell me if still crashes if you change the color (I cannot make it crash last 5 pres) I'm going mad
Sexan is offline   Reply With Quote
Old 03-04-2018, 01:55 PM   #50
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

OK I'm gonna stay with 0.56 for today as it is working kind of nice

the colors really help me a lot!
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-04-2018, 02:01 PM   #51
Reflected
Human being with feelings
 
Reflected's Avatar
 
Join Date: Jul 2009
Posts: 1,993
Default

*subscribed*
Reflected is offline   Reply With Quote
Old 03-04-2018, 02:04 PM   #52
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Quote:
Originally Posted by hopi View Post
OK I'm gonna stay with 0.56 for today as it is working kind of nice

the colors really help me a lot!
it contains lots of crashes so be careful, 0.57 is the same but without store_original setting
Sexan is offline   Reply With Quote
Old 03-04-2018, 02:37 PM   #53
musicbynumbers
Human being with feelings
 
musicbynumbers's Avatar
 
Join Date: Jun 2009
Location: brighton, uk
Posts: 12,568
Default

Subscribed!
__________________
subproject FRs click here
note: don't search for my pseudonym on the web. The "musicbynumbers" you find is not me or the name I use for my own music.
musicbynumbers is offline   Reply With Quote
Old 03-04-2018, 03:46 PM   #54
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

some posts back you asked for a LICECap about the crash when having two folders selected... I guess I did not see it until now... so here it is:

this was done today with ver. 0.56 but I think originally it was with previous version when I noticed it.

https://imgur.com/MT1Dbix

It might take a bit to load up ...and you'll everything seems fine until I use control to
have the two folders selected at the same time

Have not tested with 0.57 but I will so that in a bit

EDIT: Tested with 0.57 and it does the same...

and again the 'good news' is that with 0.56 and 0.57 when calling it back up after that crash, it comes back with everything intact
so don't know what to think.. maybe it's a stupid thing on my part to even try and select more than one folder at a time????
I'd be fine with it only allowing one at a time, but then it should just not even try to save two at the same time... right?
It could just put up a flag that says, "Sorry Dave, you know I can't do that"...
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain

Last edited by hopi; 03-04-2018 at 04:24 PM.
hopi is online now   Reply With Quote
Old 03-04-2018, 04:28 PM   #55
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

will investigate whats going on,but I'm more interested why is the bad string on envelope menu? Is it because of the crash?

But for the love of god I cannot make it crash and I made some weird stuff and like 34 different versions with folders,subofolders,version,emptys....

I mean look at this...

Its like space invaders and pong having sex!!!!!

Can you share that project? It will be easier to debug

and bonus one for the one and only:

Last edited by Sexan; 03-05-2018 at 05:25 AM.
Sexan is offline   Reply With Quote
Old 03-04-2018, 07:14 PM   #56
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

now that is funny... news flash: Reaper is Unprecedented


yeah I'll share the project it is just a very small testing project I'll be back with a link shortly

on the stash here:

https://stash.reaper.fm/v/33035/Test...rak%20tags.rar
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain

Last edited by hopi; 03-04-2018 at 07:22 PM.
hopi is online now   Reply With Quote
Old 03-05-2018, 05:20 AM   #57
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

found the issue regarding you crashes

pre 0.58 (2018-03-05)
+ store original track user setting
+ fixed crash when multiselected tracks do not have same number of versions
+ fixed manual naming
+ prevent renaming original version

chaos from last night is fixed (I hope)
Sexan is offline   Reply With Quote
Old 03-05-2018, 08:26 AM   #58
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Comming Soon™

Sexan is offline   Reply With Quote
Old 03-05-2018, 09:29 AM   #59
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

whoa... it's gonna so what... auto save takes?

OK bring it on...

I have not even tried but I just assumed that tracks would save versions with various active take changes.,.. that must be true, yes?
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-05-2018, 09:32 AM   #60
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Its a PT thing (not yet sure how,why, where) need user feedback (in that FR about Playlist OP mentioned something like this). Also comping functionality will be added

Is the new version ok ? crashes ?
Sexan is offline   Reply With Quote
Old 03-05-2018, 10:39 AM   #61
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

ok just got 0.57

loaded the problem project and ran it
before running it I set it to 'true' and colors 3

when I select both folders at the same time [control clk] and hit the item that is named 'both fld 1" which show in purple
the same crash happens as it always has

...ble\Scripts\Sexan_Scripts\Alpha\Sexan_Track versions.lua:863: attempt to index a nil value (field '?')
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-05-2018, 10:44 AM   #62
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default



Tested and tested and tested (before it crashed but after fix nothing)

Even with everything selected (which before it always crashed)

Wait a second I will upload the latest with some more random bug fixes, but I need to disable some bleeding edge stuff give me a min

EDIT: oh my... you are using old version..... 58 and now 59 is most recent, I did not push reapack-index..... I saw one pending push,did not upload it

Last edited by Sexan; 03-05-2018 at 10:50 AM.
Sexan is offline   Reply With Quote
Old 03-05-2018, 11:08 AM   #63
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

ok I'll get it again.... that was 57 afaik

we'll get there...
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-05-2018, 12:13 PM   #64
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

YaY!!! all fixed... even with all the flags set... way to go ..you da man!!!

no crashes....


so can I request something that would be nicer for me?

spk had some code in his script that would let it dock where desired and remember that location, so that whenever it is called up it goes to that dock.

right now, when I call up yours and dock it, it goes to the MCP track inspector dock at the left of the TCP panels... so I have to drag it out and move it to the dock at the right edge of the arrange window...
I would like it to live at that location, so whenever called up it just goes there. Too much to ask for at this time???
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-05-2018, 12:43 PM   #65
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

that code is already there, in fact it IS his code.
Pushed new update with that fix (I hope) and initial recording takes to versions vodoo

pre v0.60 (2018-03-04)
+ Recording in takes set every take to individual version
+ fixed storing gui
Sexan is offline   Reply With Quote
Old 03-05-2018, 12:45 PM   #66
vanhaze
Human being with feelings
 
vanhaze's Avatar
 
Join Date: Jul 2012
Location: Netherlands
Posts: 4,736
Default

Dear Sexan,

You are spitting out new versions of this great script at insane pace !
I wanna thank you, but take some rest/sleep also please ok ?!
vanhaze is offline   Reply With Quote
Old 03-05-2018, 12:47 PM   #67
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

I can't I'm on fire ... and you guys waited long enough

Btw the new feature takes to versions works only in recording mode (Im trying to emulate PT)

User setting rec_take must be enabled,then which ever track is rec armed it will automatically create versions (it has bug of course ) But I need to know how this thing should work with the rest of versions

one more update pushed,,,some bugs

Last edited by Sexan; 03-05-2018 at 12:54 PM.
Sexan is offline   Reply With Quote
Old 03-05-2018, 03:19 PM   #68
musicbynumbers
Human being with feelings
 
musicbynumbers's Avatar
 
Join Date: Jun 2009
Location: brighton, uk
Posts: 12,568
Default

Exciting stuff! Once I get some time off this project I'm on and it's safe to play. I'll jump in the pool too!
__________________
subproject FRs click here
note: don't search for my pseudonym on the web. The "musicbynumbers" you find is not me or the name I use for my own music.
musicbynumbers is offline   Reply With Quote
Old 03-05-2018, 04:36 PM   #69
amagalma
Human being with feelings
 
Join Date: Apr 2011
Posts: 1,463
Default

Pressing "empty" and then right-clicking a version crashes the script
amagalma is offline   Reply With Quote
Old 03-05-2018, 05:17 PM   #70
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

ver. 063 trying to save takes while recording

...ble\Scripts\Sexan_Scripts\Alpha\Sexan_Track versions.lua:2214: bad argument #1 to 'GetSetMediaItemTakeInfo_String' (MediaItem_Take expected)

what am I doing wrong?

also seems like the flag for original, manual naming and colors are not working ... they did before in 0.59

PS Ok so it insists on creating Original, but then I can't rename the Original... ummmm something go messed in 0.63 I think
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain

Last edited by hopi; 03-05-2018 at 05:24 PM.
hopi is online now   Reply With Quote
Old 03-05-2018, 05:25 PM   #71
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

Quote:
Originally Posted by amagalma View Post
Pressing "empty" and then right-clicking a version crashes the script
confirmed and here is the crash:

...ble\Scripts\Sexan_Scripts\Alpha\Sexan_Track versions.lua:2089: attempt to index a nil value (field '?')
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-05-2018, 05:40 PM   #72
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

Opening a discussion about the Takes thing:

I am not quite understanding why we need or how we would really use this...

My confusion is this:

say we have a track and we are recording takes on it...
ok say we get 9 takes... and we want to play list them

so we make each one the active take and save the track with lets say a number name, like tk-1, tk-2, etc.

Ok so would not that get us to where we could call back any given take already?

And then lets say we have a second item on the same track where we again record a few takes...
So now the problem is to be able to play list various combinations of item one takes with item two takes.... on and on...
So I'm imaging a mess of some huge potential number of takes automatically saved and some difficulty picking the combinations we want...

Perhaps I'm too simple a person [I am ] I'd think I'd be ok with being able to call up the track as saved with all the takes... setting them to active combinations in the items themselves and then saving all that as a named track version, like trk2-tks1+3+4+6 for the takes in the various items...

OK... I'll shut the F up and listen to 'your' sense of how this would benefit 'you'....

[I'm not against it, just having a time wrapping my poor little head around it]
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-06-2018, 02:37 AM   #73
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Take thingy will not work the way they are now, I need some guidance regarding it (the plan is to emulate how pro tools does it,Im also watching lots of YT videos of PTPlaylist)

There is a bug with them that I cannot figure out yet when recording starts before the loop points, if you record in loop points everything is cool

Will fix that empty bug soon,and will disable takes for now until other stuff is fixed

EDIT : New pre up : empty fix etc, disabled takes

@hopi I set on purpose original cannot be renamed because right now its the only way of checking is that the first created version (not to lose data). Maybe if I find another way to check it I will allow that

Last edited by Sexan; 03-06-2018 at 06:00 AM.
Sexan is offline   Reply With Quote
Old 03-06-2018, 12:24 PM   #74
spk77
Human being with feelings
 
Join Date: Aug 2012
Location: Finland
Posts: 2,488
Default

@Sexan
Item pointer changes when Reaper splits an item. That's why the script crashes, I think.
This might fix the crashing (note: item positions are not correct after this "fix" )

Code:
--------------------------------------------------------------------------------
---  Function MAKE VERSION FROM RECORDED TAKES  --------------------------------
--------------------------------------------------------------------------------
function takes_to_version()
  local item_tb = {}
  for j = 1, reaper.CountSelectedMediaItems( 0 ) do  
    local s_item = reaper.GetSelectedMediaItem(0, j-1)
    local s_item_guid = reaper.BR_GetMediaItemGUID(s_item)
    local take_num = reaper.CountTakes( s_item )
    --reaper.Main_OnCommand(41348,0) -- remove empty take
    --item_tb[j] = s_item
    --if take_num > 1 then item_tb[j] = s_item end-- add newly created takes to table
    if take_num > 1 then item_tb[j] = s_item_guid end-- add item guids to table
  end
  reaper.PreventUIRefresh(1)
  for k = 1, #item_tb do
    local titems = {}
    --local s_item = item_tb[k]
    local s_item = reaper.BR_GetMediaItemByGUID(0, item_tb[k]) -- get item pointers from stored guids
.
.
.
spk77 is offline   Reply With Quote
Old 03-06-2018, 01:54 PM   #75
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Thank you!!! Working great now (fixed the position issue)

pre v0.65 (2018-03-04)
+ fixed bugs with right click menus
+ little gui rearange
+ single save/folder button based on what type of track is selected
+ added selected track name to GUI
+ fixed rec takes to version (thx Spk77)

Bad boy now looks like this

Last edited by Sexan; 03-06-2018 at 02:50 PM.
Sexan is offline   Reply With Quote
Old 03-07-2018, 04:50 AM   #76
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

pre v0.67 (2018-03-07)
+ Added time selection version (can be created only if initial version exist)
+ fixed crash when deleting version after empty is clicked

Added time selection version (the way musicbynumbers wanted). There must be at least one version saved in to make time selection versions (in order not to be destructive)
Sexan is offline   Reply With Quote
Old 03-07-2018, 05:51 AM   #77
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

OK kewl found my way... it just was not yet showing up in the browser
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-07-2018, 06:17 AM   #78
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

OK got this version now...

noticed something...

say we have a couple saves where items are selected and then do another save with the track selected but the items moved but set to unselected

ok then we go in the lua to one of the saves that has items selected and then back to the save with them unselected... I would expect them to show as unselected but they instead retain the selected state from the previous save....
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Old 03-07-2018, 07:18 AM   #79
Sexan
Human being with feelings
 
Sexan's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 2,059
Default

Not sure if I understand, can you licecap it ?
Sexan is offline   Reply With Quote
Old 03-07-2018, 09:42 AM   #80
hopi
Human being with feelings
 
hopi's Avatar
 
Join Date: Oct 2008
Location: Right Hear
Posts: 13,740
Default

surely

you'll see it all working fine but the last save is with the items unselected
but we can never actually recall to that unselected items condition

https://imgur.com/a/LDAXP
__________________
...should be fixed for the next build... http://tinyurl.com/cr7o7yl
https://soundcloud.com/hopikiva/angel-rain
hopi is online now   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 05:16 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.