Old 05-31-2016, 05:20 PM   #1
PitchSlap
Human being with feelings
 
PitchSlap's Avatar
 
Join Date: Jan 2008
Location: Vancouver, BC
Posts: 3,273
Default MIDI Bug in 5.21 pre5 [p=1685190 related]

Starting with this version I've been having problems previewing MIDI files with the Media Explorer. The start of files either doesn't play at all, or cuts off depending on the VSTi.

My guess is its related to the note off changes in this version as pre4 and before are fine.

Here's my original bug report.
http://forum.cockos.com/showpost.php...89&postcount=3
__________________
FRs: v5 Media Explorer Requests, Global Quantization, Session View
Win10 Pro 64-bit, Reaper 6(x64), AMD 3950x, Aorus X570 Master, 64GB DDR4 3600, PowerColor Red Devil 5700XT, EVO 970 2TB, 10TB HD, Define R6
PitchSlap is offline   Reply With Quote
Old 06-04-2016, 04:56 AM   #2
PitchSlap
Human being with feelings
 
PitchSlap's Avatar
 
Join Date: Jan 2008
Location: Vancouver, BC
Posts: 3,273
Default

Here's a LICEcap showing the problem which still occurs in pre9.

__________________
FRs: v5 Media Explorer Requests, Global Quantization, Session View
Win10 Pro 64-bit, Reaper 6(x64), AMD 3950x, Aorus X570 Master, 64GB DDR4 3600, PowerColor Red Devil 5700XT, EVO 970 2TB, 10TB HD, Define R6
PitchSlap is offline   Reply With Quote
Old 06-04-2016, 05:42 AM   #3
ELP
Human being with feelings
 
Join Date: Apr 2014
Posts: 943
Default

[02:17:31:000802]: [Note on] RAW:[90 41 64]
[02:17:31:000802]: [Note on] RAW:[90 3a 64]
[02:17:31:000802]: [Note on] RAW:[90 4a 64]
[02:17:31:000802]: [Note on] RAW:[90 46 64]
-
[02:17:31:000802]: [All notes off] RAW:[b0 7b 00] > This is the problem why notes cut at the beginning
-
[02:17:34:000200]: [Note off] RAW:[80 41 40]
[02:17:34:000200]: [Note off] RAW:[80 3a 40]
[02:17:34:000200]: [Note off] RAW:[80 4a 40]
[02:17:34:000200]: [Note off] RAW:[80 46 40]
...
And Yes this is a newer bug and it happens only if you import or preview Format 1 Midi files
..
Another very simple example (attachment)
both have the same 135 BPM tempo included..
One is saved as Format 1 the other as Format 0..

I explained the problem already(pre6) but no reaction from Devs.
Here it is once more..
Both MIDI examples attached...
Both the same simple events except one is format 1 the other Format 0..

Format 1 cuts the first note by sending one single All Notes off
... in between the first Note ON-Off After import or preview

Format 0
this do not happen..

It is a new bug! and now not only happen during preview.

It happens (5.21pre9) also after import Format 1 MIDI Files..
(import Tempo or not doesnt matter)
Format 1 produce this single All Notes Off event..
Format 0 the same events not...

Import both and compare..

This must/should be fixed dear Devs, because it is now not only during preview
this single All Notes Off event is also happen at the track with the imported format 1 file...

Greetings
---
At the moment I have to unpack my old ALL Notes Off spam filter again and put it on the tracks which include the from format 1 imported MIDI events.
Attached Files
File Type: mid Format0-135BPM.mid (75 Bytes, 152 views)
File Type: mid Format1-135BPM.mid (87 Bytes, 148 views)
__________________
I hope you can understand me? Without german beer my written english is always very bad, with beer it becomes unbearable!.
Less is more! To much limited the own creativity.

Last edited by ELP; 06-04-2016 at 06:11 AM.
ELP is offline   Reply With Quote
Old 06-04-2016, 07:37 AM   #4
ELP
Human being with feelings
 
Join Date: Apr 2014
Posts: 943
Default

this bug is for me clear introduced with:
pre5
+ MIDI: increase imported MIDI file source lengths using MIDI end-of-track meta event if present,

PitchSlap

REAPER insert for every END Of Track Meta event always one B0 7B 00 at the End of the Track/Item
Thatīs ok as long this is not the very first track 0 of format 1... which End OF is mixed now
with the first channel event track 1 and the All Notes OFF see landed...

Import RAW:
+0 0: FF 03 6D[m] 69[i] 64[d] 69[i] 5F[_] 65[e] 78[x] 70[p] 6F[o] 72[r] 74[t]
+0 0: 90 3C 60
+0 0: B0 7B 00 <<<<<< landed here^^
+3840 3840: 80 3C 00
+3840 7680: 90 30 7F
+3840 11520: 80 30 00
+0 11520: B0 7B 00

:Source Format1-135BPM.mid:
MThd | Format=1 | # of Tracks=2 | Division=960

Track #0 ******************************************
Time Event
1: 1: 0 |Track Name | len=11 |
0x6D 0x69 0x64 0x69 0x5F 0x65 0x78 0x70 0x6F 0x72 0x74 <midi_export>
|Time Sig | 4/4 | MIDI-clocks\click=24 | 32nds\quarter=8
|Tempo | BPM=135 | micros\quarter=444444
|End of track| >>> this imported at 1.0.000 as All notes off

Track #1 ******************************************
Time Event
1: 1: 0 |On Note | chan= 1 | pitch=C 3 | vol=96
2: 1: 0 |Off Note | chan= 1 | pitch=c 3 | vol=0
3: 1: 0 |On Note | chan= 1 | pitch=C 2 | vol=127
4: 1: 0 |Off Note | chan= 1 | pitch=c 2 | vol=0
|End of track|
..

EDIT:

another thing which changed maybe at this pre point is:
Within List View Controller above 119 arenīt be visible anymore.
also the END not visible..
You can insert/'change one to for example 121(Controller Reset) and it is somewhat visible but these would be automatically delete, I mean not visible anymore after close and re-open after.
Only within RAW view
..
I find this very problematic and really not the way one List View should work.
List views has always to show all and also the possibility to insert all'(at least the complete range of standard events like the complete range of All Controller)

And please have a look at the Controller names above cc119(120-127)-(within event properties) -they wear the Note names range 120-127
__________________
I hope you can understand me? Without german beer my written english is always very bad, with beer it becomes unbearable!.
Less is more! To much limited the own creativity.

Last edited by ELP; 06-04-2016 at 08:33 AM.
ELP is offline   Reply With Quote
Old 06-04-2016, 09:07 AM   #5
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 12,948
Default

Quote:
Originally Posted by ELP View Post
this bug is for me clear introduced with:
pre5
+ MIDI: increase imported MIDI file source lengths using MIDI end-of-track meta event if present,
Thanks, fixing this
Justin is offline   Reply With Quote
Old 06-04-2016, 12:11 PM   #6
ELP
Human being with feelings
 
Join Date: Apr 2014
Posts: 943
Default

Thank you Justin.

thank you PitchSlap that you opening this extra thread

I would not have done..

Just for notice:
I verified shortly my belief about this END of Track-0 mixed into ..
I changed the END of Track-0 from above little Format 1 example from 1.1.0 to
position 3.1.0 and the result is:

Raw:
+0 0: 90 3C 60
+3840 3840: 80 3C 00
+3840 7680: 90 30 7F
+0 7680: B0 7B 00 >>> mixed into track-1 position 3.1.000 ^^
+3840 11520: 80 30 00
+0 11520: B0 7B 00

the real problem for me is also that none of the controller above 119
is (only at the moment I hope)not always visible anymore
(I mean of course within the List editor)
__________________
I hope you can understand me? Without german beer my written english is always very bad, with beer it becomes unbearable!.
Less is more! To much limited the own creativity.
ELP is offline   Reply With Quote
Old 06-08-2016, 01:25 PM   #7
ELP
Human being with feelings
 
Join Date: Apr 2014
Posts: 943
Default

Fixed with 5.21pre10

"PitchSlap: Here's a LICEcap showing the problem which still occurs in pre9.
---

+ MIDI: increase imported MIDI file source lengths using MIDI end-of-track meta event if present,....
"
__________________
I hope you can understand me? Without german beer my written english is always very bad, with beer it becomes unbearable!.
Less is more! To much limited the own creativity.
ELP is offline   Reply With Quote
Old 06-10-2016, 06:45 PM   #8
PitchSlap
Human being with feelings
 
PitchSlap's Avatar
 
Join Date: Jan 2008
Location: Vancouver, BC
Posts: 3,273
Default

Seems mostly fixed, but still having an issue with missing notes in the first chord.

The problem occurs when switching files while playing. If I stop the media explorer preview before clicking the next file it will play fine.

Are you getting anything similar ELP?
__________________
FRs: v5 Media Explorer Requests, Global Quantization, Session View
Win10 Pro 64-bit, Reaper 6(x64), AMD 3950x, Aorus X570 Master, 64GB DDR4 3600, PowerColor Red Devil 5700XT, EVO 970 2TB, 10TB HD, Define R6
PitchSlap is offline   Reply With Quote
Old 06-10-2016, 11:20 PM   #9
ELP
Human being with feelings
 
Join Date: Apr 2014
Posts: 943
Default

you mean if you switch on the fly during playback?

Thatīs really one technically result.
REAPER transmit after switching to a new file (within/from Media Explorer)
one set off All Notes Off ch 1-16
+ one set of Hold off ch1-16 to prevent hanging notes... thatīs ok/necessary

And if you switch to files like your PAD.mid which has Notes begin at 1.0.000
the All Notes off/Hold Off+ the new Notes would be transmit at the same time-stamp to the plugin

first All Note off/hold off + the new Notes(same time stamp)...
with some or better mostly all plugins this would end in of course some missing notes at the beginning..

If REAPER should prevent this, there
must be at least one artificial time break between the All Notes Off/hold off events
and the events from the new File.(switching during playback-on the fly)

As I said this is more one technically result and less a bug.

And thatīs why things play fine(no missing notes with same files at the beginning)
if you fist stop before switching to next... or after the first pattern/time loop(if loop is enable)

but the actual relevant previous bug in any case no longer exists.
__________________
I hope you can understand me? Without german beer my written english is always very bad, with beer it becomes unbearable!.
Less is more! To much limited the own creativity.

Last edited by ELP; 06-10-2016 at 11:44 PM.
ELP is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 06:45 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.