[6.25] Close FX windows odd behaviour (FIXED)

vitalker · 03-12-2021, 09:08 AM

Hello.

The video(GIF) below is showing the behaviour. No scripts are running in the background. The project is made from scratch.

Bug: closing FX windows doesn't create undo points (maybe it should be excluded from Undo history at all. Even if it creates undo points, travelling between different undo points doesn't open/close FX windows again.

Expected behaviour: opening/closing FX (chain) windows should not create any undo points. Otherwise if they're created, they should allow to undo/redo.

Windows 10 Pro, Reaper 6.25 64-bit.

vitalker · 03-22-2021, 11:08 AM

Anyone?

JamesPeters · 03-22-2021, 11:27 AM

Confirmed in Reaper for Linux v6.25+dev0319

vitalker · 03-22-2021, 01:45 PM

Quote:

Originally Posted by JamesPeters

Confirmed in Reaper for Linux v6.25+dev0319

Thanks!

Spookye · 03-23-2021, 05:44 AM

Quote:

Originally Posted by vitalker

Anyone?

Here everything is fine. Windows 7 x32

vitalker · 03-23-2021, 06:10 AM

Quote:

Originally Posted by Spookye

Here everything is fine. Windows 7 x32

Did you do the same like on the GIF?

Fabian · 03-23-2021, 03:12 PM

Are you talking about this https://forum.cockos.com/showthread.php?t=177119

It has been around for a long time apparently, and there is some argument for why it is like it is. However, it also creates some issues of its own. I just now stumbled on a bug with my MFXlist, when undoing past a Close FX Chain undo point...

vitalker · 03-23-2021, 03:20 PM

Quote:

Originally Posted by Fabian

Are you talking about this https://forum.cockos.com/showthread.php?t=177119

Well not exactly. Excluding it from undo history would probably solve it, but I am talking about inconsistency. Undo points are created, but as you can see on my GIF, sometimes they behave really odd. One time it will undo and open FX chain back, but another time nothing will happen.

Justin · 03-23-2021, 05:37 PM

The original reason for the "closing window" undo point is to catch any unreported state changes from plug-ins... maybe that's outdated and we should remove it (or at least make it optional)

vitalker · 03-24-2021, 01:22 AM

Quote:

Originally Posted by Justin

The original reason for the "closing window" undo point is to catch any unreported state changes from plug-ins... maybe that's outdated and we should remove it (or at least make it optional)

Yes! It would be awesome! As you can see, I am talking about not closing fx window itself and adding undo point, but its odd behaviour. These undo points don't work properly like for other actions.

nappies · 03-24-2021, 03:03 AM

It would be cool! It makes you do a lot of unnecessary movements when you need to undo.

Fabian · 03-24-2021, 11:49 AM

Quote:

Originally Posted by Justin

The original reason for the "closing window" undo point is to catch any unreported state changes from plug-ins... maybe that's outdated and we should remove it (or at least make it optional)

That would (probably) solve the strange behavior in MFXlist (https://forum.cockos.com/showthread.php?t=248411) that I've seen when I undo such a close FX chain in one project tab, and then close the tab. MFXlist gets confused and crashes.

vitalker · 04-05-2021, 05:04 AM

I hope we will see it in 6.27.

nappies · 04-06-2021, 12:38 PM

Quote:

Originally Posted by vitalker

I hope we will see it in 6.27.

Would be very cool!

Edgemeal · 04-11-2021, 10:31 AM

v6.27 - April 11 2021
+ FX: add option to not add undo points when closing FX windows [t=250733]

vitalker · 04-11-2021, 11:15 AM

Quote:

Originally Posted by Edgemeal

v6.27 - April 11 2021

I already changed the title when rc4 was released.