COCKOS
CONFEDERATED FORUMS
Cockos : REAPER : NINJAM : Forums
Forum Home : Register : FAQ : Members List : Search :
Old 10-19-2017, 12:47 AM   #1
mibes
Human being with feelings
 
Join Date: Apr 2017
Posts: 36
Default Click when muting plugin. Logic

I get a click when muting/un-muting my plugin in Logic X.

Not really sure how to go about fixing it. Is there a standard approach?
mibes is offline   Reply With Quote
Old 10-19-2017, 05:42 AM   #2
1eqinfinity
Human being with feelings
 
Join Date: Apr 2014
Posts: 84
Default

Idk the specifics of Logic, but my first idea would be to check if your plugin has any DC in the output.
__________________
soundcloud.com/crimsonbrain

Last edited by 1eqinfinity; 10-19-2017 at 06:04 AM.
1eqinfinity is offline   Reply With Quote
Old 10-19-2017, 06:17 AM   #3
Tired_Joe
Human being with feelings
 
Join Date: Apr 2015
Posts: 55
Default

does it click when Logic is not playing? oder during signal processing?
Tired_Joe is offline   Reply With Quote
Old 10-19-2017, 10:36 AM   #4
earlevel
Human being with feelings
 
Join Date: Dec 2015
Posts: 331
Default

Quote:
Originally Posted by mibes View Post
I get a click when muting/un-muting my plugin in Logic X.

Not really sure how to go about fixing it. Is there a standard approach?
When you mute/unmute, you are switching between input and processed—and that's all the plugin framework does.

As noted somewhere on the board, that wasn't adequate for me (though primarily for other reasons that just the possibility of a click), and I modified the framework to be able to override the bypass behavior. Then I had my override ramp the processing up/down quickly to make the transitions smooth.

Busy at the moment, but I'll elaborate when I get a chance...
earlevel is offline   Reply With Quote
Old 10-19-2017, 11:43 AM   #5
earlevel
Human being with feelings
 
Join Date: Dec 2015
Posts: 331
Default

Here's the mod I did:

https://forum.cockos.com/showpost.ph...68&postcount=9

Behavior is unchanged, but now you have a method ProcessBypass that you can override for your own behavior.

For example, in my delay plugin, I'm mainly interested in not trapping and recirculating glitches in the delay lines when bypassing and unbypassing. In addition to the usual override of ProcessDoubleReplacing, I override ProcessBypass. I have a gain object that ramps gain up or down depending on whether it is muting or unmuting (driven by a state machine). That element is used as part of my audio processing chain, to apply gain heading into my delay lines. When bypassed, ProcessBypass is called, and I "mute", initiating the down ramping of the gain element. (It doesn't matter that I repeatedly command it to mute every time I process a buffer, because the state machine keeps it on track.) I call my normal audio processing method, then discard the result and copy the input to the buffer—because I only care about maintaining the delay lines internally.

When unbypassed, I "unmute", and process as usual.

If you're getting pronounced clicks, you could have DC offset, or it could just be large differences due to processing and levels.
earlevel is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 02:34 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.