|
|
|
01-31-2022, 09:03 AM
|
#81
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by lampshade
Hello FeedTheCat,
sorry for the late reply.
I have found the reason for the error.
When the media explorer is set to list --> MX-Tuner does not work (at least not for me).
When the media explorer is set to details it works.
Thank you.
|
Wow, I've never even noticed that option... It doesn't exist on Linux or MacOS. And it's not in the action list as well (I literally went through all options to check if there's one that's misbehaving). I guess that's reaper lol, options everywhere...
Anyhow, thx for reporting. Should hopefully now work correctly in v1.5.4.
|
|
|
01-31-2022, 09:45 AM
|
#82
|
Human being with feelings
Join Date: Dec 2008
Posts: 96
|
Quote:
Originally Posted by FeedTheCat
Wow, I've never even noticed that option... It doesn't exist on Linux or MacOS. And it's not in the action list as well (I literally went through all options to check if there's one that's misbehaving). I guess that's reaper lol, options everywhere...
Anyhow, thx for reporting. Should hopefully now work correctly in v1.5.4.
|
Sometimes i wish that the list-view exist on MacOS.
In list view the scrolling is horizontally.
This way you can see more files without scrolling.
Sorry for my english
|
|
|
02-15-2022, 11:59 AM
|
#83
|
Human being with feelings
Join Date: Jan 2013
Posts: 648
|
Docked on right side, when adjust height to be too low, then GUI flicks and if I drop all way down it can damage window docked above. Win7 x64 Reaper 6.46 dev0120
__________________
Love is patient and kind; love does not envy or boast; it is not arrogant or rude.
It does not insist on its own way; it is not irritable or resentful;
it does not rejoice at wrongdoing, but rejoices with the truth. Corinthians 13:4-6
|
|
|
02-15-2022, 12:52 PM
|
#84
|
Human being with feelings
Join Date: Jul 2018
Location: Torino, Italia
Posts: 736
|
Quote:
Originally Posted by strachupl
Docked on right side, when adjust height to be too low, then GUI flicks and if I drop all way down it can damage window docked above. Win7 x64 Reaper 6.46 dev0120
|
Have you tried to hook it in its place? In media explorer .... here it works fine and flicker-free.
|
|
|
02-15-2022, 02:05 PM
|
#85
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by strachupl
Docked on right side, when adjust height to be too low, then GUI flicks and if I drop all way down it can damage window docked above. Win7 x64 Reaper 6.46 dev0120
|
That's weird.. I'll see if I can replicate.
|
|
|
02-15-2022, 03:32 PM
|
#86
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
I can replicate it, but it's not specific to this script. (Happens with the theme adjuster as well).
|
|
|
02-19-2022, 09:35 AM
|
#87
|
Human being with feelings
Join Date: Jan 2013
Posts: 648
|
Quote:
Originally Posted by FeedTheCat
I can replicate it, but it's not specific to this script. (Happens with the theme adjuster as well).
|
Maybe it is Reaper itself. I am on Win 7 x64.
__________________
Love is patient and kind; love does not envy or boast; it is not arrogant or rude.
It does not insist on its own way; it is not irritable or resentful;
it does not rejoice at wrongdoing, but rejoices with the truth. Corinthians 13:4-6
|
|
|
02-19-2022, 11:57 AM
|
#88
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by strachupl
Maybe it is Reaper itself. I am on Win 7 x64.
|
Yeah, I think so. Happens on Win10 as well.
|
|
|
02-19-2022, 01:12 PM
|
#89
|
Human being with feelings
Join Date: Jul 2009
Posts: 3,294
|
very cool!
|
|
|
03-01-2022, 03:00 AM
|
#90
|
Human being with feelings
Join Date: Aug 2011
Location: Germany
Posts: 241
|
Hi,
as I added a feature request for this functionality (see signature), I'm blown away that something is already existant right now!
Well done!!
As I played around with it, I'd like to ask for some features:
* When detection is wrong (filename says C#, MX Tuner says G), is there a way to "set" the correct key manually? Maybe via CTRL+SHIFT+Click on the desired note (in example: click on C#)
* I'd like to have "filename detection only" (no fft/ftc), so we may finetune that setting a bit deeper!?
* Can you provide a list of filename detection settings you're using? We might enhance that list. I can provide a wide range of possibilities (also regex'd if needed) ^.^
However, great script!! Donation will be done soon!
|
|
|
03-01-2022, 05:42 AM
|
#91
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by Lopez
* When detection is wrong (filename says C#, MX Tuner says G), is there a way to "set" the correct key manually? Maybe via CTRL+SHIFT+Click on the desired note (in example: click on C#)
|
I guess you could add metadata (KEY) to the file so that MX Tuner detects it correctly in the future. I like the idea of ctrl+clicking on the keyboard to set the metadata automatically... I'll check if it's possible.
Quote:
Originally Posted by Lopez
* I'd like to have "filename detection only" (no fft/ftc), so we may finetune that setting a bit deeper!?
|
Hmmm, I'm wondering why you'd want that. I was considering adding a status icon so that it's possible to tell if MX tuner got the pitch from metadata, filename or file directly. Would that work for you?
Quote:
Originally Posted by Lopez
* Can you provide a list of filename detection settings you're using? We might enhance that list. I can provide a wide range of possibilities (also regex'd if needed) ^.^
|
Probably not going to be very helpful, but currently it's just a "simple" regex that looks like this
Code:
local note_name = file:match('[%s_[(]([CDEFGAB]%d?[#b]?)[])_]?%d*%.[^.]+$')
If you have examples of keys in file names that MX Tuner isn't picking up correctly, feel free to send me a list. I'll do my best to incorporate them.
Last edited by FeedTheCat; 03-01-2022 at 05:50 AM.
|
|
|
03-01-2022, 09:38 AM
|
#92
|
Human being with feelings
Join Date: Aug 2011
Location: Germany
Posts: 241
|
Quote:
Originally Posted by FeedTheCat
I guess you could add metadata (KEY) to the file so that MX Tuner detects it correctly in the future. I like the idea of ctrl+clicking on the keyboard to set the metadata automatically... I'll check if it's possible.
|
Sounds great!
To add metadata for myself isn't handy at all, let's say I have a bunch of sample libs with 5k samples overall... no way to set metadata for all of these. I have no idea (furthermore, I don't think so) that sample lib creators are setting metadata correctly.
Anyway, the CTRL+SHIFT+Click (or any shortcut like that) for saving/setting metadata key would be great!
Quote:
Originally Posted by FeedTheCat
Hmmm, I'm wondering why you'd want that. I was considering adding a status icon so that it's possible to tell if MX tuner got the pitch from metadata, filename or file directly. Would that work for you?
|
That would be good, but won't help at my point.
As example, I found some samples where key is given with e.g. C, but MXTuner said A. As result, a keylock wouldn't help here because it would have the wrong pitch then.
But let me say:
That appears mostly, when the sample contains "rich" audio like multilayers (aka multi, combo or full named files) or hard-to-define content like pads, textures or something like that.
In these cases I'd like to rely on the creators given key in the filename (even when it's wrong).
Furthermore, MX Tuner doesn't work for midi files right now - but I guess it could!? The pitch knob in media explorer is doing the same job for midi like for samples (I love Reaper so much <3), so it would be awesome to determine the root key of the midi file, and change it via MX Tuner like with samples. That's only possible with key determination by filename
Quote:
Originally Posted by FeedTheCat
Probably not going to be very helpful, but currently it's just a "simple" regex that looks like this
Code:
local note_name = file:match('[%s_[(]([CDEFGAB]%d?[#b]?)[])_]?%d*%.[^.]+$')
If you have examples of keys in file names that MX Tuner isn't picking up correctly, feel free to send me a list. I'll do my best to incorporate them.
|
Ok, the root key is mostly written like these (all examples on C)
C
Cmin (sometimes "Cm" as shortcut for Cmin)
Cmaj
The black keys are correctly named like C# or Bb in your regex.
The root key con be on filename start or end, but often in between.
Mostly (I say >90%) surrounded (if not on start/end) by underscore ( _ ) , sometimes with minus ( - ), sometimes with blank spaces or dots (not that often).
Examples:
X_130_C_Syn_Bass_01.wav
x_126_bass_Fmin.wav
X_K1_G#1_Pedal_Hihat.wav
VMH2 Melodyloop 1 C 128 Bpm.wav
One more, but these are *not* necessary to parse:
VMH2 Synth Cutz 051 F#Maj7.wav
Hope it helps! Thanks for your great work!
|
|
|
03-02-2022, 11:08 AM
|
#93
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Update to v1.6:
- Added support for MIDI files. (lowest pitched note in file is used as pitch)
- Improved file name pitch parsing (detect many additional cases)
- Added indicator icon for parsing modes:
F indicates that pitch was found in file name
M indicates that pitch was found in metadata
You can click the indicator to temporarily bypass parsing (and analyze media content for pitch instead)
Last edited by FeedTheCat; 03-02-2022 at 11:15 AM.
|
|
|
03-03-2022, 05:02 AM
|
#94
|
Human being with feelings
Join Date: Aug 2011
Location: Germany
Posts: 241
|
Quote:
Originally Posted by FeedTheCat
Update to v1.6:
|
At least the indicator is not showing up yet (a sample in media explorer is selected)
Win x64, mxtuner not docked
|
|
|
03-03-2022, 05:43 AM
|
#95
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by Lopez
At least the indicator is not showing up yet (a sample in media explorer is selected)
Win x64, mxtuner not docked
|
My bad... somehow only the MIDI stuff got pushed in v1.6.0... Should now work with v1.6.1.
Last edited by FeedTheCat; 03-03-2022 at 05:58 AM.
|
|
|
03-03-2022, 08:18 AM
|
#96
|
Human being with feelings
Join Date: Aug 2011
Location: Germany
Posts: 241
|
Quote:
Originally Posted by FeedTheCat
My bad... somehow only the MIDI stuff got pushed in v1.6.0... Should now work with v1.6.1.
|
Works like a charm now! <3
Donation is sent!
|
|
|
04-23-2022, 01:38 PM
|
#97
|
Human being with feelings
Join Date: Apr 2022
Location: Taiwan
Posts: 27
|
hi FTC, love the your stuff. some samples work some samples give me a crash.
|
|
|
04-24-2022, 03:24 AM
|
#98
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Update to v1.7.0
Note: Script now requires REAPER v6.52+
The script now uses newly added native actions to set the pitch. This makes it possible to tune to continuous values (cents) without issues. This behavior is now enabled by default, but if you already have MX Tuner installed you'll have to switch manually:
Settings (right click) > Pitch snap > Continuous
The results will be more accurate, especially when tuning stuff like congas, toms etc. (Instead of setting pitch to exactly 3.00, the script can now set values like 3.32 without drawbacks)
Quote:
Originally Posted by rgryrgryrgry
hi FTC, love the your stuff. some samples work some samples give me a crash.
|
Thx! Should hopefully be fixed in v1.7.0.
|
|
|
04-24-2022, 06:18 AM
|
#99
|
Human being with feelings
Join Date: Dec 2020
Location: Miami, FL USA
Posts: 396
|
Holy shit, this is an incredible idea -- thank you!
Particularly the ability to lock samples to a key. I can never quickly calculate the distance between a sample and the key I want, in my head.
__________________
Seasoned codemonkey
Dunno a thing about making music (here to learn!)
|
|
|
04-24-2022, 07:23 AM
|
#100
|
Human being with feelings
Join Date: Dec 2020
Location: Miami, FL USA
Posts: 396
|
Feature request:
Parsing minor from note names using the following possible note-name suffixes:
- (Note)m
- (Note)_m
- (Note)min
- (Note)_min
- (Note)minor
- (Note)_minor
The reason why I ask is because samples are a mess like this:
I can see the code here, but this is one hell of a regex:
Code:
function GetPitchFromFileName(file)
-- Parse note name from file name
local pattern_pre = '([%s_[(-.])'
local pattern_note = '([CDEFGAB][#b]?)'
local pattern_add = '(%d?m?[Mmdas]?[aiduM]?[jnmds]?%d*)'
local pattern_post = '([%s_[(-.])'
local pattern = pattern_pre .. pattern_note .. pattern_add .. pattern_post
local file_name = file:match('([^\\/]+)$')
local file_note
for pre, note, add, post in file_name:gmatch(pattern) do
-- Note: Avoid patterns like 'Color B 12'
if pre == ' ' and post == ' ' and add == '' then note = nil end
if not file_note then file_note = note end
-- Keep matches later in the item name (or longer e.g. with #)
if note and #note >= #file_note then file_note = note end
end
-- Check if note is at beginning of file
if not file_note then
pattern = '^' .. pattern_note .. pattern_add .. pattern_post
file_note = file_name:match(pattern)
end
return NameToFrequency(file_note)
end
function NameToFrequency(name)
local n = {'A', 'A#', 'B', 'C', 'C#', 'D', 'D#', 'E', 'F', 'F#', 'G', 'G#'}
if name == 'Db' then name = 'C#' end
if name == 'Eb' then name = 'D#' end
if name == 'Gb' then name = 'F#' end
if name == 'Ab' then name = 'G#' end
if name == 'Bb' then name = 'A#' end
for i = 1, #n do
if name == n[i] then
return 440 * math.exp((i - 1) * math.log(2) / 12)
end
end
end
__________________
Seasoned codemonkey
Dunno a thing about making music (here to learn!)
Last edited by gxray; 04-24-2022 at 07:31 AM.
|
|
|
04-24-2022, 08:30 AM
|
#101
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by gxray
Feature request:
Parsing minor from note names using the following possible note-name suffixes:
- (Note)m
- (Note)_m
- (Note)min
- (Note)_min
- (Note)minor
- (Note)_minor
The reason why I ask is because samples are a mess like this:
I can see the code here, but this is one hell of a regex:
|
Yeah, the regex is creepy already
Afaict, most of the file names you posted should already be detected correctly. I quickly pushed an update to also include the full minor/major keywords (it would detect Cmin but not Cminor).
I'm a bit hesitant to support parsing C_minor (underscore between). Not sure if it could mess up the regex. I'd have to look into it more. Don't think it's a common naming convention as well, but I might be wrong. Can you check how many samples you have that use this?
|
|
|
04-25-2022, 04:19 AM
|
#102
|
Human being with feelings
Join Date: May 2017
Posts: 454
|
How do i add this to be a part of the media browser?
|
|
|
04-25-2022, 04:31 AM
|
#103
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by SubbaseDnB
How do i add this to be a part of the media browser?
|
I have the media explorer docked to the side and MX Tuner docked beneath it (as seen in the GIF). If you don't want to dock it there's various other options in the Menu (right click) > Window. For example you could position it somewhere you like and hide the window frame.
|
|
|
04-25-2022, 05:13 AM
|
#104
|
Human being with feelings
Join Date: Apr 2022
Location: Taiwan
Posts: 27
|
thank you so much it stopped crashing for me. i noticed that it doesn't work on databases for me but samples in folders work perfectly is that normal?
|
|
|
04-25-2022, 05:37 AM
|
#105
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by rgryrgryrgry
thank you so much it stopped crashing for me. i noticed that it doesn't work on databases for me but samples in folders work perfectly is that normal?
|
Ah, I fixed the crash, but now it makes sense why it was crashing
Apparently there's an issue with databases when "Options: Show file extension even when file type displayed" is disabled. I'll look into a fix.
|
|
|
04-25-2022, 07:12 AM
|
#106
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
I think I fixed it. Version 1.7.2 is online. Let me know if it works
|
|
|
04-25-2022, 08:41 AM
|
#107
|
Human being with feelings
Join Date: Apr 2022
Location: Taiwan
Posts: 27
|
thank you it works now! amazing
|
|
|
04-30-2022, 11:38 AM
|
#108
|
Human being with feelings
Join Date: Dec 2020
Location: Miami, FL USA
Posts: 396
|
Quote:
Originally Posted by FeedTheCat
Yeah, the regex is creepy already
Afaict, most of the file names you posted should already be detected correctly. I quickly pushed an update to also include the full minor/major keywords (it would detect Cmin but not Cminor).
I'm a bit hesitant to support parsing C_minor (underscore between). Not sure if it could mess up the regex. I'd have to look into it more. Don't think it's a common naming convention as well, but I might be wrong. Can you check how many samples you have that use this?
|
It's not really that many that are in the underscore format, if it's difficult it's not worth it
Thank you!
__________________
Seasoned codemonkey
Dunno a thing about making music (here to learn!)
|
|
|
05-21-2022, 01:25 AM
|
#109
|
Human being with feelings
Join Date: Jul 2007
Posts: 711
|
Thanks again for such a great tool. I haven't even bothered with the newly built-in alternative.
This maybe out of mx tuner's scope, but what are the chances of getting it to tune an item already in the arrangement? Would be killer!
|
|
|
05-22-2022, 02:18 AM
|
#110
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by dna598
Thanks again for such a great tool. I haven't even bothered with the newly built-in alternative.
This maybe out of mx tuner's scope, but what are the chances of getting it to tune an item already in the arrangement? Would be killer!
|
That's a cool idea! Not sure if it'd prefer it to be a separate new script or an additional option for MX Tuner... Any thoughts on this?
|
|
|
05-22-2022, 08:39 AM
|
#111
|
Banned
Join Date: Apr 2022
Posts: 635
|
Quote:
Not sure if it'd prefer it to be a separate new script or an additional option for MX Tuner... Any thoughts on this?
|
Hey-an extra option to make selected arrange items follow media explorer key would be smashing (simple option to retune all existing media.)
Is this tuner script following pitch changes dynamically like the new native option?
Great work.Thanks.
|
|
|
05-22-2022, 11:58 AM
|
#112
|
Human being with feelings
Join Date: Jul 2007
Posts: 711
|
Quote:
Originally Posted by FeedTheCat
That's a cool idea! Not sure if it'd prefer it to be a separate new script or an additional option for MX Tuner... Any thoughts on this?
|
I'm not sure it matters to me. If it's the same script, it depends on what's focused I guess (arrangement items/browser items)?
|
|
|
05-23-2022, 03:54 AM
|
#113
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by dna598
I'm not sure it matters to me. If it's the same script, it depends on what's focused I guess (arrangement items/browser items)?
|
ok, will probably be a new script then.
Quote:
Originally Posted by Reapology
Is this tuner script following pitch changes dynamically like the new native option?
|
No, it calculates a single pitch for each file from the first 3 seconds of audio.
|
|
|
05-23-2022, 02:24 PM
|
#114
|
Banned
Join Date: Apr 2022
Posts: 635
|
Quote:
No, it calculates a single pitch for each file from the first 3 seconds of audio.
|
Ok- just checking..this is really nice tool.
Do see some differences between this and native detections..sometimes they sync with some files others not,so am little dubious which algorithms to fully trust just yet?
Love the lock and browse feature..all good so far.
Thanks.
|
|
|
06-10-2022, 01:32 AM
|
#115
|
Human being with feelings
Join Date: May 2017
Posts: 454
|
how do i dock this in the media explorer?like shown in the first post?
|
|
|
06-10-2022, 06:43 AM
|
#116
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by SubbaseDnB
how do i dock this in the media explorer?like shown in the first post?
|
I have the media explorer toolbar and MX Tuner docked beneath the media explorer. (You can't dock something in the MX afaik)
|
|
|
06-10-2022, 08:58 AM
|
#117
|
Human being with feelings
Join Date: May 2017
Posts: 454
|
cant seem to choose where i dock the mx tuner?
|
|
|
06-10-2022, 09:04 AM
|
#118
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,167
|
Quote:
Originally Posted by SubbaseDnB
cant seem to choose where i dock the mx tuner?
|
In MX Tuner:
Right-click menu > Window > Dock window
Then grab the dock tab header (the one that says MX Tuner) and drag it to where you want. Holding Ctrl pressed while dragging gives you more control.
|
|
|
06-21-2022, 01:33 AM
|
#119
|
Human being with feelings
Join Date: Jul 2007
Posts: 711
|
Quote:
Originally Posted by FeedTheCat
ok, will probably be a new script then.
|
Any news on this front?
|
|
|
06-21-2022, 09:21 AM
|
#120
|
Human being with feelings
Join Date: Sep 2020
Location: India
Posts: 283
|
This is a Very very useful Script. I am so happy today. now, I can insert drum samples from Media explorer into ReaSamplOmatic5000 without worrying about the tuning being not set correctly.
Would be nice to have a option to set default locked key for the keyboard that would make a key locked even after restarting the script.
Last edited by Kaxaze music; 06-21-2022 at 09:48 AM.
|
|
|
Thread Tools |
|
Display Modes |
Linear Mode
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -7. The time now is 08:46 AM.
|