Old 02-16-2020, 04:11 PM   #41
schwa
Administrator
 
schwa's Avatar
 
Join Date: Mar 2007
Location: NY
Posts: 10,577
Default

Quote:
Originally Posted by amagalma View Post
Yes. 40511, Item: Trim items left of cursor
Ah thanks. We actually fixed the behavior with 41305: Trim left edge of item to edit cursor. TMTOWTDI 😃
schwa is offline   Reply With Quote
Old 02-17-2020, 04:04 AM   #42
amagalma
Human being with feelings
 
Join Date: Apr 2011
Posts: 1,690
Default

Quote:
Originally Posted by schwa View Post
Ah thanks. We actually fixed the behavior with 41305: Trim left edge of item to edit cursor. TMTOWTDI ��

Yes, "there’s more than one way to skin a cat"! (not an animal loving proverb at all :S:S)


So, it seems that the fix must be applied to each individual action. Should we check all relevant actions then to make sure that there is not any that missed the fix?


And maybe should we open the can of worms, and check reascript functions too?

Code:
AddTakeToMediaItem,
GetSetItemState, 
GetSetMediaItemInfo_String,
GetSetMediaItemTakeInfo_String,
SetItemStateChunk,
SetMediaItemInfo_Value,
SetMediaItemLength,
SetMediaItemPosition,
SetMediaItemTakeInfo_Value,
BR_SetItemEdges,
ULT_SetMediaItemNote

I think I have included all relevant ones...

Last edited by amagalma; 02-17-2020 at 04:12 AM.
amagalma is offline   Reply With Quote
Old 02-17-2020, 04:19 AM   #43
amagalma
Human being with feelings
 
Join Date: Apr 2011
Posts: 1,690
Default

Quote:
Originally Posted by Joe90 View Post
Following on from the melodyne comments - edits are also lost in this scenario -

Apply melodyne as take FX to an item,
Create a region over that item, and make sure the edge of the item overlaps the region edge,
Modifier drag the region to copy it (and thus splitting the melodyned item)
All edits are lost on the original and copied item, no error message from melodyne, the edits just reset.

This one has bitten me a few times before I realised what was happening.

I'm in Win 10, also with 'save minimal undo states' checked for melodyne.

Bug confirmed! ("save minimal undo states" is not checked here. So it happens in both cases)
amagalma is offline   Reply With Quote
Old 02-17-2020, 04:58 AM   #44
schwa
Administrator
 
schwa's Avatar
 
Join Date: Mar 2007
Location: NY
Posts: 10,577
Default

Quote:
Originally Posted by amagalma View Post
]So, it seems that the fix must be applied to each individual action.
No, the fix is general, but it does require making sure that all actions follow the same general behavior, which some older actions don't.
schwa is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 08:32 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.