Go Back   Cockos Incorporated Forums > REAPER Forums > REAPER Feature Requests

Reply
 
Thread Tools Display Modes
Old 02-28-2018, 11:59 AM   #1
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default Lock to Active take should apply to Keyboard Shortucts

I may have missed an old FR but here is a fresh one and is likely my first or second FR in almost 10 years...

Overview

Take > Lock to active take is (or can be) quite valuable as it prevents accidental switching of takes.

Problem

When using the keyboard shortcuts to move between takes, the lock is ignored. This this creates a false sense of security as it only protects against accidental mouse clicks. If using collapsed takes, Lock to Active Take becomes basically a useless feature because the only way to cycle takes is SHIFT+T and T which are not affected by the lock.

Here is a demo of how locking works great for mouse clicks only but when switching to keyboard shortcuts, the locking no longer affects the takes...




Solution


For each item that has Lock to Active Take enabled, ignore any attempts to change the active take until the take is formally unlocked, especially when using T and Shift+T to cycle through takes. I'd imagine a simple check for the lock when the take change is about to be executed would fix this.

Benefit

Ability to realize the full potential of active take locking and added safety when working with takes. I was also working on some ideas to get users wanting "playlist" functionality some relief but this needs to be present to make that work (I'll go into why some other time).

Though the behavior appears as an oversight or by design, it would be most helpful to all users using takes and the safety net where the current active take is always the current active take unless unlocked first.
__________________
Music is what feelings sound like.

Last edited by karbomusic; 02-28-2018 at 12:05 PM.
karbomusic is offline   Reply With Quote
Old 02-28-2018, 03:11 PM   #2
deeb
Human being with feelings
 
deeb's Avatar
 
Join Date: Feb 2017
Posts: 4,812
Default

seems just a bug
deeb is offline   Reply With Quote
Old 02-28-2018, 03:13 PM   #3
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Only if Justin intended for it to apply to the shortcuts, there could be other reasons he didn't that I'm unaware of (though I hope it's an oversight/bug). That's the difference between bug/feature... the coder intention and does the code follow that intention. IOW, a poor coding decision that does what you expect, isn't a bug, it's just poor design, but... the code doing something different than the coder intended is a bug.

Semantic sounding I know but a very important and critical distinction in the programming world.
__________________
Music is what feelings sound like.
karbomusic is offline   Reply With Quote
Old 02-28-2018, 03:41 PM   #4
Dannii
Human being with feelings
 
Dannii's Avatar
 
Join Date: Mar 2010
Location: Adelaide, South Australia (originally from Geelong)
Posts: 5,598
Default

I'll add a +1 to this Karbo. I'm going to give your collapsed method a try next time I'm comping takes.

At the moment, I'm using the expanded take method and use shortcuts to lock active takes and mouse to select them. That won't work once I give your method a try.
__________________
Dannii is offline   Reply With Quote
Old 02-28-2018, 04:33 PM   #5
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Thanks Dave.

With them collapsed the chances are much lower but as much time as I spend hitting shortcuts and "keyboarding" I can inadvertently phat finger the T key or similar, change whatever take happens to be selected out of 60 tracks and be in WTF mode until I figure out what occurred.

Not so big a deal for 8 tracks of a personal jam but when I owe other people explanations for screw ups (which will be delayed in finding in dense mixes and higher track counts/complexity), it starts mattering more. If you end up with any questions about tips/tricks via collapsed, just yell and I'll help.
__________________
Music is what feelings sound like.
karbomusic is offline   Reply With Quote
Old 02-28-2018, 04:40 PM   #6
Dannii
Human being with feelings
 
Dannii's Avatar
 
Join Date: Mar 2010
Location: Adelaide, South Australia (originally from Geelong)
Posts: 5,598
Default

LOL @ "phat finger"!!!
Perhaps "phat phinger" could become a thing.

Will let you know if I have any questions for sure.
__________________
Dannii is offline   Reply With Quote
Old 02-28-2018, 04:44 PM   #7
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Me likes "phat phinger"
__________________
Music is what feelings sound like.
karbomusic is offline   Reply With Quote
Old 02-28-2018, 04:53 PM   #8
Dannii
Human being with feelings
 
Dannii's Avatar
 
Join Date: Mar 2010
Location: Adelaide, South Australia (originally from Geelong)
Posts: 5,598
Default

Quote:
Originally Posted by karbomusic View Post
Me likes "phat phinger"


A little humour regarding your signature....
When I first read it, my subconscious added an extra word which gave it a whole new, bizarre twist. This is what I read....

Quote:
If you are not collapsing during takes, you are causing your own pain.
__________________
Dannii is offline   Reply With Quote
Old 02-28-2018, 05:18 PM   #9
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Quote:
Originally Posted by ReaDave View Post


A little humour regarding your signature....
When I first read it, my subconscious added an extra word which gave it a whole new, bizarre twist. This is what I read....



HA!!!
__________________
Music is what feelings sound like.
karbomusic is offline   Reply With Quote
Old 03-01-2018, 06:29 AM   #10
Gianfini
Human being with feelings
 
Join Date: Jan 2015
Posts: 794
Default

+1

It's more a bug for me.. and yes I remember about other threads about locking things not being really locked afteward...

g
Gianfini is offline   Reply With Quote
Old 03-01-2018, 10:44 AM   #11
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Quote:
Originally Posted by Gianfini View Post
and yes I remember about other threads about locking things not being really locked afteward...

g
Just a clarification for clarity's sake. The one you've heard about the most is when using the lock button in the toolbar which has some similar challenges but this one is separate and explicitly tied to takes and takes only just as an FYI.
__________________
Music is what feelings sound like.
karbomusic is offline   Reply With Quote
Old 03-02-2018, 12:38 AM   #12
Gianfini
Human being with feelings
 
Join Date: Jan 2015
Posts: 794
Default

Quote:
Originally Posted by karbomusic View Post
Just a clarification for clarity's sake. The one you've heard about the most is when using the lock button in the toolbar which has some similar challenges but this one is separate and explicitly tied to takes and takes only just as an FYI.
This

Lock Item

It was actually me

LOL
Gianfini is offline   Reply With Quote
Old 03-02-2018, 06:55 AM   #13
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

^Correct and thanks. That's why I made separate FR for accuracy, both involve locking, but are two different features, one is for items and the other for takes.
__________________
Music is what feelings sound like.

Last edited by karbomusic; 03-02-2018 at 07:10 AM.
karbomusic is offline   Reply With Quote
Old 03-02-2018, 09:02 AM   #14
deeb
Human being with feelings
 
deeb's Avatar
 
Join Date: Feb 2017
Posts: 4,812
Default

I did an example how to switch to next take safely (checks locking).

Safe.NextTake.lua
Code:
--====================================================================
local COMMAND           = 40125 --Take: Switch items to next take
--====================================================================
local proj = 0; --current project
local UNDOSTR ="Safe next take"
local UNSELECT_COMMAND       = 40289 --Item: Unselect all items
--====================================================================
selected_item_count = reaper.CountSelectedMediaItems(proj)

if selected_item_count>0 then 
	--================================================================
	reaper.Undo_BeginBlock()
	reaper.PreventUIRefresh( 1 )
	--================================================================
	local items = {} 
	--================================================================
	for i = 0, selected_item_count - 1 do
	    items[i] = reaper.GetSelectedMediaItem(proj, i)	      
	end
	--================================================================
	reaper.Main_OnCommand(UNSELECT_COMMAND,0)
	--================================================================
	for i = 0, #items do
	   if reaper.GetMediaItemInfo_Value(items[i], "C_LOCK")==0.0 then
	    	reaper.SetMediaItemSelected(items[i], true)
	    	reaper.Main_OnCommand(COMMAND,0)    
	    	reaper.Main_OnCommand(UNSELECT_COMMAND,0)
	   end	
	end
	--================================================================
	for i = 0, #items do
	   reaper.SetMediaItemSelected(items[i], true)
	end
	--================================================================
	reaper.PreventUIRefresh( -1 )
	reaper.TrackList_AdjustWindows( false )
	reaper.UpdateArrange()
	reaper.Undo_EndBlock(UNDOSTR, 0)
end
Safe.PreviousTake.lua
Code:
--====================================================================
local COMMAND           = 40126 --Take: Switch items to previous take
--====================================================================
local proj = 0; --current project
local UNDOSTR ="Safe previous take"
local UNSELECT_COMMAND       = 40289 --Item: Unselect all items
--====================================================================
selected_item_count = reaper.CountSelectedMediaItems(proj)

if selected_item_count>0 then 
	--================================================================
	reaper.Undo_BeginBlock()
	reaper.PreventUIRefresh( 1 )
	--================================================================
	local items = {} 
	--================================================================
	for i = 0, selected_item_count - 1 do
	    items[i] = reaper.GetSelectedMediaItem(proj, i)	      
	end
	--================================================================
	reaper.Main_OnCommand(UNSELECT_COMMAND,0)
	--================================================================
	for i = 0, #items do
	   if reaper.GetMediaItemInfo_Value(items[i], "C_LOCK")==0.0 then
	    	reaper.SetMediaItemSelected(items[i], true)
	    	reaper.Main_OnCommand(COMMAND,0)    
	    	reaper.Main_OnCommand(UNSELECT_COMMAND,0)
	   end	
	end
	--================================================================
	for i = 0, #items do
	   reaper.SetMediaItemSelected(items[i], true)
	end
	--================================================================
	reaper.PreventUIRefresh( -1 )
	reaper.TrackList_AdjustWindows( false )
	reaper.UpdateArrange()
	reaper.Undo_EndBlock(UNDOSTR, 0)
end

Last edited by deeb; 03-02-2018 at 08:29 PM.
deeb is offline   Reply With Quote
Old 03-02-2018, 09:17 AM   #15
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Thanks! But hoping we just add the requested tiny enhancement to the actual feature of lock active take since it exists and users not "in the know" will get the benefit of the native feature.
__________________
Music is what feelings sound like.

Last edited by karbomusic; 03-02-2018 at 09:23 AM.
karbomusic is offline   Reply With Quote
Old 03-02-2018, 08:18 PM   #16
deeb
Human being with feelings
 
deeb's Avatar
 
Join Date: Feb 2017
Posts: 4,812
Default

ofcourse! updated anyway.
deeb is offline   Reply With Quote
Old 04-03-2018, 01:24 PM   #17
karbomusic
Human being with feelings
 
karbomusic's Avatar
 
Join Date: May 2009
Posts: 29,260
Default

Bump.
__________________
Music is what feelings sound like.
karbomusic is offline   Reply With Quote
Old 04-03-2018, 11:24 PM   #18
Fabian
Human being with feelings
 
Fabian's Avatar
 
Join Date: Sep 2008
Location: Sweden
Posts: 7,417
Default

Agreed. Locking is locking. This locked-but-not-locked behavior is not good.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Fabian is offline   Reply With Quote
Old 04-05-2018, 12:24 AM   #19
ivan.lt
Human being with feelings
 
Join Date: Apr 2011
Posts: 499
Default

This makes me nervous, too. +1

deeb, thanks for the scripts!
ivan.lt is offline   Reply With Quote
Old 06-18-2018, 12:42 AM   #20
adcingeo
Human being with feelings
 
Join Date: Jan 2011
Location: Tasmania, Australia
Posts: 37
Default

+1

I fully agree. A lock to active take that doesn't lock for all situations is unfortunate.

It has actually gotten me into trouble during a session when auditioning takes on a vocal track. For what ever reason a different item with a previously locked take selection became selected and was out of my view. I was unknowingly changing the selected take in an area I thought I'd already approved and locked off. Here I was wondering why the item I was looking at wasn't changing its take while I was actually corrupting my previous work - work that I assumed had been locked away safely.

Saving Comps can help somewhat here but it isn't quite the same thing.

I notice that the action description is now (or has always been)
Item properties: Lock to active take (mouse click will not change active take)
which suggests that the
Take: Switch items to next take
and
Take: Switch items to previous take
actions are intentionally exempt from the lock.

Personally, I only use the keyboard shortcuts to audition takes and never clicking with the mouse.

I would like to see the lock apply to the switch items keyboard shortcuts as well as the mouse clicks.

Last edited by adcingeo; 06-18-2018 at 12:53 AM. Reason: Remembered more details.
adcingeo is offline   Reply With Quote
Old 06-19-2018, 01:08 AM   #21
adcingeo
Human being with feelings
 
Join Date: Jan 2011
Location: Tasmania, Australia
Posts: 37
Default

Quote:
Originally Posted by karbomusic View Post

Solution


For each item that has Lock to Active Take enabled, ignore any attempts to change the active take until the take is formally unlocked, especially when using T and Shift+T to cycle through takes. I'd imagine a simple check for the lock when the take change is about to be executed would fix this.
Maybe we could also have an extra Locking option in the list of things to lock across a whole project. "Item active take" to the global locking options.
As per the attached image.
reaper_take_lock_example.png
adcingeo is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 06:49 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.