Old 06-17-2013, 08:24 AM   #1
Celphor
Human being with feelings
 
Join Date: Jan 2013
Location: Austria
Posts: 53
Default CSurf_SetSurfaceSolo on master

Hi,

the API function CSurf_SetSurfaceSolo

REAPERAPI_DECL void (*CSurf_SetSurfaceSolo)(MediaTrack* trackid, bool solo, IReaperControlSurface* ignoresurf);

is always called with parameter solo set to false when solo button is pressed on Reapers master track (doesn't matter if solo was on or off before, or it is a simple solo or SIP).
So the change in solo is not reported properly to the CSurf-Device.
For all other tracks it's ok, only the master is the problem.

Addition: If the master is selected and solo is toggled on another (nonselected) track, SetSurfaceSolo is also called for the master track with the solo state of the track initiating the solo...

Version v4.402 - April 27 2013, x64 Windows

Last edited by Celphor; 06-17-2013 at 09:25 AM.
Celphor is offline   Reply With Quote
Old 05-25-2019, 02:18 PM   #2
brummbear
Human being with feelings
 
brummbear's Avatar
 
Join Date: May 2016
Location: out west
Posts: 86
Default

this issue still here. Tested w Reaper 5.978.

Current solution is to filter it in the plugin code.
brummbear is offline   Reply With Quote
Old 05-25-2019, 06:32 PM   #3
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 12,385
Default

Yeah, this is sort of a feature I guess?

Anyway -- control surface solo notifications for the master track is a "solo-any" notification... if any normal track is soloed, then that solo state is set.

Live with it I guess? Or poll the master solo state via another API if you need it?
Justin is offline   Reply With Quote
Old 05-26-2019, 03:00 PM   #4
brummbear
Human being with feelings
 
brummbear's Avatar
 
Join Date: May 2016
Location: out west
Posts: 86
Default

Yeah, don't change it. Easy to take this feature into consideration in the plugin code. And too risky to break somebody's plugin which has been coded relying on the current behavior.

I imagine that generally the API has developed in that way over the years: rather add some partially redundant calls than modify the existing ones (unless there a glaringly obvious "bugs"). In this way you don't break other people's work which is nice.
brummbear is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 10:46 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.