JUCE VST x64 OSX plugin resizing (FIXED)

[zabukowski]

Hope this is the right forum ...

I am developing OSX x64 VST plugin using JUCE framework. I've found a problem which i am able to replicate with standard JUCE demo plugin.

When plugin is internally resized, its position became misplaced in the Reaper FX window. You can see it on attached LICEcap GIF - after plugin has been loaded, it changes size (height) and the result is ...

My plugin is working ok with Reaper's floating windows and some other hosts on OSX (Nuendo 6.5, NebulaMan ...), which also use floating windows for plugins.

Strangely enough, AU version of my plugin is not suffering from this ?!? Not sure what could be the reason for this, may be bug in JUCE ... I've asked the same question at JUCE's forums - no answer so far.

MacBook, OSX 10.9.4, Reaper 4 & 5 x64

Any ideas or suggestions would be greatly appreciated.

Thx!!

[Justin]

Is this on VST2 or VST3?

Edit: in either case there is some seriously bad parent-window resizing behavior that JUCE is exhibiting. I'm going to look to see if I can work around it without requiring you to modify JUCE...

[zabukowski]

Originally Posted by Justin

Is this on VST2 or VST3?

This is VST2.

I've just checked VST3 and it suffers from the similar issues, plugin is a bit differently displaced, but basically the same problem.

btw. VST2 need two consecutive resizes to expose problem, VST3 need just one resize.
AU works as expected.

Interesting thing is, that only vertical resizing is causing problems - horizontal looks ok.

I've noticed PSP TripleMeter plugin to also have slight displacment after vertical resize.

[zabukowski]

Originally Posted by Justin

Is this on VST2 or VST3?

Edit: in either case there is some seriously bad parent-window resizing behavior that JUCE is exhibiting. I'm going to look to see if I can work around it without requiring you to modify JUCE...

That would be really great, thanks for helping !!!!

[zabukowski]

If you want, I can send you JUCE demo plugin modified to self-resize after 2 seconds, which reveals the issue.

[Justin]

Originally Posted by zabukowski

If you want, I can send you JUCE demo plugin modified to self-resize after 2 seconds, which reveals the issue.

There are a ton of issues, JUCE makes all kinds of bad assumptions about hosts, the most obvious being that an NSView that hosts its configuration is a contentView... Boo.

JUCE needs numerous updates for resize issues, IMO... bleh.

[zabukowski]

Originally Posted by Justin

There are a ton of issues, JUCE makes all kinds of bad assumptions about hosts, the most obvious being that an NSView that hosts its configuration is a contentView... Boo.

JUCE needs numerous updates for resize issues, IMO... bleh.

Is there something particular i should look/check for inside JUCE, which is related to this specific problem ??

Thx!

[Argitoth]

JUCE creator Jules seems very receptive to things in JUCE that are done poorly and need improvement... consider starting a thread at JUCE.com about this.

[zabukowski]

Originally Posted by Argitoth

JUCE creator Jules seems very receptive to things in JUCE that are done poorly and need improvement... consider starting a thread at JUCE.com about this.

Yes, i already did ... waiting for a response ...

Thx!

[Justin]

Originally Posted by zabukowski

Is there something particular i should look/check for inside JUCE, which is related to this specific problem ??

Thx!

The first highly problematic thing is setNativeHostWindowSizeVST():

        if (NSView* hostView = (NSView*) window)
        {

That should check to see if hostView is the contentView, and if not, behave much differently!

Granted, I know that almost every other VST host will pass an NSView that is a contentView, so it's our fault, but we made that decision years ago and are stuck with it... :/

[zabukowski]

Originally Posted by Justin

The first highly problematic thing is setNativeHostWindowSizeVST():

        if (NSView* hostView = (NSView*) window)
        {

That should check to see if hostView is the contentView, and if not, behave much differently!

Granted, I know that almost every other VST host will pass an NSView that is a contentView, so it's our fault, but we made that decision years ago and are stuck with it... :/

Thx, this is very helpful info !!!

[Justin]

There is definitely some handling I can improve in REAPER now, that is causing some of these issues. Maybe it won't require changing JUCE after all... stay tuned.

[zabukowski]

Originally Posted by Justin

There is definitely some handling I can improve in REAPER now, that is causing some of these issues. Maybe it won't require changing JUCE after all... stay tuned.

Awesome, thank you !!!

On the other side, Jules is also willing to look at this, after JUCE summit is finished - i'll keep him informed about your progress ...

[Justin]

I think I have a good fix that will be in the next 5.11 build for VST2 resize behavior. Still investigating the best way to handle VST3.

Edit: this is the patch I would recommend for JUCE's VST3 handling:

http://1014.org/_/juce-vst3-reaper.patch

This improves VST3 resize behavior in REAPER, but it is still not perfect --
I will also fix an issue in REAPER which should round it out nicely.

Edit again: updated that patch to make it not affect Windows (the first revision made things weird on Windows).

[zabukowski]

Originally Posted by Justin

I think I have a good fix that will be in the next 5.11 build for VST2 resize behavior. Still investigating the best way to handle VST3.

Edit: this is the patch I would recommend for JUCE's VST3 handling:

http://1014.org/_/juce-vst3-reaper.patch

This improves VST3 resize behavior in REAPER, but it is still not perfect --
I will also fix an issue in REAPER which should round it out nicely.

Thank you !!!

I've applied your patch here - looking forward for Reaper 5.11 as well

[Justin]

Originally Posted by zabukowski

Thank you !!!

I've applied your patch here - looking forward for Reaper 5.11 as well

If you wouldn't mind, head over to the pre-release forum and give it a go?

[zabukowski]

Originally Posted by Justin

If you wouldn't mind, head over to the pre-release forum and give it a go?

I've tested pre3 resizing behaviour with VST, VST3 and AU.

I am happy to confirm that VST3 and AU are now resizing flawlessly (AU was already working in 5.1).

While resizing behaviour is obviously improved with VST2, there is still one glitch remaining. If plugin is resized, then editor is closed (by switching to another plugin) and then reopened, next resize operation will not work correctly anymore.

If editor is not closed/reopened, consecutive resizes work correctly.

Video is attached.

i have simple plugin here, which decreases plugin height with a click on a button ... it exposes this behaviour ... i'll send it to you, if you need ...

Thank you !!!

[Justin]

Originally Posted by zabukowski

i have simple plugin here, which decreases plugin height with a click on a button ... it exposes this behaviour ... i'll send it to you, if you need ...

Thank you !!!

Got it, fixing for the next build.

[zabukowski]

Originally Posted by Justin

Got it, fixing for the next build.

5.11 pre 4 is working like a charm - big thanks for fixing this, really appreciated.

I'll inform Jules about it and suggest him to apply your patch to JUCE VST3 wrapper.

Cheers!