Control Surface Integration (CSI) Technical Feature Discussion

[Geoff Waddington]

Originally Posted by jacksoonbrowne

Moving an X32 physical fader has gone gone back to fighting with the Reaper feedback because the faders don't support "Touch".
We used to use:

Widget Fader1
    MotorizedFaderWithoutTouch  oscAddress
    FB_X32Processor             oscAddress
WidgetEnd

So I will attempt to duplicate the "MotorizedFaderWithoutTouch" timing in "X32Fader"

Widget Fader1
	X32Fader             oscAddress
	FB_X32FaderProcessor oscAddress
WidgetEnd

Sorry, I forgot about that detail.

I agree the way to do it is add the MotorizedFaderWithoutTouch functionality to X32Fader.

I think we can then remove MotorizedFaderWithoutTouch, don't think it's used by anything else.

[jacksoonbrowne]

Originally Posted by Geoff Waddington

Sorry, I forgot about that detail.

I agree the way to do it is add the MotorizedFaderWithoutTouch functionality to X32Fader.

I think we can then remove MotorizedFaderWithoutTouch, don't think it's used by anything else.

I just modified "X32Fader" and tested it.
Working like a charm.

I'll test it a bit more then post the change

[jacksoonbrowne]

Originally Posted by jacksoonbrowne

I just modified "X32Fader" and tested it.
Working like a charm.

I'll test it a bit more then post the change

Made the change, tested, and working perfectly.

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
class X32_Fader_OSC_MessageGenerator : public CSIMessageGenerator
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
{
public:
    X32_Fader_OSC_MessageGenerator(CSurfIntegrator *const csi, Widget *widget) : CSIMessageGenerator(csi, widget) {}
    ~X32_Fader_OSC_MessageGenerator() {}


    virtual void ProcessMessage(double value) override
    {
        if      (value >= 0.5)    value = value *  40.0 - 30.0;  // max dB value: +10.
        else if (value >= 0.25)   value = value *  80.0 - 50.0;
        else if (value >= 0.0625) value = value * 160.0 - 70.0;
        else if (value >= 0.0)    value = value * 480.0 - 90.0;  // min dB value: -90 or -oo

        widget_->SetIncomingMessageTime(GetTickCount());
        widget_->GetZoneManager()->DoAction(widget_, value);
    }
};

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
class OSC_X32FaderFeedbackProcessor : public OSC_FeedbackProcessor
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
{
public:
    OSC_X32FaderFeedbackProcessor(CSurfIntegrator *const csi, OSC_ControlSurface *surface, Widget *widget, const char *oscAddress) : OSC_FeedbackProcessor(csi, surface, widget, oscAddress) {}
    ~OSC_X32FaderFeedbackProcessor() {}

    virtual const char *GetName() override { return "OSC_X32FaderFeedbackProcessor"; }
    
    virtual void ForceValue(const PropertyList &properties, double value) override
    {
        lastDoubleValue_ = value;

        if      (value < -60.0) value = (value + 90.0) / 480.0;
        else if (value < -30.0) value = (value + 70.0) / 160.0;
        else if (value < -10.0) value = (value + 50.0) /  80.0;
        else if (value <= 10.0) value = (value + 30.0) /  40.0;

        if ((GetTickCount() - GetWidget()->GetLastIncomingMessageTime()) >= 50)
	    surface_->SendOSCMessage(this, oscAddress_.c_str(), value);
    }
};

Now moving on to "X32MoveEditCursor"

[Geoff Waddington]

Originally Posted by jacksoonbrowne

Made the change, tested, and working perfectly.

Now moving on to "X32MoveEditCursor"

Excellent !

[Geoff Waddington]

Ux question.

LearnFX, which launches the new Learn Window, is now mapped to the Inst button on my X-touch, last in the row of all of the other Associated Zones.

However, this one is unique, in that it launches a gui in Reaper.

Should it behave like any other radio buttoned Associated Zone ?

What happens if you are in the midst of mapping, and you press GoHome, Sends, etc. ?

Hate to throw up dialogs, as you know, but maybe, if there are unsaved params, give them a heads up, dunno, what do you think ?

On a related topic, what happens if you focus another FX, not the one you are currently mapping ?

The easy way out is to do nothing, buyer beware, but pretty sure folks don't want to lose their mapping work without warning.

Thoughts/suggestions more than welcomed.

[Freex]

Originally Posted by Geoff Waddington

Ux question.

LearnFX, which launches the new Learn Window, is now mapped to the Inst button on my X-touch, last in the row of all of the other Associated Zones.

However, this one is unique, in that it launches a gui in Reaper.

Should it behave like any other radio buttoned Associated Zone ?

What happens if you are in the midst of mapping, and you press GoHome, Sends, etc. ?

Hate to throw up dialogs, as you know, but maybe, if there are unsaved params, give them a heads up, dunno, what do you think ?

On a related topic, what happens if you focus another FX, not the one you are currently mapping ?

The easy way out is to do nothing, buyer beware, but pretty sure folks don't want to lose their mapping work without warning.

Thoughts/suggestions more than welcomed.

I would think a prompt would be appropriate for both cases.

Generally
IF SOMETHING HAS CHANGED, and
IT'S NOT SAVED

PROMPT PROMPT PROMPT!!!

"You haven't saved this"
"Save" "Exit"

[MST]

Originally Posted by Geoff Waddington

Ux question.

LearnFX, which launches the new Learn Window, is now mapped to the Inst button on my X-touch, last in the row of all of the other Associated Zones.

However, this one is unique, in that it launches a gui in Reaper.

Should it behave like any other radio buttoned Associated Zone ?

Hi,
I would choose it to be a seperate toggle action.

Originally Posted by Geoff Waddington

What happens if you are in the midst of mapping, and you press GoHome, Sends, etc. ?

Hate to throw up dialogs, as you know, but maybe, if there are unsaved params, give them a heads up, dunno, what do you think ?


On a related topic, what happens if you focus another FX, not the one you are currently mapping ?

The easy way out is to do nothing, buyer beware, but pretty sure folks don't want to lose their mapping work without warning.

Thoughts/suggestions more than welcomed.

Something as Freex said is expected.
One could also choose to skip the saving procedure, make it automatic so the last changes always stay, so no more dialogs needed.

[Geoff Waddington]

Originally Posted by MST

Hi,
I would choose it to be a seperate toggle action.

One could also choose to skip the saving procedure, make it automatic so the last changes always stay, so no more dialogs needed.

That does seem to be the more modern way.

So press to open, press to save and close.

In that case it's probably best implemented as a regular Zone, not an Associated Zone.

I like that because "LearnFocusedFX" can be in the same folder as "FXRowLayout" and "FXWidgetLayout".

If you focus a different FX, the current one saves first.

No pesky modal dialogs, I like it !

It also means only 4 buttons on the Learn Window

Delete Map
Erase Control
Edit Alias
Auto Map

[jacksoonbrowne]

Hi Geoff,

I have X23MoveEditCursor added, tested and working

....
else if (tokenLines[i].size() > 1 && tokenLines[i][0] == "X32MoveEditCursor")
    AddCSIMessageGenerator(tokenLines[i][1], new X32_MoveEditCursor_OSC_MessageGenerator(csi_, widget));
....

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
class X32_MoveEditCursor_OSC_MessageGenerator : public CSIMessageGenerator
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
{
public:
    X32_MoveEditCursor_OSC_MessageGenerator(CSurfIntegrator *const csi, Widget *widget) : CSIMessageGenerator(csi, widget) {}
    ~X32_MoveEditCursor_OSC_MessageGenerator() {}

    virtual void ProcessMessage(double value) override
    {
        // DEBOUNCE
        if (value == 64) return;

        // GET WIDGET NAME AND STRING LENGTH
        string widgetName = widget_->GetName();
        int widgetNameLength = widgetName.length();

        // BANK MUST BE ONE OF A,B,C,D
        unsigned char bank = toupper(widgetName[widgetNameLength-2]);
        if (bank < 'A'  ||  bank > 'C') return;
        bank -= 'A';

        // ROTARY MUST BE ONE OF 1,2,3,4
        unsigned char rotary = widgetName[widgetNameLength-1];
        if (rotary < '1'  ||  rotary > '4') return;
        rotary -= '1';

        //DETERMINE ROTARY OSC VALUE
        rotary = 25 + 4*bank + 4*rotary;

        //  CENTER THE ROTARY - MAKE IT APPEAR THAT THE X32 ROTARY IS ENDLESS
        string oscMessage = "/-stat/userpar/" + int_to_string(rotary) + "/value";
        widget_->GetSurface()->SendOSCMessage(oscMessage.c_str(), 64);


        // REAPER:  MOVE CURSOR RIGHT TO NEXT MEASURE
        if (value >  64) DAW::SendCommandMessage(41042);

        // REAPER:  MOVE CURSOR LEFT  TO NEXT MEASURE
        else DAW::SendCommandMessage(41043);
    }
};

[Geoff Waddington]

Originally Posted by jacksoonbrowne

Hi Geoff,

I have X23MoveEditCursor added, tested and working

Pushed a commit for you to try

In the .ost:

Widget SomeWidget
    X32RotaryToEncoder oscAddress
    FB_ X32RotaryToEncoder oscAddress
WidgetEnd

In the Zone:

SomeWidget MoveEditCursor  Bar

[jacksoonbrowne]

Originally Posted by Geoff Waddington

Pushed a commit for you to try

In the .ost:

Widget SomeWidget
    X32RotaryToEncoder oscAddress
    FB_ X32RotaryToEncoder oscAddress
WidgetEnd

In the Zone:

SomeWidget MoveEditCursor  Bar

Close but no cigar

OSC_X32_RotaryToEncoderFeedbackProcessor() only gets invoked during startup of Reaper.
Never invoked when moving the rotary.

.ost

Widget UserAssignableRotaryC1
    X32RotaryToEncoder         /-stat/userpar/33/value
    FB_X32RotaryToEncoder      /-stat/userpar/33/value
WidgetEnd

.zon

UserAssignableRotaryC1   MoveEditCursor   Bar   // Move edit cursor +- 1 Bar

[Geoff Waddington]

Originally Posted by jacksoonbrowne

Close but no cigar

OSC_X32_RotaryToEncoderFeedbackProcessor() only gets invoked during startup of Reaper.
Never invoked when moving the rotary.

.ost

Widget UserAssignableRotaryC1
    X32RotaryToEncoder         /-stat/userpar/33/value
    FB_X32RotaryToEncoder      /-stat/userpar/33/value
WidgetEnd

.zon

UserAssignableRotaryC1   MoveEditCursor   Bar   // Move edit cursor +- 1 Bar

Oops, just pushed a commit that might fix things.

[jacksoonbrowne]

Originally Posted by Geoff Waddington

Oops, just pushed a commit that might fix things.

I think I just fixed it.
Will compare my fix to yours

[jacksoonbrowne]

Tested and working

actions_.Insert("MoveCursor", new MoveCursor());

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
class MoveCursor : public Action
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
{
public:
    virtual const char *GetName() override { return "MoveCursor"; }

    virtual double GetCurrentNormalizedValue(ActionContext *context) override
    {
        return  0.5;
    }
    
    virtual void RequestUpdate(ActionContext *context) override
    {
        context->UpdateWidgetValue(1.0);
    }
    
    virtual void Do(ActionContext *context, double value) override
    {
        const char *amount = context->GetStringParam();
        
        if (value > 0.5)
        {
            if ( ! strcmp(amount, "Bar"))
                DAW::SendCommandMessage(41042); // move to next bar

            else if ( ! strcmp(amount, "Marker"))
                DAW::SendCommandMessage(40173); // move to next marker/region
        }

        else if (value < 0.5)
        {
            if ( ! strcmp(amount, "Bar"))
                DAW::SendCommandMessage(41043); // move to previous bar

            else if ( ! strcmp(amount, "Marker"))
                DAW::SendCommandMessage(40172); // move to previous marker/region
        }
    }
};

.ost

Widget UserAssignableRotaryC1
    X32RotaryToEncoder             /-stat/userpar/33/value
    FB_X32RotaryToEncoder      /-stat/userpar/33/value
WidgetEnd

Widget UserAssignableRotaryC2
    X32RotaryToEncoder             /-stat/userpar/34/value
    FB_X32RotaryToEncoder      /-stat/userpar/34/value
WidgetEnd

.Zon

    UserAssignableRotaryC1     MoveCursor   Bar     // Move cursor to previous or next Bar
    UserAssignableRotaryC2     MoveCursor   Marker  // Move cursor to previous or next Marker/RegionBar

[Geoff Waddington]

Originally Posted by jacksoonbrowne

Tested and working

Cool, committed.

Left the name "MoveEditCursor", since that more accurately reflects what it does, even though the class is named MoveCursor to avoid conflicts.

If you look at that dictionary, there are many examples of the names not exactly matching, for many different reasons

[Geoff Waddington]

Tweaked the code, so you shouldn't need all of those OnInitializations.

virtual void SetValue(const PropertyList &properties, double value) override
{
    if (widget_->GetLastIncomingDelta() != 0.0)
    {
        widget_->SetLastIncomingDelta(0.0);
        ForceValue(properties, value);
    }
}
    
virtual void ForceValue(const PropertyList &properties, double value) override
{
    surface_->SendOSCMessage(this, oscAddress_.c_str(), 64);
}

[Geoff Waddington]

Another great vid from UNdark:

https://www.youtube.com/watch?v=POOhASWN1Zo

[fourdogslong]

How's the windows version coming along? Just curious, no rush.

[Geoff Waddington]

Originally Posted by fourdogslong

How's the windows version coming along? Just curious, no rush.

Turning out to be a total redesign, so the Mac version is also non functional at the moment.

Will be at least a week or two, likely more.

[Geoff Waddington]

Ok, need a thumbs up on the final save Learn design.

If you close the Learn Window, it automatically saves.

If you focus another FX, it automatically saves the current one, and loads the newly focused one.

No modal dialogs to be seen.

If you don't like what you saved, you can edit it by opening the Learn Window.

If you want to start again, just delete the Zone/Map, and start again.

Everyone agree ?

[Funkybot]

That sounds great to me! Would be very efficient when it comes to quick mapping a few plugins.

[Freex]

so am I right in thinking the work flow will be (or could be)

Open Learn Mode

Focus FX

twiddle some knobs (on screen and on controller)

Close learn mode

Mapping is now saved.

__________________
Open Learn mode

Focus an FX

Change some stuff twiddle a few more knobs

Close learn mode

Mapping is now saved.
___________________
Open Learn mode

Focus FX

Decide that your approach was all wrong and you need to start again

Delete FX Map

?????????

Now at this point does learn mode close or reset?


Also is open and close learn mode a toggle function?

Will it be possible to have the extra buttons you meantioned only accessable from within learn mode, Alias Delete, like it's own zone?

[Geoff Waddington]

Originally Posted by Freex

so am I right in thinking the work flow will be (or could be)

Open Learn Mode

Focus FX

twiddle some knobs (on screen and on controller)

Close learn mode

Mapping is now saved.

__________________
Open Learn mode

Focus an FX

Change some stuff twiddle a few more knobs

Close learn mode

Mapping is now saved.
___________________
Open Learn mode

Focus FX

Decide that your approach was all wrong and you need to start again

Delete FX Map

?????????

Now at this point does learn mode close or reset?


Also is open and close learn mode a toggle function?

Will it be possible to have the extra buttons you meantioned only accessable from within learn mode, Alias Delete, like it's own zone?

Close, but it is slightly different, at least as presently envisioned.

You can't open the LearnWindow without a focused FX.

There is one Action only -- LearnFocusedFX -- which must be assigned to a button.

It is a toggle, hitting it while it is open closes and saves.

Alternatively, you can close the Learn Window by clicking the mouse on the X (close icon at top) of the Learn Window, which also closes and saves.

All of the other Actions are removed -- Save, Erase Last Touched, Delete, etc., you can't assign them to surface buttons.

They are ONLY available via gui buttons on the Learn Window.

Whenever the Learn Window is open, you are automatically in Learn mode for the focused FX.

If you delete an FX map, the LearnWindow stays open, and you remain in Learn mode for the focused FX.

If you focus another FX, you automatically enter Learn mode for that FX.

If there was a currently "learned" FX in the Learn Window, it automatically saves, before entering Learn mode for the newly focused FX.

[Freex]

Originally Posted by Geoff Waddington

Close, but it is slightly different, at least as presently envisioned.

You can't open the LearnWindow without a focused FX.

There is one Action only -- LearnFocusedFX -- which must be assigned to a button.

It is a toggle, hitting it while it is open closes and saves.

Alternatively, you can close the Learn Window by clicking the mouse on the X (close icon at top) of the Learn Window, which also closes and saves.

All of the other Actions are removed -- Save, Erase Last Touched, Delete, etc., you can't assign them to surface buttons.

They are ONLY available via gui buttons on the Learn Window.

Whenever the Learn Window is open, you are automatically in Learn mode for the focused FX.

If you delete an FX map, the LearnWindow stays open, and you remain in Learn mode for the focused FX.

If you focus another FX, you automatically enter Learn mode for that FX.

If there was a currently "learned" FX in the Learn Window, it automatically saves, before entering Learn mode for the newly focused FX.

Sounds Awesome, thanks for clearing that up.

now when will a windows version be ready LOL

[Geoff Waddington]

Originally Posted by Freex

Sounds Awesome, thanks for clearing that up.

now when will a windows version be ready LOL

I'm not even close to a Mac version yet

[MST]

Originally Posted by Geoff Waddington

Ok, need a thumbs up on the final save Learn design.

[fourdogslong]

Originally Posted by Geoff Waddington

Turning out to be a total redesign, so the Mac version is also non functional at the moment.

Will be at least a week or two, likely more.

Thanks for the update, no worries

[MixMonkey]

Originally Posted by Geoff Waddington

Ok, need a thumbs up on the final save Learn design.

If you close the Learn Window, it automatically saves.

If you focus another FX, it automatically saves the current one, and loads the newly focused one.

No modal dialogs to be seen.

If you don't like what you saved, you can edit it by opening the Learn Window.

If you want to start again, just delete the Zone/Map, and start again.

Everyone agree ?

This sounds good Am I right in understanding that no map creation happens automatically unless the Learn window is opened?

[Geoff Waddington]

Originally Posted by MixMonkey

This sounds good Am I right in understanding that no map creation happens automatically unless the Learn window is opened?

That is correct sir

[MixMonkey]

Originally Posted by Geoff Waddington

That is correct sir

Excellent! This is sounding tidy

[Geoff Waddington]

Originally Posted by MixMonkey

Excellent! This is sounding tidy

You are primarily on a Mac, right ?

Think I'll post the barebones sketch I have so far, just to get final approval on the workflow.

[MixMonkey]

Originally Posted by Geoff Waddington

You are primarily on a Mac, right ?

Yup

Think I'll post the barebones sketch I have so far, just to get final approval on the workflow.

Cool

[Geoff Waddington]

MAC ONLY MAC ONLY

New Exp build is up.

https://stash.reaper.fm/v/42044/CSI%20Exp.zip

For demo purposes only, generally non functional.

Demonstration of the new Learn Window.

It is non modal and can be resized.

There is only one Action, which is a Toggle.

SomeButton LearnFocusedFX

You must first focus an FX.

Then, press the button to open/close the Learn Window.

You can also close it via the red close icon at the top left.

Try changing the focused FX, whilst the Learn Window is open, to see the workflow.

For now the only thing you will see is the Learn Window title changing.

Thoughts/suggestions more than welcomed, as always.

[edit]
You will also need Zones that look like this:

Zone FXRowLayout
	Channels 8
	"" ""
	"Shift" ""
	"Control" ""
	"Option" ""
ZoneEnd

Zone FXWidgetLayout
	Rotary FXParam RingStyle=Dot
	DisplayUpper FixedTextDisplay
	DisplayLower FXParamValueDisplay
ZoneEnd

#WidgetTypes Rotary RotaryPush Fader
#DisplayRows DisplayUpper DisplayLower
#RingStyles Dot Fill BoostCut Spread

[MixMonkey]

Originally Posted by Geoff Waddington

MAC ONLY MAC ONLY

New Exp build is up.

https://stash.reaper.fm/v/42044/CSI%20Exp.zip

For demo purposes only, generally non functional.

Do the other syntax changes need to be implemented for this to work?

[Geoff Waddington]

Originally Posted by MixMonkey

Do the other syntax changes need to be implemented for this to work?

Don't think so, are you having trouble ?

[MixMonkey]

Originally Posted by Geoff Waddington

You will also need Zones that look like this:

Zone FXRowLayout
	Channels 8
	"" ""
	"Shift" ""
	"Control" ""
	"Option" ""
ZoneEnd

Zone FXWidgetLayout
	Rotary FXParam RingStyle=Dot
	DisplayUpper FixedTextDisplay
	DisplayLower FXParamValueDisplay
ZoneEnd

#WidgetTypes Rotary RotaryPush Fader
#DisplayRows DisplayUpper DisplayLower
#RingStyles Dot Fill BoostCut Spread

So that's a "yes", then

[Geoff Waddington]

Originally Posted by MixMonkey

So that's a "yes", then

Not even sure you need those for the demo, but you will for production

Might as well rename the files as well to reflect the changes.

One last thing for production, pretty sure you don't need it for the demo, LearnFocusedFX is no longer an Associated Zone, it can just go in the main folder with the other 2, along with FXPrologue and FXEpilogue.

[edit] Might even want to put all of those in a subfolder - "LearnFX" ?

[Funkybot]

For us [primarily] Windows folks, any hope of posting a preview screenshot?

[MixMonkey]

Originally Posted by Geoff Waddington

Demonstration of the new Learn Window.

It is non modal and can be resized.

There is only one Action, which is a Toggle.

SomeButton LearnFocusedFX

You must first focus an FX.

Then, press the button to open/close the Learn Window.

You can also close it via the red close icon at the top left.

Try changing the focused FX, whilst the Learn Window is open, to see the workflow.

For now the only thing you will see is the Learn Window title changing.

Thoughts/suggestions more than welcomed, as always.

Works very nicely here Title bar changes when different FX are focused (the window itself is blank, but that's correct yes?). It would be good if the window could remember its size. It's going to be a pain dragging it out to see the last two channels everytime...

[MixMonkey]

Originally Posted by Funkybot

For us [primarily] Windows folks, any hope of posting a preview screenshot?

This is after I dragged it out to show channels 7 and 8.