|
|
|
01-10-2015, 02:27 PM
|
#1
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
'implode items across tracks into takes' bug
https://i.imgur.com/53C32lT.gif
The item in the lower track gets only imploded until the first split occurs, after that's it's truncated.
R4.76 x32, Win 8.1 upd1 x64
Anyone can confirm ?
If not, I could also upload a small test project.
(I think the factor is trying to implode an item in another one where already splitted takes occur and these splits happen before the full length of the imploded item, as said above).
===
Tracker:
http://forum.cockos.com/project.php?issueid=5488
Last edited by nofish; 01-23-2015 at 09:15 AM.
|
|
|
01-13-2015, 11:54 AM
|
#2
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
bump
Any comments ?
Should I expect the item only being imploded until the first split or bug ?
|
|
|
01-22-2015, 08:55 AM
|
#3
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
Anyone please ?
I'm giving another example.
Initial situation:
Situations like this happen frequently here, e.g. with online collaborations I'm doing. I have two takes of something already edited and comped (splitted), than the artist decides to send me another take I'd like to implode.
Current result after after imploding:
Desired would be something like this I think (manually done):
Item gets enlarged until the beginning of the new imploded take, full length and inherits the splits of the original item.
Makes sense ?
|
|
|
01-22-2015, 09:25 AM
|
#4
|
Human being with feelings
Join Date: Jan 2010
Location: Kalispell
Posts: 14,759
|
Quote:
Item gets enlarged until the beginning of the new imploded take, full length and inherits the splits of the original item.
Makes sense ?
|
Hi nofish, I never implode tracks like that but yeah, I'd say your bottom picture displays a more correct result.
|
|
|
01-22-2015, 09:37 AM
|
#5
|
Human being with feelings
Join Date: Jun 2012
Location: Spain
Posts: 7,268
|
imploding to takes has several bugs. this is certainly one of them. I don't see any easy solution for this.
|
|
|
01-22-2015, 09:39 AM
|
#6
|
Human being with feelings
Join Date: Sep 2010
Posts: 12,631
|
Isn't that the desired effect of that feature (ie. the take recording mode that makes multiple audio streams in the same item instead of separate items)? The original edits are preserved.
Not sure. I never use this (and was baffled as to what kind of workflow this feature was aimed at exactly). I use the 'new recorded items make their own lane' option for overdubs and comping. New takes are their own item as expected and are not linked together in any weird ways for editing when you don't want them to be. You can always record new takes no matter how elaborate of a comp you already have going on and add to it.
I think the idea behind the multiple takes in a single item thing is more a live performance thing where someone would want to switch between alternate versions but always keep the same edit/loop points and trigger it with MIDI controls.
|
|
|
01-23-2015, 09:11 AM
|
#7
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
Thanks.
Put into tracker:
http://forum.cockos.com/project.php?issueid=5488
serr, topic is not about Reaper's recording modes but current behaviour when imploding items into takes.
btw (a bit unrelated but anyway), I also used the 'new recorded items make their own lane' very long until I finally made friends with the 'create new takes' mode. Advantage using this mode when comping is you don't have to mute items manually, just split and select takes. Much faster imo, might be worth revisiting this (only works good when all takes have the same length though, not e.g. classical music).
I also suggest having a look of this nice overview from Coachz about recording modes, takes etc.
http://forum.cockos.com/showpost.php...1&postcount=36
|
|
|
01-23-2015, 09:21 PM
|
#8
|
Human being with feelings
Join Date: Jan 2014
Posts: 5,220
|
I don't consider this a bug. If I had audio before the take items it would get overrun with that.
If you're imploding onto a track it usually implies the recordings are similar. If they are not similar due to areas of silence you trim them intuitively. With your proposed changes I'd still have to trim them anyway. This would just get in my way.
|
|
|
01-23-2015, 09:26 PM
|
#9
|
Human being with feelings
Join Date: Jan 2014
Posts: 5,220
|
My compromise:
Before:
After:
|
|
|
01-24-2015, 12:22 AM
|
#10
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
Fergler, thanks for bringing this up.
Actually I thought about it too (but didn't bother to mention).
I see your point (I think), when the item is trimmed already it's reasonable to assume the trimming should stay intact when imploding (and also assuming takes are similar, I admit my example wasn't 'real life')
Agreed, or better said this part isn't that important for me how it's handled (I can trim the beginning manually after imploding if desired), important part for me is that ALL splits get carried across the imploded item which currently isn't the case (it's truncated after first split).
Could you go along with this ?
Last edited by nofish; 01-24-2015 at 12:33 AM.
|
|
|
01-24-2015, 01:46 AM
|
#11
|
Human being with feelings
Join Date: Aug 2012
Location: Finland
Posts: 2,668
|
Nofish, try this EEL thing:
This is how it differs from the native action "Take:Implode items across tracks into takes":
(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)
Download from the stash:
https://stash.reaper.fm/23003/Split%2...o%20takes2.eel
|
|
|
01-24-2015, 01:57 AM
|
#12
|
Human being with feelings
Join Date: Jun 2012
Location: Spain
Posts: 7,268
|
rescued again by the already legendary spk77!!!
|
|
|
01-24-2015, 02:02 AM
|
#13
|
Human being with feelings
Join Date: Aug 2012
Location: Finland
Posts: 2,668
|
Quote:
Originally Posted by heda
rescued again by the already legendary spk77!!!
|
Thanks, I hope it works
(I haven't tested it very much)
|
|
|
01-24-2015, 08:23 AM
|
#14
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
Quote:
Originally Posted by spk77
Nofish, try this EEL thing:
This is how it differs from the native action "Take:Implode items across tracks into takes":
(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)
Download from the stash:
https://stash.reaper.fm/23003/Split%2...o%20takes2.eel
|
Wow, blown away !
Looks like this is exactly what I'm loking for.
Will test and report back.
Thanks so much spk77 !
|
|
|
01-24-2015, 10:53 AM
|
#15
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
spk77, since I can't send you PM's currently (inbox full) I hope you see this:
I think you can disregard the test project I just sent you.
Seems to work totally fine now, maybe it was a temporal glitch or something before.
Thanks again, much appreciated.
|
|
|
01-24-2015, 11:45 AM
|
#16
|
Human being with feelings
Join Date: Jan 2014
Posts: 5,220
|
What about this case?
Ok to add a new split into the takes?
|
|
|
01-24-2015, 12:18 PM
|
#17
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
Quote:
Originally Posted by Fergler
What about this case?
Ok to add a new split into the takes?
|
I don't have this case.
Usually I have single full length items I need to be imploded.
So I'm indefferent, meaning fine with me.
|
|
|
01-24-2015, 12:54 PM
|
#18
|
Human being with feelings
Join Date: Aug 2012
Location: Finland
Posts: 2,668
|
Quote:
Originally Posted by nofish
spk77, since I can't send you PM's currently (inbox full) I hope you see this:
I think you can disregard the test project I just sent you.
Seems to work totally fine now, maybe it was a temporal glitch or something before.
Thanks again, much appreciated.
|
Tested your project - I noticed that the script is quite slow when there are a lot of items in a project. Well, I hope it will work. (this is quite a hack )
|
|
|
09-24-2015, 07:33 AM
|
#19
|
Human being with feelings
Join Date: Jun 2015
Posts: 68
|
Sadly the script doesn't seem to work for me. Could anyone confirm it working for them?
Is there any way to do it still? I really like the idea pf exploding all takes, cleaning them up and then imploding again but there doesn't seem to be any way to do it atm.
|
|
|
09-24-2015, 08:53 AM
|
#20
|
Human being with feelings
Join Date: Aug 2012
Location: Finland
Posts: 2,668
|
goldec,
Do you have the SWS extension installed? ("SWS: delete empty MIDI takes/items" is used to delete all empty items that the script creates.)
It seems to work for me (win 8.1 64bit, REAPER v5.03pre1):
(I tested with this version)
Code:
// Split and implode items across tracks into takes, keeping item positions.
buf = 10000;
function split_and_implode_across_tracks()
(
i = 0;
sel_item_count = CountSelectedMediaItems(0);
sel_item_count ? (
max_split_pos = 0;
last_item_number = 0;
dest_track_sel_item_cnt = 0;
cursor_pos = GetCursorPosition();
Undo_BeginBlock();
PreventUIRefresh(1);
//Main_OnCommand(40299, 0); // move items to source preferred position
loop(sel_item_count,
(sel_item = GetSelectedMediaItem(0, i)) ? (
buf[i * 2] = GetMediaItemInfo_Value(sel_item, "D_POSITION");
buf[i * 2 + 1] = buf[i * 2] + GetMediaItemInfo_Value(sel_item, "D_LENGTH");
buf[i * 2 + 1] > max_split_pos ? max_split_pos = buf[i * 2 + 1]; // selection end pos
i == 0 ? (
first_track = GetMediaItemTrack(sel_item);
min_split_pos = buf[i * 2];
);
buf[i * 2] < min_split_pos ? min_split_pos = buf[i * 2]; // selection start pos
);
dest_track_sel_item_cnt == 0 && GetMediaItem_Track(sel_item) != first_track ? dest_track_sel_item_cnt = i;
i += 1;
);
// Add temporary track
InsertTrackAtIndex(0, 1);
temp_track_id = GetTrack(0, 0);
i = 0;
loop(dest_track_sel_item_cnt + 1,
// empty items will be added to the temp track
new_item = AddMediaItemToTrack(temp_track_id);
// add empty item if first selected item's start pos > item selection start pos
i == 0 && min_split_pos < buf[0] ? (
SetMediaItemInfo_Value(new_item, "D_POSITION", min_split_pos);
SetMediaItemInfo_Value(new_item, "D_LENGTH", buf[0] - min_split_pos);
);
// fill all gaps with empty items
i > 0 && (i < dest_track_sel_item_cnt) && (buf[i * 2 - 1] < buf[i * 2]) ? (
SetMediaItemInfo_Value(new_item, "D_POSITION", buf[i * 2 - 1]);
SetMediaItemInfo_Value(new_item, "D_LENGTH", buf[i * 2] - buf[i * 2 - 1]);
);
// add empty item if last selected item's end pos < item selection end pos
i == dest_track_sel_item_cnt && buf[i * 2] < max_split_pos ? (
SetMediaItemInfo_Value(new_item, "D_POSITION", buf[i * 2 - 1]);
SetMediaItemInfo_Value(new_item, "D_LENGTH", max_split_pos - buf[i * 2 - 1]);
);
SetMediaItemSelected(new_item, 1);
i += 1;
);
// split all items at start/end pos of items
i = 0;
loop(sel_item_count * 2,
SetEditCurPos(buf[i], 0, 0);
Main_OnCommand(40757, 0); // split and keep selection
i += 1;
);
Main_OnCommand(40438, 0); //implode items across tracks into takes
SetEditCurPos(cursor_pos, 0, 0);
i = 0;
loop(CountSelectedMediaItems(0),
(sel_item = GetSelectedMediaItem(0, i)) ? (
MoveMediaItemToTrack(sel_item, first_track) ? i -= 1;
i += 1;
);
);
Main_OnCommand(NamedCommandLookup("_S&M_DELEMPTYTAKE2"), 0); // SWS: delete empty MIDI takes/items
//Main_OnCommand(NamedCommandLookup("_S&M_DELEMPTYTAKE"), 0); // SWS: delete empty takes/items
DeleteTrack(temp_track_id);
PreventUIRefresh(-1);
Undo_EndBlock("Implode items across tracks into takes", -1);
);
);
split_and_implode_across_tracks();
|
|
|
03-24-2018, 08:12 AM
|
#21
|
Human being with feelings
Join Date: May 2010
Location: Norway
Posts: 7,318
|
Quote:
Originally Posted by spk77
Nofish, try this EEL thing:
This is how it differs from the native action "Take:Implode items across tracks into takes":
(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)
Download from the stash:
https://stash.reaper.fm/23003/Split%...o%20takes2.eel
|
Thanks a lot for this one!
Really what I was looking for
__________________
Reaper x64, win 11
Composer, text-writer, producer
Bandcamp
|
|
|
03-24-2018, 09:42 AM
|
#22
|
Human being with feelings
Join Date: Aug 2012
Location: Finland
Posts: 2,668
|
Thanks G-Sun! It's an old script - I hope it still works
|
|
|
03-24-2018, 09:53 AM
|
#23
|
Human being with feelings
Join Date: Sep 2008
Location: Sweden
Posts: 7,432
|
Over the years, I have posted several issues with the "Implode items across tracks:
https://forum.cockos.com/showthread.php?t=91936
https://forum.cockos.com/showthread.php?t=118417
Probably a few more I cannot find just now, before I gave up...
It works in a very counter-intuitive way, I would say.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Last edited by Fabian; 03-24-2018 at 11:37 AM.
|
|
|
03-24-2018, 11:32 AM
|
#24
|
Human being with feelings
Join Date: May 2010
Location: Norway
Posts: 7,318
|
Quote:
Originally Posted by Fabian
|
spk77's script worked out of the box for me for merging takes on two tracks
__________________
Reaper x64, win 11
Composer, text-writer, producer
Bandcamp
|
|
|
03-24-2018, 11:38 AM
|
#25
|
Human being with feelings
Join Date: Sep 2008
Location: Sweden
Posts: 7,432
|
Quote:
Originally Posted by G-Sun
spk77's script worked out of the box for me for merging takes on two tracks
|
I'll check it out. Thanks for the tip.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
|
|
|
11-25-2019, 01:16 PM
|
#26
|
Human being with feelings
Join Date: Sep 2008
Location: Sweden
Posts: 7,432
|
And I'm back again with the same issue. Can we hope to get this fixed for v6?
I expected to get 8 items with three takes each. That's not what happens, and I cannot for the life of me figure out the logic.
spk77's script... I'll try that.
EDIT: Nope, spk77's script generated the exact same thing.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Last edited by Fabian; 11-25-2019 at 01:23 PM.
|
|
|
11-25-2019, 01:31 PM
|
#27
|
Human being with feelings
Join Date: Sep 2008
Location: Sweden
Posts: 7,432
|
Actually, spk77's script was even stranger. If I select the three first items across the three tracks, this happens with spk77's script:
All of them disappear!
Here, Reaper does the expected thing:
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
|
|
|
11-25-2019, 01:37 PM
|
#28
|
Administrator
Join Date: Mar 2007
Location: NY
Posts: 15,819
|
This is happening because the items overlap slightly. We'll look at improving this behavior.
|
|
|
11-25-2019, 02:11 PM
|
#29
|
Human being with feelings
Join Date: Sep 2008
Location: Sweden
Posts: 7,432
|
Quote:
Originally Posted by schwa
This is happening because the items overlap slightly. We'll look at improving this behavior.
|
Aha!
Great.
Thanks.
Looking forward to it.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
|
|
|
03-19-2020, 10:06 AM
|
#30
|
Human being with feelings
Join Date: Jul 2009
Posts: 3,714
|
v6.05 includes this update:
Quote:
[*]+ Takes: implode items into tracks only if at least half of the item overlaps [p=2207040]
|
Could someone give a bit more information about this update? Perhaps an example of an implosion that previously failed but now works?
As I commented a few months ago for v6.0+dev1204, the implosions that I tried all still failed.
|
|
|
10-10-2020, 12:22 PM
|
#31
|
Human being with feelings
Join Date: Mar 2007
Location: Mediterrenean Sea
Posts: 979
|
Quote:
Originally Posted by spk77
Nofish, try this EEL thing:
This is how it differs from the native action "Take:Implode items across tracks into takes":
(The script is actually using the action Take:Implode items across tracks into takes, but it's also doing some "smart" splitting, filling gaps with empty items etc.)
Download from the stash:
https://stash.reaper.fm/23003/Split%...o%20takes2.eel
|
that SAVED MY DAY..... thank you
|
|
|
10-10-2020, 02:19 PM
|
#32
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
^^ That's how it should be natively imo.
|
|
|
10-10-2020, 11:33 PM
|
#33
|
Human being with feelings
Join Date: Mar 2007
Location: Mediterrenean Sea
Posts: 979
|
Quote:
Originally Posted by nofish
^^ That's how it should be natively imo.
|
I,d swear this was the native behaviour some versions ago.
|
|
|
10-19-2020, 03:29 AM
|
#34
|
Human being with feelings
Join Date: Apr 2011
Posts: 3,458
|
I think my script amagalma_Implode items across tracks into takes (found in ReaPack) should fix the behavior. In the test project I attach, the native action doesn't do anything, and spk77's script deletes the items.
Test Project
|
|
|
10-26-2020, 06:14 PM
|
#35
|
Human being with feelings
Join Date: Jan 2013
Posts: 1,128
|
hey amagalma,
I tried your script but nothing happens.
I select the items
Fire your script
the times gets unselected but nothing happens...
What am I doing wrong???
|
|
|
01-24-2023, 07:59 AM
|
#36
|
Human being with feelings
Join Date: Apr 2013
Location: France
Posts: 9,900
|
Bump,
Seems I got a related issue today (nofish leads me here)
Items are perfectly at same pos as snap is active, yet only some items are imploded.
|
|
|
01-24-2023, 10:46 AM
|
#37
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
^ May try the alternative solutions posted here ( #20, #34) in the meantime (in case you missed them) until it's fixed natively.
|
|
|
01-24-2023, 01:59 PM
|
#38
|
Human being with feelings
Join Date: Jan 2013
Posts: 1,128
|
Yeah, I’ve been using Amagalma’s script for a while now.
Gets the job done great.
|
|
|
01-25-2023, 04:23 PM
|
#39
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,109
|
Fix in pre-release of today (no tested yet), thanks devs!
|
|
|
Thread Tools |
|
Display Modes |
Linear Mode
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -7. The time now is 12:01 PM.
|