Old 05-25-2018, 03:41 PM   #2441
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 11,135
Default

Quote:
Originally Posted by nofish View Post
Here on Win I can reliably reproduce (instant freeze when pasting FX chain) on one portable install (R5.80, SWS 2.9.8) and can reliably not reproduce on another similar portable install. Seems there are some additional factors into play, not sure currently what to make of it.

At any rate, confirmed that something's not quite right here, would be good if you could put it in the SWS tracker so it doesn't get buried here.

https://github.com/reaper-oss/sws/issues

Thanks.
This will be fixed in 5.91pre2 (it was some locking on our end that was the problem).
Justin is offline   Reply With Quote
Old 06-01-2018, 02:30 AM   #2442
Sju
Human being with feelings
 
Join Date: Jun 2015
Posts: 567
Default

EDIT: nevermind, this was some kind of hotkey issue on my end

Last edited by Sju; 06-01-2018 at 02:43 AM.
Sju is offline   Reply With Quote
Old 06-04-2018, 04:10 AM   #2443
juliansader
Human being with feelings
 
Join Date: Jul 2009
Posts: 1,853
Default

Is this the appropriate thread for SWS feature requests?

ReaScripts do not currently have access to all the nifty C++ functions for getting information about windows.

It would be very helpful if SWS could expose these three functions to the API:
* WindowFromPoint
* GetClientRect
* ClientToScreen

This would help me to
* precisely position script GUIs within the MIDI editor and other windows, and
* obtain more detailed info about the mouse cursor context than BR_GetMouseCursorContext currently provides.


EDIT: These functions are provided by Cockos's WDL SWELL cross-platform implementation of the win32 API.

Last edited by juliansader; 06-09-2018 at 04:40 PM.
juliansader is online now   Reply With Quote
Old 06-04-2018, 04:16 AM   #2444
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 4,846
Default

Quote:
Is this the appropriate thread for SWS feature requests?
Better use GitHub tracker, it allows to have a disucssion per issue, track the state of the feature request etc...
X-Raym is offline   Reply With Quote
Old 06-05-2018, 07:35 PM   #2445
ovnis
Human being with feelings
 
Join Date: Oct 2011
Posts: 1,071
Default

Is it possible to add the action "Delete all snapshots of the project", please ?
ovnis is online now   Reply With Quote
Old 06-05-2018, 10:12 PM   #2446
cfillion
Human being with feelings
 
cfillion's Avatar
 
Join Date: May 2015
Location: Québec, Canada
Posts: 1,943
Default

Quote:
Originally Posted by ovnis View Post
Is it possible to add the action "Delete all snapshots of the project", please ?
Yes it is! Test builds at https://cfillion.ca/files/sws/del-snapshots/. GitHub tracker link: https://github.com/reaper-oss/sws/pull/1003.
cfillion is offline   Reply With Quote
Old 06-08-2018, 07:39 AM   #2447
svijayrathinam
Human being with feelings
 
Join Date: May 2017
Posts: 297
Default

Quote:
Originally Posted by svijayrathinam View Post
Hi There is a take fx copy paste bug in SWS extensions. Pls check out the video link below where I explain what exactly is wrong with it.

https://youtu.be/RBw-HGe0BUA

I now have a SWS EXT test version which was made by I think one of the users in the following Post in Github.

https://github.com/reaper-oss/sws/is...ment-362931592


But when I updated it to the new SWS Extentions release the bug still exist. Can you pls take a look at this ?


Hi This take fx channel bug is still not fixed in ver 2.9.8.

Can you pls fix this ?

I reported this long time ago and nofish made a temporary fix. But Now I find new feautures in SWS extension ver 2.9.8 that I want to use. But the old bug still remains..Can you pls fix this ? if not..@nofish could you pls make another temporary fix with the new version ?
svijayrathinam is offline   Reply With Quote
Old 06-08-2018, 01:32 PM   #2448
nofish
Human being with feelings
 
nofish's Avatar
 
Join Date: Oct 2007
Location: home is where the heart is
Posts: 7,815
Default

@ svijayrathinam

Sorry the fix didn't make it in 2.9.8. (It's because I was still waiting for feedback for this fix back then.)

But it's submitted meanwhile and will be in next version.

I'll try to do a temporary 2.9.8 version with this fix included soon.

edit:
Replied on your (new) GitHub issue.

Last edited by nofish; 06-08-2018 at 02:53 PM.
nofish is offline   Reply With Quote
Old 06-08-2018, 01:59 PM   #2449
svijayrathinam
Human being with feelings
 
Join Date: May 2017
Posts: 297
Default

Quote:
Originally Posted by nofish View Post
@ svijayrathinam

Sorry the fix didn't make it in 2.9.8. (It's because I was still waiting for feedback for this fix back then.)

But it's submitted meanwhile and will be in next version.

I'll try to do a temporary 2.9.8 version with this fix included soon.
Thank you.. If you can make a temporary 2.9.8 version that will help very much. Thank you
svijayrathinam is offline   Reply With Quote
Old 07-03-2018, 01:44 PM   #2450
juliansader
Human being with feelings
 
Join Date: Jul 2009
Posts: 1,853
Default

I would like to know what steps I should follow to contribute some code to SWS.

I uploaded the code to my fork at GitHub, and submitted a pull request. (I am not quite sure that I did everything correctly, since this is my first time doing pull requests.)

Is there anything else I should do? I notice that the most recent SWS installer is v2.9.7 of September 2017. There have been numerous other pull requests since then, most by cfillion, but none have been incorporated into a new SWS version yet.



EDIT: I would appreciate it a lot if someone could test whether my code builds correctly on MacOS and Linux.
juliansader is online now   Reply With Quote
Old 07-03-2018, 01:54 PM   #2451
EvilDragon
Human being with feelings
 
EvilDragon's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 21,553
Default

If you did a PR you're done, I suppose. Then it's up to the powers that be to integrate that.
EvilDragon is offline   Reply With Quote
Old 07-03-2018, 04:07 PM   #2452
nofish
Human being with feelings
 
nofish's Avatar
 
Join Date: Oct 2007
Location: home is where the heart is
Posts: 7,815
Default

@juliansader

I'm not an 'official SWS maintainer' but I did some contributions to SWS in the past I may answer some things.

- It's a good idea to start working from the next branch, rather than master branch as you did, since the 'next' branch contains all the latest code changes.
In short (don't know how familiar you are with Git branching), 'master' branch contains the code for official SWS releases, the 'next' branch is where ongoing development happens and is used for pre-releases, so it's usually ahead of the master branch. (Rundown of the branching approach, 'Develop' branch is the equivalent to the SWS 'next' branch.)

edit:
A common approach is also, rather than working on 'next' directly, to start a new local branch from next (= 'feature branch' in above link) when working on something and then pull request that branch when done. This enables working on stuff in parallel for example by simply switching branches.

- Similarly pull requests should be submitted to 'next' branch, rather than 'master' branch. (As mentioned in the README).
edit:
To clarify, you can choose which branch your pull request should be merged into when creating it on GitHub:



- It's suggested to update the whatsnew.txt, if you add new stuff, as mentioned here.

As said, I'm no SWS maintainer, so just take it as 'good practice suggestions' (other contributors may correct me).

As to your PR itself, Tim (SWS) is the current maintainer (afaik) and handles merging of PR's so he'll probably approach you if he wants something changed etc.

Sorry, can't help with Mac and Linux builds.

Last edited by nofish; 07-04-2018 at 06:15 AM.
nofish is offline   Reply With Quote
Old 07-16-2018, 08:25 PM   #2453
effitall
Human being with feelings
 
Join Date: Jan 2010
Posts: 246
Default Region playlist change?

For live performance, I have a project where I'm using Regions to indicate "songs" and within the regions, I'm using markers for song bits (intro, V1, C1, etc).

I've been making a new project every time I want to change up the set, but that isn't really fast or fun. The regions make it a little easier to copy/paste songs in the order I want, but why not use the Regions Playlist extension??

Well...It seems that the Regions Playlist editor thinks that a marker means jump to the next region. Boo. Yeah yeah..."Just delete your markers!" But I WANT the markers AND the regions!!

Is there a way to make the Regions Playlist tool ignore the markers and only follow the regions? I understand the appeal of the current method, but it would be nice to be able to turn the sensitivity to markers on/off with a toggle or something.

Thanks!
effitall is offline   Reply With Quote
Old 07-16-2018, 10:00 PM   #2454
mschnell
Human being with feelings
 
mschnell's Avatar
 
Join Date: Jun 2013
Location: Germany
Posts: 5,025
Default

Better ask this in a new dedicated forum thread with a decent topic/caption to get attention, as this is related to using, and not to updating the SWS extension.

(Unfortunately there is no dedicated subforum for "Live" usage of Reaper, yet, to prominently posting such a question).

-Michael
__________________
www.boa-sorte.de
mschnell is offline   Reply With Quote
Old 07-19-2018, 06:37 AM   #2455
ionian
Human being with feelings
 
Join Date: Sep 2012
Posts: 8
Default SWS Track Management

I just installed the SWS extensions and maybe I'm nuts but for the life of me I can't find the SWS Track/Mixer/Envelopes menu in the track control panel context menu. According to the SWS manual, it should be under "SWS Snapshots" but my context menu ends at SWS Snapshots.

Anyone know what I'm doing wrong? Thanks!
ionian is offline   Reply With Quote
Old 07-19-2018, 06:45 AM   #2456
Lokasenna
Human being with feelings
 
Lokasenna's Avatar
 
Join Date: Sep 2008
Location: The vast, frozen wasteland of western Canadia.
Posts: 4,922
Default

By "manual" do you mean "Reaper Plus! The Power of SWS Extensions"? If so, that document is eight years out of date.

Depending on what you want to do, View | Track Manager might help. Looking at a screenshot of the menu, all of those are still available in Action List. Not sure why the context menu went away.
__________________
Currently working away from home; don't expect timely responses from me.
Default 5.0 Nitpicky Edition / GUI tutorial for Lua / GUI library for Lua scripts / Theory Helper / Radial Menu / Donate / ReaPack
Lokasenna is online now   Reply With Quote
Old 07-19-2018, 06:54 AM   #2457
ionian
Human being with feelings
 
Join Date: Sep 2012
Posts: 8
Default

Quote:
Originally Posted by Lokasenna View Post
By "manual" do you mean "Reaper Plus! The Power of SWS Extensions"? If so, that document is eight years out of date.

Depending on what you want to do, View | Track Manager might help. Looking at a screenshot of the menu, all of those are still available in Action List. Not sure why the context menu went away.
Lol you're right - I didn't notice the date - 2010!

Yeah, the context menu would be fantastic but at least they're all still in the action list. I guess I can make a custom toolbar or something for the ones I think I'd use most.
ionian is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 07:39 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.