Old 03-09-2019, 01:02 PM   #41
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

Quote:
Originally Posted by mpl View Post
And please use links to GIFs or smaller GIFs. I hate Reaper5 forum theme and my Reaper3 forum view is awfully wide with such GIFs.
Sorry, saw this only by now! Will keep it in mind.

Could you nail the issue with my attached project?
__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Old 03-10-2019, 01:56 AM   #42
mpl
Human being with feelings
 
mpl's Avatar
 
Join Date: Oct 2013
Location: Moscow, Russia
Posts: 2,338
Default

Quote:
Originally Posted by _Stevie_ View Post
Could you nail the issue with my attached project?
After couple of tests 1.05 seems working with your project. Although can be still an issue with negative offsets.
__________________
SoundCloud | MPL Scripts discussion | ReaPack | Donate
mpl is offline   Reply With Quote
Old 03-10-2019, 03:37 PM   #43
matthias.matthias
Human being with feelings
 
Join Date: Jun 2010
Posts: 166
Default

Quote:
Originally Posted by mpl View Post
After couple of tests 1.05 seems working with your project. Although can be still an issue with negative offsets.
Thanks a lot! It's working great for me now.

BTW: the offsets used in film post production (positive full hours) were introduced to avoid a negative time code just before the project start, because negative offsets were causing problems... ;-)
matthias.matthias is offline   Reply With Quote
Old 03-10-2019, 04:32 PM   #44
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

Yes, indeed mpl, no worries for negative offsets. Matthias already summed it up perfectly

I small little issue remains. AFAIK, this happens, when the MIDI Take doesn't have the same length as the Item:

__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Old 03-10-2019, 09:01 PM   #45
mpl
Human being with feelings
 
mpl's Avatar
 
Join Date: Oct 2013
Location: Moscow, Russia
Posts: 2,338
Default

Technically it is CC123 (all notes off message, typical for any MIDI item) after last message so it should not be a problem. If you open it in MIDI editor and add somewhere note, it should fix item view visually.
__________________
SoundCloud | MPL Scripts discussion | ReaPack | Donate
mpl is offline   Reply With Quote
Old 03-14-2019, 03:00 PM   #46
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

MPL, I'm sorry to say but this is somehow not satisfying. I tried to work around it, but it's really overcomplicating things.

The "all notes off" generates all kinds of problems. Isn't there a way to fis this in the script? Would be very much appreciated!
__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Old 03-14-2019, 07:34 PM   #47
TonE
Human being with feelings
 
Join Date: Feb 2009
Location: Reaper HAS send control via midi !!!
Posts: 1,692
Default

Quote:
Originally Posted by _Stevie_ View Post
MPL, I'm sorry to say but this is somehow not satisfying. I tried to work around it, but it's really overcomplicating things.

The "all notes off" generates all kinds of problems. Isn't there a way to fis this in the script? Would be very much appreciated!
Stevie you could find the correct line and comment it out, adding -- before it. Just for testing if it helps. Look for the number 123 as written above.
TonE is offline   Reply With Quote
Old 03-14-2019, 09:06 PM   #48
mpl
Human being with feelings
 
mpl's Avatar
 
Join Date: Oct 2013
Location: Moscow, Russia
Posts: 2,338
Default

CC 123 in Reaper is a way to mark midi item source length. It closes any MIDI item, therefore it always should be here
__________________
SoundCloud | MPL Scripts discussion | ReaPack | Donate
mpl is offline   Reply With Quote
Old 03-14-2019, 09:44 PM   #49
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

Absolutely, it NEEDS to be there. It shouldn't be ommited.
But the CC123 should be set at the item end, so that take and item
have the same length.
__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Old 03-15-2019, 07:46 AM   #50
TonE
Human being with feelings
 
Join Date: Feb 2009
Location: Reaper HAS send control via midi !!!
Posts: 1,692
Default

What is the case now, something what should be at the end is in the middle or what, then that would be a bug. There is CC123, but in wrong position? If yes, it should be moved to correct position.
TonE is offline   Reply With Quote
Old 03-15-2019, 08:01 AM   #51
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

Check my GIF and you see what I mean.
__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Old 03-15-2019, 08:40 AM   #52
Klangfarben
Human being with feelings
 
Join Date: Jul 2016
Posts: 356
Default

I just want to add that the CC123 message is very dangerous and can have a lot of unintended consequences. That is why no user ever writes CC123 into a midi item in day-to-day midi editing.

I don't think this is a question of "can we move the CC123 event". I think the question should be can this be done without any CC123 message at all? Because anything else like I said is really, really dangerous - and will also break a lot of other scripts we use.

MPL, can this script work without inserting the CC123 message and still have Reaper get the midi item source length?
Klangfarben is online now   Reply With Quote
Old 03-15-2019, 10:48 AM   #53
mpl
Human being with feelings
 
mpl's Avatar
 
Join Date: Oct 2013
Location: Moscow, Russia
Posts: 2,338
Default

Quote:
Originally Posted by Klangfarben View Post
I think the question should be can this be done without any CC123 message at all?
No, it can`t be done without this. I replaced manual adding CC123 by native API function for setting item edges properly, see 1.06.
__________________
SoundCloud | MPL Scripts discussion | ReaPack | Donate
mpl is offline   Reply With Quote
Old 03-15-2019, 11:36 AM   #54
Klangfarben
Human being with feelings
 
Join Date: Jul 2016
Posts: 356
Default

Quote:
Originally Posted by mpl View Post
NI replaced manual adding CC123 by native API function for setting item edges properly, see 1.06.
Thank you so much!
Klangfarben is online now   Reply With Quote
Old 03-15-2019, 12:41 PM   #55
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

This looks really good so gar mpl, thank you so much! Now everything works
__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Old 03-16-2019, 10:01 PM   #56
_Stevie_
Human being with feelings
 
_Stevie_'s Avatar
 
Join Date: Oct 2017
Posts: 1,772
Default

I just found an issue that I hadn't thought about, until now.
When having tempo changes in the project, retrospective record does not
follow them. Maybe that's a corner case that hasn't been taken into account?
__________________
My Reascripts forum thread | My Reascripts on GitHub | Stephan Römer - film composer
If you wish to donate for my scripts: please consider an organization like: animal shelter, doctors without borders, UNICEF, etc...
_Stevie_ is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 11:24 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.