Old 05-15-2019, 11:49 AM   #41
juliansader
Human being with feelings
 
Join Date: Jul 2009
Posts: 2,584
Default

Quote:
Originally Posted by mccrabney View Post
nicely done. selected vs unselected notes pop now. consider me gruntled.
Unfortunately, I'm not quite gruntled yet: as this image shows, selected CCs and notes are still almost indiscernable.



EDIT: Even when using the default theme:


Last edited by juliansader; 05-15-2019 at 01:56 PM.
juliansader is offline   Reply With Quote
Old 05-15-2019, 02:28 PM   #42
EvilDragon
Human being with feelings
 
EvilDragon's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 22,958
Default

In your top image selected vs unselected seem perfectly discernible to me.

But, I don't think we can realistically expect all 16 million colors to work with just brightess change against all the different backgrounds. Some colors just won't be very good, and then it's time to pick another color
EvilDragon is online now   Reply With Quote
Old 05-15-2019, 05:33 PM   #43
juliansader
Human being with feelings
 
Join Date: Jul 2009
Posts: 2,584
Default

Quote:
Originally Posted by EvilDragon View Post
But, I don't think we can realistically expect all 16 million colors to work
I suspect that with proper selection of contrasts, we can get very close.


Quote:
with just brightess change
It seems to me that the color contrasts are currently derived from HSV color space, since the selected events have maximum HSV saturation and value/brightness. HSL luminosity may be better, since luminosity can tint the selected events with a little bit of white to better distinguish them, if the user so desires.


Quote:
against all the different backgrounds.
This is why the best solution may be to add two new theme settings that the user or themer can customize:
* MIDI editor unselected event luminosity
* MIDI editor selected event luminosity


Quote:
Some colors just won't be very good, and then it's time to pick another color
Asking (many) users to change the track and item colors of all existing projects will not be very user friendly. Moreover, it may be difficult to find colors that work well in both the arrange view and MIDI editor: in my own theme (like those of many other users), in the arrange view, the track/item color is the selected color, and the unselected color is darker. In the MIDI editor, it is the other way around: the track/item color gives the unselected color, and the selected color is brighter.
juliansader is offline   Reply With Quote
Old 05-16-2019, 06:13 AM   #44
nofish
Human being with feelings
 
nofish's Avatar
 
Join Date: Oct 2007
Location: home is where the heart is
Posts: 8,795
Default

Quote:
Originally Posted by juliansader View Post
Unfortunately, I'm not quite gruntled yet: as this image shows, selected CCs and notes are still almost indiscernable.
Wondering why in your pic the area below selected CCs isn't highlighted as is here. This was added a few dev versions ago and also helps to discern selected vs. unselected imo.

nofish is offline   Reply With Quote
Old 05-16-2019, 06:22 AM   #45
juliansader
Human being with feelings
 
Join Date: Jul 2009
Posts: 2,584
Default

AFAIK, the fill is only under CCs in the active channel.
juliansader is offline   Reply With Quote
Old 05-16-2019, 06:43 AM   #46
nofish
Human being with feelings
 
nofish's Avatar
 
Join Date: Oct 2007
Location: home is where the heart is
Posts: 8,795
Default

Ah ok.
I rarely do multichannel CC so didn't notice.
nofish is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 11:40 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.