ovnis - Propagation of active takes color to all similarly named active takes

[ovnis]

Select some items for local propagation. Don't select anything for general propagation.



https://stash.reaper.fm/v/24935/ovnis...ve%20takes.lua

[X-Raym]

Thanks for sharing your first script with us !

[ovnis]

Hello, little issue with "Propagation of active takes color to all similarly named active takes":

...tive takes color to all similarly named active takes.lua:57: bad argument #1 to 'GetTakeName' (MediaItem_Take expected)

DO you know to avoid this?

function Main()
	--reaper.Undo_BeginBlock()
	selected_items_count=reaper.CountSelectedMediaItems(0)
	if selected_items_count~=0 then
		for j=0, selected_items_count-1 do
			item_selected=reaper.GetSelectedMediaItem(0, j)
			if item_selected~=nil then
				item_take_active_selected=reaper.GetActiveTake(item_selected)
				name_item_take_active_selected=reaper.GetTakeName(item_take_active_selected)
				color_item_take_active_selected=reaper.GetMediaItemTakeInfo_Value(item_take_active_selected, "I_CUSTOMCOLOR")
				items_count=reaper.CountMediaItems(0)
				for i=0, items_count-1 do
					item=reaper.GetMediaItem(0, i)
					if item~=item_selected then
						takes_count=reaper.CountTakes(item)
						for v=0, takes_count-1 do
							item_take=reaper.GetTake(item, v)
							if item_take~= nil then
								name_item_take=reaper.GetTakeName(item_take)
								if name_item_take==name_item_take_active_selected then 
									reaper.SetMediaItemTakeInfo_Value(item_take, "I_CUSTOMCOLOR", color_item_take_active_selected)
								end
							end
						end
					end
				end
			end
		end
	else
		items_count_source=reaper.CountMediaItems(0)
		for j=0, items_count_source-1 do
			item_source=reaper.GetMediaItem(0, j)
			if item_source~=nil then
				item_take_active_source=reaper.GetActiveTake(item_source)
				name_item_take_active_source=reaper.GetTakeName(item_take_active_source)
				color_item_take_active_source=reaper.GetMediaItemTakeInfo_Value(item_take_active_source, "I_CUSTOMCOLOR")
				items_count=reaper.CountMediaItems(0)
				for i=0, items_count-1 do
					item=reaper.GetMediaItem(0, i)
					if item~=item_source then
						takes_count=reaper.CountTakes(item)
						for v=0, takes_count-1 do
							item_take=reaper.GetTake(item, v)
							if item_take~= nil then
								name_item_take=reaper.GetTakeName(item_take)
								if name_item_take==name_item_take_active_source then 
									reaper.SetMediaItemTakeInfo_Value(item_take, "I_CUSTOMCOLOR", color_item_take_active_source)
								end
							end
						end
					end
				end
			end
		end
	end
--reaper.Undo_EndBlock("Propagation of active takes color to all similarly named active takes", -1)
end
reaper.PreventUIRefresh(1)
Main()
reaper.defer(Main)
reaper.UpdateArrange()
reaper.PreventUIRefresh(-1)

[X-Raym]

The original source code you uploaded on stash doesn't have this issue cause it do have the Take check before the take name funciton line 57

                item_take_active_source=reaper.GetActiveTake(item_source)
                if item_take_active_source then
                    name_item_take_active_source=reaper.GetTakeName(item_take_active_source)

(note this kind of check is needed twice in the script, one in first loop and one in second)


The error is within your posted scripted here, which doesn't seems to reflect what is on stash

[ovnis]

You are right! Thx you very much for your help!