The "Set channel for new events" actions activate the event filter (FIXED)

[juliansader]

The "Set channel for new events to 01 [-16]" actions inappropriately activate the event filter.

Equally strange, this filter can then be deactivated by drawing in some random notes.



This bug affects some of my scripts that are intended to change the MIDI editor's default channels, such as
* js_MIDI Inspector.lua
* js_Option - Switching active take sets channel for new events to channel of existing events.lua

Since the MIDI editor does not offer channel management by default, it is important to get these scripts working properly.

[juliansader]

Here is a more direct demonstration of what happens:

[juliansader]

Almost all these channel filter bugs have been solved in v5.24 and v5.25, and none of the following actions activate the Event Filter any more:

* "Set channel for new events to 01 [-16]"

* "Set channel higher/lower for new events" (that these actions also activate the Event Filter was discovered later)


One other action that acts rather unintuitively, is "Channel: Show all channels": Instead of simply showing all channels, as one would expect, it also

* Activates the Event Filter (similar to the "Show only channel ..." actions), which may hide some events.

* But at the same time, it hides the Filter checkbox in the MIDI editor, as if the Filter is inactive.

I suggest that it would be more intuitive if "Show all channels" DEactivates rather than activates any relevant filters.