Go Back   Cockos Incorporated Forums > REAPER Forums > REAPER Bug Reports

Reply
 
Thread Tools Display Modes
Old 10-11-2016, 09:05 AM   #1
Xenakios
Human being with feelings
 
Xenakios's Avatar
 
Join Date: Feb 2007
Location: Oulu, Finland
Posts: 6,555
Default Rename source file name breaks undo history (FIXED)

If the media file name is changed with the item properties "Rename file..." function, the undo history will not restore the original file name when going back in the undo history, thus causing the item playback to go silent.

I think this is an ancient bug that I only now realized still exists in Reaper.
__________________
For info on SWS Reaper extension plugin (including Xenakios' previous extension/actions) :
http://www.sws-extension.org/
https://github.com/Jeff0S/sws
--
Xenakios blog (about HourGlass and λ) :
http://xenakios.wordpress.com/
Xenakios is online now   Reply With Quote
Old 10-11-2016, 09:16 AM   #2
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 10,241
Default

Do you think if you rename the file, it should go rewrite the history? Or do you think it should prompt for the other file when restoring state and the old filename couldn't be found?
Justin is online now   Reply With Quote
Old 10-11-2016, 09:21 AM   #3
EvilDragon
Human being with feelings
 
EvilDragon's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 18,876
Default

IMHO it should rewrite history, in order for the item to continue playing normally.
EvilDragon is online now   Reply With Quote
Old 10-12-2016, 03:42 AM   #4
Xenakios
Human being with feelings
 
Xenakios's Avatar
 
Join Date: Feb 2007
Location: Oulu, Finland
Posts: 6,555
Default

Quote:
Originally Posted by EvilDragon View Post
IMHO it should rewrite history, in order for the item to continue playing normally.
Or store both the original and renamed file name in the state data, so it would be possible to know the file name was changed and then change the file name back on disk...

edit : Rewriting the undo history, if possible, would probably be the best approach...The option I like the least would be the file dialog asking for the file.
__________________
For info on SWS Reaper extension plugin (including Xenakios' previous extension/actions) :
http://www.sws-extension.org/
https://github.com/Jeff0S/sws
--
Xenakios blog (about HourGlass and λ) :
http://xenakios.wordpress.com/

Last edited by Xenakios; 10-12-2016 at 06:57 AM.
Xenakios is online now   Reply With Quote
Old 10-12-2016, 11:23 AM   #5
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 10,241
Default

I'll make it rewrite history.. of course, if you don't save the project, or if you have another copy of the project saved, those won't be updated... so keep that in mind when using rename source file
Justin is online now   Reply With Quote
Old 10-12-2016, 12:37 PM   #6
Xenakios
Human being with feelings
 
Xenakios's Avatar
 
Join Date: Feb 2007
Location: Oulu, Finland
Posts: 6,555
Default

Quote:
Originally Posted by Justin View Post
I'll make it rewrite history.. of course, if you don't save the project, or if you have another copy of the project saved, those won't be updated... so keep that in mind when using rename source file
Sounds fine to me.
__________________
For info on SWS Reaper extension plugin (including Xenakios' previous extension/actions) :
http://www.sws-extension.org/
https://github.com/Jeff0S/sws
--
Xenakios blog (about HourGlass and λ) :
http://xenakios.wordpress.com/
Xenakios is online now   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 06:38 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2017, vBulletin Solutions Inc.