Old 04-17-2017, 12:41 PM   #1
EvilDragon
Human being with feelings
 
EvilDragon's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 19,258
Default Explode MIDI notes to items is broken (FIXED)

The action to explode MIDI note rows to separate items is broken if NON-CC data (pitch bend, aftertouch, program change, etc.) events are contained in it. It creates way more items than necessary in this case, up to more than a hundred if the stream of these events is dense! I didn't notice it until this thread: http://forum.cockos.com/showthread.php?t=190669. The project is attached in post #25, but this can be recreated even with an empty project and some added MIDI data.


Also, I think it's not a cool behaviour that CCs don't get copied to the exploded items. Say if we have some MIDI CC data in the original item, only the first exploded item gets them, the others get nothing. This is pretty important if pitch bend events are part of the game here.

This action is pretty broken right now, so it needs an urgent fix.

1. It should only create as many items as there are notes in the original item.
2. Each exploded item should get the EXACT copy of all pitch/aftertouch/CC data over.
3. Meta-events (text, sysex, notation) should get their own item. Perhaps it would be better to have a variant of this action that explodes meta-events as well (the current action could ignore them altogether).
EvilDragon is online now   Reply With Quote
Old 04-17-2017, 01:51 PM   #2
schwa
Administrator
 
schwa's Avatar
 
Join Date: Mar 2007
Location: NY
Posts: 9,289
Default

The bug is an easy fix. The rest is more of an FR and probably should be multiple new actions to support including CC events when exploding by pitch, and/or creating a separate item for CC events, and also to create a separate item for meta-messages when exploding by either channel or pitch.
schwa is offline   Reply With Quote
Old 04-17-2017, 02:30 PM   #3
EvilDragon
Human being with feelings
 
EvilDragon's Avatar
 
Join Date: Jun 2009
Location: Croatia
Posts: 19,258
Default

Awesome!

If additional actions are also not too complicated, it'd be pretty cool to have them. Thanks schwa
EvilDragon is online now   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 02:56 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2017, vBulletin Solutions Inc.