Reproducable crash: "SWS/BR: Normalize loudness of selected items to -23 LUFS"

[BPBaker]

Whenever I use "SWS/BR: Normalize loudness of selected items to -23 LUFS" **but without having an item selected** (usually by accident), the action attempts to run, appears to freeze, and then crashes Reaper a few seconds later.

My colleague reports the same behavior on her computer, too.

When this happens, I get an OSX crash report like so:

Process: REAPER [84580]
Path: /Applications/REAPER/REAPER64.app/Contents/MacOS/REAPER
Identifier: REAPER
Version: 5.70.26 (5.70.26)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: REAPER [84580]
User ID: 501

Date/Time: 2018-01-30 17:30:05.497 -0500
OS Version: Mac OS X 10.13.3 (17D47)
Report Version: 12
Anonymous UUID: 44F3AA7C-C79A-EBB4-1807-B0B8356B3136

Sleep/Wake UUID: 8141DBBD-A2E6-41F7-B234-C9BAB2FD9274

Time Awake Since Boot: 200000 seconds
Time Since Wake: 110000 seconds

System Integrity Protection: enabled

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY

Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [0]

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 com.cockos.reaper 0x0000000102b63671 WaitForSingleObject(void*, unsigned int) + 33
1 reaper_sws_extension.dylib 0x000000010e4eb4e9 BR_LoudnessObject::AbortAnalyze() + 169
2 reaper_sws_extension.dylib 0x000000010e4ece8b NormalizeProgressProc(HWND__*, unsigned int, unsigned long, long) + 731
3 com.cockos.reaper 0x0000000102b38e46 SwellDialogDefaultWindowProc(HWND__*, unsigned int, unsigned long, long) + 438
4 com.cockos.reaper 0x0000000102b36a76 -[REAPERSwell_hwnd onSwellMessage12:] + 118
5 com.cockos.reaper 0x0000000102b3eddb EndDialog(HWND__*, int) + 299
6 reaper_sws_extension.dylib 0x000000010e4ecd5e NormalizeProgressProc(HWND__*, unsigned int, unsigned long, long) + 430
7 com.cockos.reaper 0x0000000102b38e46 SwellDialogDefaultWindowProc(HWND__*, unsigned int, unsigned long, long) + 438
8 com.apple.Foundation 0x00007fff44baf659 __NSFireTimer + 83
9 com.apple.CoreFoundation 0x00007fff42a6fdd4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUN CTION__ + 20
10 com.apple.CoreFoundation 0x00007fff42a6fa47 __CFRunLoopDoTimer + 1095
11 com.apple.CoreFoundation 0x00007fff42a6f54a __CFRunLoopDoTimers + 346
12 com.apple.CoreFoundation 0x00007fff42a66b4b __CFRunLoopRun + 2427
13 com.apple.CoreFoundation 0x00007fff42a65f43 CFRunLoopRunSpecific + 483
14 com.apple.HIToolbox 0x00007fff41d7de26 RunCurrentEventLoopInMode + 286
15 com.apple.HIToolbox 0x00007fff41d7db96 ReceiveNextEventCommon + 613
16 com.apple.HIToolbox 0x00007fff41d7d914 _BlockUntilNextEventMatchingListInModeWithFilter + 64
17 com.apple.AppKit 0x00007fff40048f5f _DPSNextEvent + 2085
18 com.apple.AppKit 0x00007fff407deb4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:deque ue:] + 3044
19 com.apple.AppKit 0x00007fff4027b267 -[NSApplication _doModalLoopeek:] + 476
20 com.apple.AppKit 0x00007fff4045ffd3 __35-[NSApplication runModalForWindow:]_block_invoke_2 + 64
21 com.apple.AppKit 0x00007fff4045ff80 __35-[NSApplication runModalForWindow:]_block_invoke + 75
22 com.apple.AppKit 0x00007fff4090dee6 _NSTryRunModal + 100
23 com.apple.AppKit 0x00007fff40278cf9 -[NSApplication runModalForWindow:] + 133
24 com.cockos.reaper 0x0000000102b3ef6e SWELL_DialogBox(SWELL_DialogResourceIndex*, char const*, HWND__*, long (*)(HWND__*, unsigned int, unsigned long, long), long) + 286
25 reaper_sws_extension.dylib 0x000000010e27ec27 __localizeDialog(void*, char const*, HWND__*, long (*)(HWND__*, unsigned int, unsigned long, long), long, int) + 215
26 reaper_sws_extension.dylib 0x000000010e4e7315 NormalizeAndShowProgress(BR_NormalizeData*) + 149
27 reaper_sws_extension.dylib 0x000000010e501b7c NormalizeLoudness(COMMAND_T*) + 460
28 reaper_sws_extension.dylib 0x000000010e2825fb hookCommandProc(int, int) + 731
29 com.cockos.reaper 0x00000001026ae700 Main_OnCommandEx2(int, int, ReaProject*) + 112
30 com.cockos.reaper 0x000000010270787d Main_OnCommandEx(int, int, ReaProject*) + 29
31 com.cockos.reaper 0x0000000102985007 KBD_OnMainActionEx(int, int, int, int, HWND__*, ReaProject*) + 151
32 com.cockos.reaper 0x0000000102984f5c KBD_OnMainAction(int, int, int, int, HWND__*) + 12
33 com.cockos.reaper 0x0000000102989d04 kbd_onAction(KbdAccel*, int, int, int, bool, KbdSectionInfo*, HWND__*) + 1828
34 com.cockos.reaper 0x000000010298bf8a kbd_translateAccelerator(HWND__*, MSG*, KbdSectionInfo*) + 410
35 com.cockos.reaper 0x000000010299032b -[REAPERapp sendEvent:] + 3179
36 com.apple.AppKit 0x00007fff4003dd9d -[NSApplication run] + 812
37 com.apple.AppKit 0x00007fff4000cf1a NSApplicationMain + 804
38 com.cockos.reaper 0x0000000102651c34 start + 52

[cfillion]

I was able to reproduce the crash, looking into it! SWS bugs however are not REAPER bugs. SWS has it's own bugtracker here: https://github.com/reaper-oss/sws/issues.

[vanhaze]

Just tested: I am not able to reproduce that crash.

I see in a glimpse a progress window when executing that Action (with no Item(s) selected), but no crash in the end.

- OSX 10.13.3
- Reaper 5.71pre16a-64bit
- Macbook Retina mid 2015.

[cfillion]

@vanhaze Try selecting an item, running the action once, unselecting it (so that nothing is selected anymore), and running the action again. Sometimes it just freezes for a little bit without crashing though.

[vanhaze]

Wow, you are sharp ! :

- did exactly as you told:
- When executing the Action a second time whith no item(s) selected, it leads to a spinning beachball for about 5 seconds, but no Reaper crash in the end, Reaper stays foot.

[karbomusic]

That's obviously a bug but since this is never needed (LUFs of a non-existent item).... Don't do that is a fine workaround while waiting for a fix.

[vanhaze]

Seems logical and fine by me indeed.

[cfillion]

Fixed. https://cfillion.ca/files/sws/normalize-noitemsel-fix/

[vanhaze]

Just tested and indeed, fixed : no more spinning beachball when i execute the script a second time with no items selected.

Many Thx cfillion !

[BPBaker]

Amazing. Tested as well and works like a charm.

My colleague and I use the normalize loudness function hundreds of times a day for podcast dialogue edits. This will save our asses in those moments where we don't have items selected.

Thanks a bunch!! (Will this fix be incorporated into future version of SWS?)

[cfillion]

Originally Posted by BPBaker

(Will this fix be incorporated into future version of SWS?)

Yes it should be included.