Toggle state isn't updated in the Actions list

Buy One · 01-14-2021, 11:58 AM

When the toolbar action is run by double click or via the Run button.

It only gets updated after toggling another toolbar or after closing and reopening the Actions list.

Neither manual closing or opening a toolbar in Arrange makes its toggle state update in the open Actions list.

It's also annoying that at click on the action the list auto-scrolls up.

Meo-Ada Mespotine · 01-14-2021, 03:09 PM

I can confirm both.

akademie · 01-27-2021, 07:24 AM

yes, it's very misleading

Buy One · 01-27-2021, 07:40 AM

As Mespotine suggested adding here the description of how it affects programmatically set toggle states

Quote:

Basically a script's initial toggle state isn't displayed in the Action list upon being first set, only appears after reopening the Action list.
Had tried reaper.UpdateArrange() just in case, but it didn't help.

While doing some stuff bumped into the same behavior from Monitoring FX: Toggle bypass as well

Track: Toggle FX bypass for selected tracks updates right away.

SWS/S&M toggle actions don't exhibit this behavior but still make the action list scroll.
.
.
.

J Reverb · 01-27-2021, 10:09 AM

The same thing happens when arming track envelopes, the envelope window doesn't update until re opened. It will update via the buttons in the envelope window and via script though.

cfillion · 01-28-2021, 06:37 AM

This used to work. I don't remember in which version exactly, but it broke sometime during v5.

MonkeyBars · 12-31-2022, 09:56 AM

Bug confirmed. This is a pretty nasty one not just for us ReaScripters but also any power user needing to keep track of Boolean actions for custom/cycle actions, toolbar buttons, etc.

Justin · 12-31-2022, 10:54 AM

ah yeah, fixing!

MonkeyBars · 12-31-2022, 12:22 PM

Quote:

Originally Posted by Justin

ah yeah, fixing!

happy new year Justin, and thanks so much!

Justin · 12-31-2022, 05:46 PM

Happy New Year!

One problem with fixing this bug -- SWS seems to call RefreshToolbar() incessantly, ugh. :/

cfillion · 12-31-2022, 08:42 PM

Quote:

Originally Posted by Justin

One problem with fixing this bug -- SWS seems to call RefreshToolbar() incessantly, ugh. :/

This can be disabled in Extensions > SWS Options > Enable toolbars auto refresh.

The intent of that feature was to support actions whose toggle state automatically changes depending on the offscreen visibility of items when scrolling:

Quote:

Originally Posted by Jeffos

Offscreen item selection/deselection

It's something to prevent user errors. You know, when you edit items but *not all* selected items are visible in the arrange...
...AAaarrrrggg! I don't know how many sessions we've messed up because of that!
So I've added:

Code:

+SWS/S&M: Toolbar - Toggle offscreen item selection
+SWS/S&M: Toolbar - Toggle offscreen item selection (left)
+SWS/S&M: Toolbar - Toggle offscreen item selection (right)
+SWS/S&M: Toolbar - Toggle offscreen item selection (top)
+SWS/S&M: Toolbar - Toggle offscreen item selection (bottom)

^^ EDITED (November 2013): renamed actions + OS X support. A new action "SWS/S&M: Unselect offscreen items" can be handy too.

These actions allow you selecting/unselecting offscreen items.
When these actions are added in a toolbar, related buttons automatically light-up when at least one selected item is offscreen (the option "Main menu > Extensions > SWS options > Auto-refresh toolbars" must be enabled).

Example:

I suppose that could be rewritten to just watch the item visibility and refresh the toolbars accordingly instead of blindly refreshing every "ToolbarsAutoRefreshFreq" in S&M.ini...

Justin · 01-02-2023, 03:50 PM

Quote:

Originally Posted by cfillion

I suppose that could be rewritten to just watch the item visibility and refresh the toolbars accordingly instead of blindly refreshing every "ToolbarsAutoRefreshFreq" in S&M.ini...

It would be _vastly_ preferable from a performance perspective if it calculated the states and only refreshed when the states changed, yeah.

cfillion · 01-03-2023, 05:33 AM

Quote:

Originally Posted by Justin

It would be _vastly_ preferable from a performance perspective if it calculated the states and only refreshed when the states changed, yeah.

OK, done! Builds at https://github.com/reaper-oss/sws/pu...ent-1369647587. (Could be a while before it lands in a stable SWS release though, but we're making a new pre-release soon.)

Justin · 01-03-2023, 07:57 AM

Quote:

Originally Posted by cfillion

OK, done! Builds at https://github.com/reaper-oss/sws/pu...ent-1369647587. (Could be a while before it lands in a stable SWS release though, but we're making a new pre-release soon.)

awesome, thanks!