 |
|
|
01-14-2021, 11:58 AM
|
#1
|
Human being with feelings
Join Date: Sep 2019
Posts: 1,012
|
Toggle state isn't updated in the Actions list
When the toolbar action is run by double click or via the Run button.
It only gets updated after toggling another toolbar or after closing and reopening the Actions list.
Neither manual closing or opening a toolbar in Arrange makes its toggle state update in the open Actions list.
It's also annoying that at click on the action the list auto-scrolls up.
Last edited by Buy One; 01-27-2021 at 07:41 AM.
|
|
|
01-14-2021, 03:09 PM
|
#2
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,485
|
I can confirm both.
|
|
|
01-27-2021, 07:24 AM
|
#3
|
Human being with feelings
Join Date: Mar 2007
Posts: 3,854
|
yes, it's very misleading
|
|
|
01-27-2021, 07:40 AM
|
#4
|
Human being with feelings
Join Date: Sep 2019
Posts: 1,012
|
As Mespotine suggested adding here the description of how it affects programmatically set toggle states
Quote:
Basically a script's initial toggle state isn't displayed in the Action list upon being first set, only appears after reopening the Action list.
Had tried reaper.UpdateArrange() just in case, but it didn't help.
|
While doing some stuff bumped into the same behavior from Monitoring FX: Toggle bypass as well
Track: Toggle FX bypass for selected tracks updates right away.
SWS/S&M toggle actions don't exhibit this behavior but still make the action list scroll.
.
.
.
Last edited by Buy One; 01-27-2021 at 08:07 AM.
|
|
|
01-27-2021, 10:09 AM
|
#5
|
Human being with feelings
Join Date: Jul 2009
Posts: 984
|
The same thing happens when arming track envelopes, the envelope window doesn't update until re opened. It will update via the buttons in the envelope window and via script though.
|
|
|
01-28-2021, 06:37 AM
|
#6
|
Human being with feelings
Join Date: May 2015
Location: Québec, Canada
Posts: 4,683
|
This used to work. I don't remember in which version exactly, but it broke sometime during v5.
|
|
|
12-31-2022, 09:56 AM
|
#7
|
Human being with feelings
Join Date: Feb 2016
Location: Hollyweird
Posts: 2,520
|
Bug confirmed. This is a pretty nasty one not just for us ReaScripters but also any power user needing to keep track of Boolean actions for custom/cycle actions, toolbar buttons, etc.
|
|
|
12-31-2022, 10:54 AM
|
#8
|
Administrator
Join Date: Jan 2005
Location: NYC
Posts: 15,597
|
ah yeah, fixing!
|
|
|
12-31-2022, 12:22 PM
|
#9
|
Human being with feelings
Join Date: Feb 2016
Location: Hollyweird
Posts: 2,520
|
Quote:
Originally Posted by Justin
ah yeah, fixing!
|
happy new year Justin, and thanks so much!
|
|
|
12-31-2022, 05:46 PM
|
#10
|
Administrator
Join Date: Jan 2005
Location: NYC
Posts: 15,597
|
Happy New Year!
One problem with fixing this bug -- SWS seems to call RefreshToolbar() incessantly, ugh. :/
|
|
|
12-31-2022, 08:42 PM
|
#11
|
Human being with feelings
Join Date: May 2015
Location: Québec, Canada
Posts: 4,683
|
Quote:
Originally Posted by Justin
One problem with fixing this bug -- SWS seems to call RefreshToolbar() incessantly, ugh. :/
|
This can be disabled in Extensions > SWS Options > Enable toolbars auto refresh.
The intent of that feature was to support actions whose toggle state automatically changes depending on the offscreen visibility of items when scrolling:
Quote:
Originally Posted by Jeffos
Offscreen item selection/deselection
It's something to prevent user errors. You know, when you edit items but *not all* selected items are visible in the arrange...
...AAaarrrrggg! I don't know how many sessions we've messed up because of that!
So I've added:
Code:
+SWS/S&M: Toolbar - Toggle offscreen item selection
+SWS/S&M: Toolbar - Toggle offscreen item selection (left)
+SWS/S&M: Toolbar - Toggle offscreen item selection (right)
+SWS/S&M: Toolbar - Toggle offscreen item selection (top)
+SWS/S&M: Toolbar - Toggle offscreen item selection (bottom)
^^ EDITED (November 2013): renamed actions + OS X support. A new action "SWS/S&M: Unselect offscreen items" can be handy too.
These actions allow you selecting/unselecting offscreen items.
When these actions are added in a toolbar, related buttons automatically light-up when at least one selected item is offscreen (the option "Main menu > Extensions > SWS options > Auto-refresh toolbars" must be enabled).
Example:

|
I suppose that could be rewritten to just watch the item visibility and refresh the toolbars accordingly instead of blindly refreshing every "ToolbarsAutoRefreshFreq" in S&M.ini...
Last edited by cfillion; 12-31-2022 at 08:54 PM.
|
|
|
01-02-2023, 03:50 PM
|
#12
|
Administrator
Join Date: Jan 2005
Location: NYC
Posts: 15,597
|
Quote:
Originally Posted by cfillion
I suppose that could be rewritten to just watch the item visibility and refresh the toolbars accordingly instead of blindly refreshing every "ToolbarsAutoRefreshFreq" in S&M.ini...
|
It would be _vastly_ preferable from a performance perspective if it calculated the states and only refreshed when the states changed, yeah.
|
|
|
01-03-2023, 05:33 AM
|
#13
|
Human being with feelings
Join Date: May 2015
Location: Québec, Canada
Posts: 4,683
|
Quote:
Originally Posted by Justin
It would be _vastly_ preferable from a performance perspective if it calculated the states and only refreshed when the states changed, yeah.
|
OK, done! Builds at https://github.com/reaper-oss/sws/pu...ent-1369647587. (Could be a while before it lands in a stable SWS release though, but we're making a new pre-release soon.)
Last edited by cfillion; 01-03-2023 at 05:39 AM.
|
|
|
01-03-2023, 07:57 AM
|
#14
|
Administrator
Join Date: Jan 2005
Location: NYC
Posts: 15,597
|
Quote:
Originally Posted by cfillion
|
awesome, thanks!
|
|
|
Thread Tools |
|
Display Modes |
Linear Mode
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -7. The time now is 06:26 AM.
|