Go Back   Cockos Incorporated Forums > REAPER Forums > REAPER Bug Reports

Reply
 
Thread Tools Display Modes
Old 03-12-2021, 09:08 AM   #1
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default [6.25] Close FX windows odd behaviour (FIXED)

Hello.

The video(GIF) below is showing the behaviour. No scripts are running in the background. The project is made from scratch.

Bug: closing FX windows doesn't create undo points (maybe it should be excluded from Undo history at all. Even if it creates undo points, travelling between different undo points doesn't open/close FX windows again.

Expected behaviour: opening/closing FX (chain) windows should not create any undo points. Otherwise if they're created, they should allow to undo/redo.

Windows 10 Pro, Reaper 6.25 64-bit.


Last edited by vitalker; 04-08-2021 at 06:15 AM.
vitalker is online now   Reply With Quote
Old 03-22-2021, 11:08 AM   #2
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

Anyone?
vitalker is online now   Reply With Quote
Old 03-22-2021, 11:27 AM   #3
JamesPeters
Human being with feelings
 
Join Date: Aug 2011
Location: Near a big lake
Posts: 3,943
Default

Confirmed in Reaper for Linux v6.25+dev0319
JamesPeters is offline   Reply With Quote
Old 03-22-2021, 01:45 PM   #4
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

Quote:
Originally Posted by JamesPeters View Post
Confirmed in Reaper for Linux v6.25+dev0319
Thanks!
vitalker is online now   Reply With Quote
Old 03-23-2021, 05:44 AM   #5
Spookye
Human being with feelings
 
Spookye's Avatar
 
Join Date: Jul 2018
Location: Torino ITALY
Posts: 455
Default

Quote:
Originally Posted by vitalker View Post
Anyone?




Here everything is fine. Windows 7 x32
Spookye is offline   Reply With Quote
Old 03-23-2021, 06:10 AM   #6
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

Quote:
Originally Posted by Spookye View Post
Here everything is fine. Windows 7 x32
Did you do the same like on the GIF?
vitalker is online now   Reply With Quote
Old 03-23-2021, 03:12 PM   #7
Fabian
Human being with feelings
 
Fabian's Avatar
 
Join Date: Sep 2008
Location: Sweden
Posts: 6,885
Default

Are you talking about this https://forum.cockos.com/showthread.php?t=177119

It has been around for a long time apparently, and there is some argument for why it is like it is. However, it also creates some issues of its own. I just now stumbled on a bug with my MFXlist, when undoing past a Close FX Chain undo point...
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Fabian is offline   Reply With Quote
Old 03-23-2021, 03:20 PM   #8
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

Quote:
Originally Posted by Fabian View Post
Well not exactly. Excluding it from undo history would probably solve it, but I am talking about inconsistency. Undo points are created, but as you can see on my GIF, sometimes they behave really odd. One time it will undo and open FX chain back, but another time nothing will happen.
vitalker is online now   Reply With Quote
Old 03-23-2021, 05:37 PM   #9
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,196
Default

The original reason for the "closing window" undo point is to catch any unreported state changes from plug-ins... maybe that's outdated and we should remove it (or at least make it optional)
Justin is online now   Reply With Quote
Old 03-24-2021, 01:22 AM   #10
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

Quote:
Originally Posted by Justin View Post
The original reason for the "closing window" undo point is to catch any unreported state changes from plug-ins... maybe that's outdated and we should remove it (or at least make it optional)
Yes! It would be awesome! As you can see, I am talking about not closing fx window itself and adding undo point, but its odd behaviour. These undo points don't work properly like for other actions.
vitalker is online now   Reply With Quote
Old 03-24-2021, 03:03 AM   #11
nappies
Human being with feelings
 
nappies's Avatar
 
Join Date: Dec 2017
Posts: 255
Default

It would be cool! It makes you do a lot of unnecessary movements when you need to undo.
nappies is online now   Reply With Quote
Old 03-24-2021, 11:49 AM   #12
Fabian
Human being with feelings
 
Fabian's Avatar
 
Join Date: Sep 2008
Location: Sweden
Posts: 6,885
Default

Quote:
Originally Posted by Justin View Post
The original reason for the "closing window" undo point is to catch any unreported state changes from plug-ins... maybe that's outdated and we should remove it (or at least make it optional)
That would (probably) solve the strange behavior in MFXlist (https://forum.cockos.com/showthread.php?t=248411) that I've seen when I undo such a close FX chain in one project tab, and then close the tab. MFXlist gets confused and crashes.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Fabian is offline   Reply With Quote
Old 04-05-2021, 05:04 AM   #13
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

I hope we will see it in 6.27.
vitalker is online now   Reply With Quote
Old 04-06-2021, 12:38 PM   #14
nappies
Human being with feelings
 
nappies's Avatar
 
Join Date: Dec 2017
Posts: 255
Default

Quote:
Originally Posted by vitalker View Post
I hope we will see it in 6.27.
Would be very cool!
nappies is online now   Reply With Quote
Old 04-11-2021, 10:31 AM   #15
Edgemeal
Human being with feelings
 
Edgemeal's Avatar
 
Join Date: Apr 2016
Location: ASU`ogacihC
Posts: 2,861
Default

v6.27 - April 11 2021
+ FX: add option to not add undo points when closing FX windows [t=250733]

Edgemeal is offline   Reply With Quote
Old 04-11-2021, 11:15 AM   #16
vitalker
Human being with feelings
 
vitalker's Avatar
 
Join Date: Dec 2012
Posts: 8,849
Default

Quote:
Originally Posted by Edgemeal View Post
v6.27 - April 11 2021
I already changed the title when rc4 was released.
vitalker is online now   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 02:44 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2022, vBulletin Solutions Inc.