Go Back   Cockos Incorporated Forums > REAPER Forums > REAPER Bug Reports

Reply
 
Thread Tools Display Modes
Old 07-29-2021, 12:00 PM   #1
Meo-Ada Mespotine
Human being with feelings
 
Meo-Ada Mespotine's Avatar
 
Join Date: May 2017
Location: Leipzig
Posts: 5,393
Default StateChunks: change in filename of source with Reaper 6.33 (FIXED)

In this thread, Aurelien noticed, that the way that sourcefile in itemstatechunks is stored has changed its behavior. It used to be that the filename was always enclosed in " but now it seems to follow the scheme of other strings in statechunks, to use " only, when there's a space in the string somewhere.
Even though I can add this detail to my Ultraschall-Api easily, I think this could break old scripts, that were expecting it to behave always with " enclosed.

https://forum.cockos.com/showpost.ph...&postcount=719

Tested on Windows 7 Reaper 6.33x64
__________________
Use you/she/her.Ultraschall-Api Lua Api4Reaper
Bugreports&Docs notes please do here:https://github.com/Ultraschall/ultra...-reaper/issues - Donate, if you wish
Meo-Ada Mespotine is offline   Reply With Quote
Old 07-29-2021, 07:19 PM   #2
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,418
Default

...of course those scripts will need to be updated to support quotes in filenames, too.

We can easily change it to always use quotes even with no spaces, but not sure what the best route is...
Justin is offline   Reply With Quote
Old 07-30-2021, 01:25 AM   #3
mpl
Human being with feelings
 
mpl's Avatar
 
Join Date: Oct 2013
Location: Moscow, Russia
Posts: 3,349
Default

Quote:
Originally Posted by Justin View Post
...of course those scripts will need to be updated to support quotes in filenames, too.

We can easily change it to always use quotes even with no spaces, but not sure what the best route is...
Best route is to prevent chunking from developer side as much as possible
An API way of editing things would solve lot of chunking mess (including parameters Modulation/Learn, FX name or (available) parameters access, project header stuff, spectral edits etc).
__________________
SoundCloud | MPL Scripts discussion | ReaPack
mpl is offline   Reply With Quote
Old 07-30-2021, 09:55 AM   #4
Meo-Ada Mespotine
Human being with feelings
 
Meo-Ada Mespotine's Avatar
 
Join Date: May 2017
Location: Leipzig
Posts: 5,393
Default

Quote:
We can easily change it to always use quotes even with no spaces, but not sure what the best route is...
I would prefer to keep the old way.
There are plenty of scripts still being in use, done by scripters who left the community or are even deceased. So many of them have a low chance of being altered for the new changes.

Any chance of including such changes into dev-changelogs in the future?
This one was discovered by accident and most scripters would probably miss it and therefore not know, that scripts need to be updated.
I was lucky that Aurelien did the research on that one and found that, otherwise I would have probably spent weeks finding the issue in my code... :/
Having a hint in the changelogs would be very helpful in these cases.
__________________
Use you/she/her.Ultraschall-Api Lua Api4Reaper
Bugreports&Docs notes please do here:https://github.com/Ultraschall/ultra...-reaper/issues - Donate, if you wish
Meo-Ada Mespotine is offline   Reply With Quote
Old 07-31-2021, 06:28 AM   #5
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,418
Default

Quote:
Originally Posted by Meo-Ada Mespotine View Post
I would prefer to keep the old way.
There are plenty of scripts still being in use, done by scripters who left the community or are even deceased. So many of them have a low chance of being altered for the new changes.

Any chance of including such changes into dev-changelogs in the future?
This one was discovered by accident and most scripters would probably miss it and therefore not know, that scripts need to be updated.
I was lucky that Aurelien did the research on that one and found that, otherwise I would have probably spent weeks finding the issue in my code... :/
Having a hint in the changelogs would be very helpful in these cases.
The next +dev build will have it go back to " quotes when possible (almost all cases).

The 6.33 change was in the +dev builds for a while, as
Code:
 + Project files: allow filenames to contain quotes on supported platforms
(not super-obvious but there)
Justin is offline   Reply With Quote
Old 07-31-2021, 06:29 AM   #6
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,418
Default

Quote:
Originally Posted by mpl View Post
Best route is to prevent chunking from developer side as much as possible
Agreed Though scripts that do use chunks should use a correct/compatible parser too...
Justin is offline   Reply With Quote
Old 07-31-2021, 08:33 AM   #7
mpl
Human being with feelings
 
mpl's Avatar
 
Join Date: Oct 2013
Location: Moscow, Russia
Posts: 3,349
Default

Quote:
Originally Posted by Justin View Post
Agreed Though scripts that do use chunks should use a correct/compatible parser too...
Would be nice to port native parser into API, like... forward and back chink to/from multidimensional lua table?
__________________
SoundCloud | MPL Scripts discussion | ReaPack
mpl is offline   Reply With Quote
Old 07-31-2021, 01:15 PM   #8
Meo-Ada Mespotine
Human being with feelings
 
Meo-Ada Mespotine's Avatar
 
Join Date: May 2017
Location: Leipzig
Posts: 5,393
Default

Quote:
Originally Posted by mpl View Post
Would be nice to port native parser into API, like... forward and back chink to/from multidimensional lua table?
+1 would be a dream come true

@Justin
Thanx
__________________
Use you/she/her.Ultraschall-Api Lua Api4Reaper
Bugreports&Docs notes please do here:https://github.com/Ultraschall/ultra...-reaper/issues - Donate, if you wish
Meo-Ada Mespotine is offline   Reply With Quote
Old 08-01-2021, 02:16 AM   #9
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 8,400
Default

@mpl
It worth mentioning that we (mrlimbic and I) released a RPP lua parser which is really solid, using objects :


https://github.com/ReaTeam/ReaScripts/wiki/RPP-Parser
X-Raym is offline   Reply With Quote
Old 08-25-2021, 04:51 AM   #10
TonE
Human being with feelings
 
Join Date: Feb 2009
Location: Reaper HAS send control via midi !!!
Posts: 3,387
Default

Quote:
Originally Posted by X-Raym View Post
@mpl
It worth mentioning that we (mrlimbic and I) released a RPP lua parser which is really solid, using objects :


https://github.com/ReaTeam/ReaScripts/wiki/RPP-Parser
This parser might be useful if it works with midi/osc mappings correctly. Ultraschall api started adding functions for it lately, not working fully yet, according to my tests so far. See https://github.com/Ultraschall/ultra...aper/issues/13

The idea is creating line based, csv export and csv import for all midi mappings in .rpp, but listing all parameters, also the non-mapped, so those can be changed externally in Excel or emacs, if wanted so, then reimported back, getting all the new mappings directly. If such a system would exist (csv export and csv import of all midi mappings in .rpp), one can start creating scripts for auto-generating such mapping csv files based on self-defined rules.

For example if you have a set of hardware midi controllers, and you have a list of all your outputting values, you would simply fill your target parameters of your .rpp to your hardware generated values. Ready is your groovebox. Hardware knobs, faders, controlling something in your .rpp, exactly as you want, without having to do hundreds or thousands of clicking, mapping steps.
TonE is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 11:07 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2022, vBulletin Solutions Inc.