Mouse Modifiers: Toggle item selection function doesn't work correctly

[cohler]

"Toggle item selection" function in Mouse modifiers disregards item grouping when deselecting items. (It works correctly and takes heed of item grouping when selecting items, however.)

[AZpercussion]

Here I'm disagree! Lol
Because this action (mapped to ctrl by default) have an exception meaning.
So it should toggle selection independently of other items.
For now it toggle independent of selected items, but maybe it should also be independent of grouping.

[cohler]

Originally Posted by AZpercussion

Here I'm disagree! Lol
Because this action (mapped to ctrl by default) have an exception meaning.
So it should toggle selection independently of other items.
For now it toggle independent of selected items, but maybe it should also be independent of grouping.

As I stated, it only disregards item grouping when DESELECTING, therefore, in any case IT IS A BUG.

Currently, it observes item grouping when SELECTING, but not when DESELECTING.

That is totally inconsistent and clearly wrong.

[cohler]

Originally Posted by cohler

"Toggle item selection" function in Mouse modifiers disregards item grouping when deselecting items. (It works correctly and takes heed of item grouping when selecting items, however.)

@schwa will this be addressed?

[AZpercussion]

Originally Posted by cohler

Currently, it observes item grouping when SELECTING, but not when DESELECTING.

Selecting depends on option: Selecting one item selects group.

If devs will make what you ask for, we'll lose an ability to exclude from selected group some items.


But what I noticed is real bug: Marquee toggle item selection doesn't work at all if I need deselect grouped items while the option "Selecting one item selects group" is on.

What if make it work for all grouped items? Such way will not lose usefull behavior which already exist and we get what Cohler ask for.

[nofish]

Originally Posted by AZpercussion

Selecting depends on option: Selecting one item selects group.

If devs will make what you ask for, we'll lose an ability to exclude from selected group some items.

Agreed, it would only be a bug if the option was called 'Selecting/deselecting one item selects/deselects group' imo.

[cohler]

Originally Posted by AZpercussion

If devs will make what you ask for, we'll lose an ability to exclude from selected group some items.

Originally Posted by nofish

Agreed, it would only be a bug if the option was called 'Selecting/deselecting one item selects/deselects group' imo.

Wrong and wrong. The problem (as I already stated a couple of times) is that it behaves differently on the SELECT from the DESELECT. The behavior needs to be consistent, obviously. And yes if the option "Selecting one item selects group" is set then it should both select and deselect by the group. Whereas if that option is unset then it should select and deselect by the item.

Currently, it selects one way and deselects the other way. Totally useless and most definitely a fundamental BUG.

[nofish]

Originally Posted by cohler

And yes if the option "Selecting one item selects group" is set then it should both select and deselect by the group.

No, because the option doesn't define any behaviour for deselecting, so it works correctly as is.
You can call it inconsistent behaviour and useless (for you), but that's not the same as a BUG.

[vitalker]

In case you didn't know it was fixed in 6.72 (I'm writing not to cohler):

Grouping: mouse modifier to toggle item selection respects grouping when selecting or deselecting

Mouse modifiers: add media item left-click modifier to toggle item selection ignoring grouping

[tohubohu]

Originally Posted by vitalker

In case you didn't know it was fixed in 6.72 (I'm writing not to cohler):

Grouping: mouse modifier to toggle item selection respects grouping when selecting or deselecting

Mouse modifiers: add media item left-click modifier to toggle item selection ignoring grouping

looks like this bug is not on my list. weird.

[vitalker]

Originally Posted by tohubohu

looks like this bug is not on my list. weird.

It is fixed, so no need to add.

[tohubohu]

FIXED

[vitalker]

Originally Posted by tohubohu

FIXED

Haha, actually it wasn't marked as fixed, but as new features.

[tohubohu]

Ah OK
never mind.
I wrote big because when you do research in the bug archives it saves time to see right away.