Go Back   Cockos Incorporated Forums > REAPER Forums > REAPER Bug Reports

Reply
 
Thread Tools Display Modes
Old 09-23-2022, 05:19 AM   #1
Buy One
Human being with feelings
 
Buy One's Avatar
 
Join Date: Sep 2019
Posts: 1,324
Default [resolved, mistake in the documentation] Track/TakeFX_GetPreset() return value bug

As per the doc

Quote:
Returns false if the current FX parameters do not exactly match the preset (in other words, if the user loaded the preset but moved the knobs afterward)
Which doesn't seem to be the case. Changing plugin settings doesn't result in function returning false


Last edited by Buy One; 05-04-2023 at 10:15 AM.
Buy One is offline   Reply With Quote
Old 05-03-2023, 06:27 AM   #2
DrTT
Human being with feelings
 
Join Date: Jan 2019
Posts: 76
Default

Hello Buy_One,

you wrote:
Quote:
Track/TakeFX_GetPreset() return value bug
Same with me; I am also relying on the information whether an effect's preset has been changed and the return value is also always true (which is incorrect according to the specification).

I am working in Lua and in Windows 10, version 6.79

Best regards,
DrTT
DrTT is offline   Reply With Quote
Old 05-04-2023, 02:44 AM   #3
Buy One
Human being with feelings
 
Buy One's Avatar
 
Join Date: Sep 2019
Posts: 1,324
Default

I just had an idea that the function may have not worked with embedded (stock) presets which i had used in the showcase, but did with user presets.

But no, doesn't work with any type of preset.
Buy One is offline   Reply With Quote
Old 05-04-2023, 04:41 AM   #4
schwa
Administrator
 
schwa's Avatar
 
Join Date: Mar 2007
Location: NY
Posts: 16,518
Default

It looks like this is an error in the documentation. There's nothing in the implementation that suggests the function ever worked this way.
schwa is offline   Reply With Quote
Old 05-04-2023, 05:47 AM   #5
Buy One
Human being with feelings
 
Buy One's Avatar
 
Join Date: Sep 2019
Posts: 1,324
Default

Quote:
Originally Posted by schwa View Post
It looks like this is an error in the documentation. There's nothing in the implementation that suggests the function ever worked this way.
What does the truth indicate then and when is the return value false?

Let's sort it out on either side, programmatic or documentary

Last edited by Buy One; 05-04-2023 at 06:20 AM.
Buy One is offline   Reply With Quote
Old 05-04-2023, 08:50 AM   #6
schwa
Administrator
 
schwa's Avatar
 
Join Date: Mar 2007
Location: NY
Posts: 16,518
Default

For now, the function always returns true if the inputs are valid.
schwa is offline   Reply With Quote
Old 05-04-2023, 08:52 AM   #7
Buy One
Human being with feelings
 
Buy One's Avatar
 
Join Date: Sep 2019
Posts: 1,324
Default

OK, is this technically possible to make it behave according to the description in the doc?

And if it is, can this feature be implemented any time soon?
Buy One is offline   Reply With Quote
Old 05-04-2023, 08:53 AM   #8
schwa
Administrator
 
schwa's Avatar
 
Join Date: Mar 2007
Location: NY
Posts: 16,518
Default

Not easily, and not consistently for all plugin types, unfortunately.
schwa is offline   Reply With Quote
Old 05-04-2023, 08:55 AM   #9
Buy One
Human being with feelings
 
Buy One's Avatar
 
Join Date: Sep 2019
Posts: 1,324
Default

OK, understood
Buy One is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 04:26 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.