Old 10-26-2022, 02:41 AM   #1
johannphilippe
Human being with feelings
 
johannphilippe's Avatar
 
Join Date: May 2019
Posts: 11
Default JSFX editor line size limit

Dear Reaper team,

I honestly don't know if it is a bug report or a feature request, so feel free to tell me I'll post it in the appropriate location.

I'm working on a FAUST backend to transpile to JSFX. It works great. Though, some expressions are quite long (veeery long), and I've got one that crosses the line maximum size of JSFX editor, which causes the expression to be split on two different lines, resulting in syntax error. I actually don't know if it is only the maximum line size of the editor or if it may be related to the JSFX parser itself ? (I don't think so).

The issuing line when I found this issue is 4430 characters long (I'm not sure if this is likely to appear very often in my case, though it could, and it could even be more).

I guess these line size limits are mostly related to dynamic memory ?
Could you please consider removing this limit ?

Thanks a lot
Regards

Johann PHILIPPE

Last edited by johannphilippe; 10-26-2022 at 03:23 AM.
johannphilippe is offline   Reply With Quote
Old 10-26-2022, 11:19 AM   #2
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,901
Default

Perhaps for compatibility with past versions you should split extremely long lines anyway?
Justin is offline   Reply With Quote
Old 10-28-2022, 12:21 AM   #3
johannphilippe
Human being with feelings
 
johannphilippe's Avatar
 
Join Date: May 2019
Posts: 11
Default

Unfortunately, I can't split expression that easily in the Faust backend visitor. Faust composes expressions, I just translate syntax and semantics.

Though, for some reason, this problem has gone, even with longer lines (5000 + characters). Is that limit really existing ? Or was is a ghost but ?
johannphilippe is offline   Reply With Quote
Old 10-29-2022, 04:48 PM   #4
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,901
Default

The limit for JSFX parsing is approx 16k characters, maybe that's what you were up against... and also you could get lucky and have the dividing point be between tokens...

The limit for the editor is 4k.

I suppose we could remove both of those limits, but really on the generation side it would be easier (and more compatible...)

Last edited by Justin; 10-29-2022 at 04:54 PM.
Justin is offline   Reply With Quote
Old 10-30-2022, 10:50 AM   #5
TonE
Human being with feelings
 
Join Date: Feb 2009
Location: Reaper HAS send control via midi !!!
Posts: 3,771
Default

Dear Justin, has this any chance?
https://forum.cockos.com/showthread.php?t=272102
(lice-cap like standalone, for Reapers colored waveform, from command line)

Or could you post at least the algorithm here, so we could try it via python for example, if possible.

Those colors can be very useful in many analysis situations. Having this outside of Reaper can be very useful for sample management.
TonE is offline   Reply With Quote
Old 10-30-2022, 11:17 AM   #6
akademie
Human being with feelings
 
Join Date: Mar 2007
Posts: 3,080
Default

^^^^^^^ What that has to do with the topic???

Respect, please.
akademie is offline   Reply With Quote
Old 11-01-2022, 01:32 PM   #7
sletz
Human being with feelings
 
Join Date: Sep 2007
Posts: 7
Default

Quote:
Originally Posted by Justin View Post
The limit for JSFX parsing is approx 16k characters, maybe that's what you were up against... and also you could get lucky and have the dividing point be between tokens...

The limit for the editor is 4k.

I suppose we could remove both of those limits, but really on the generation side it would be easier (and more compatible...)
One famous guy said long ago "640 KO is enough", he was wrong ((-;

To be more serious, yes Faust ==> JSFX generated code can be arbitrary long, and dividing long expressions in several smaller ones is possible but not always trivial.
sletz is offline   Reply With Quote
Old 11-01-2022, 03:57 PM   #8
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,901
Default

Quote:
Originally Posted by sletz View Post
One famous guy said long ago "640 KO is enough", he was wrong ((-;

To be more serious, yes Faust ==> JSFX generated code can be arbitrary long, and dividing long expressions in several smaller ones is possible but not always trivial.
There's no limit on expression length, just line length. Expressions can span multiple lines.
Justin is offline   Reply With Quote
Old 11-02-2022, 01:58 PM   #9
johannphilippe
Human being with feelings
 
johannphilippe's Avatar
 
Join Date: May 2019
Posts: 11
Default

If expression length has no limit, I'm pretty sure we could add some line breaks here and there.

Another restrictive limit is the maximum of 64 sliders. Any chance this one could be raised or removed ? Some Faust programs can iteratively create a lot of controls.
johannphilippe is offline   Reply With Quote
Old 11-08-2022, 01:29 AM   #10
sletz
Human being with feelings
 
Join Date: Sep 2007
Posts: 7
Default

> Another restrictive limit is the maximum of 64 sliders. Any chance this one could be raised or removed ? Some Faust programs can iteratively create a lot of controls.

Justin ? Any answer here? Can this limit be removed ?
sletz is offline   Reply With Quote
Old 11-09-2022, 02:16 PM   #11
Justin
Administrator
 
Justin's Avatar
 
Join Date: Jan 2005
Location: NYC
Posts: 14,901
Default

Quote:
Originally Posted by sletz View Post
> Another restrictive limit is the maximum of 64 sliders. Any chance this one could be raised or removed ? Some Faust programs can iteratively create a lot of controls.

Justin ? Any answer here? Can this limit be removed ?
Will look at that at some point, perhaps we could limit the UI to 64 sliders but expose additional as parameters.
Justin is offline   Reply With Quote
Old 11-15-2022, 03:06 AM   #12
sletz
Human being with feelings
 
Join Date: Sep 2007
Posts: 7
Default

Quote:
Originally Posted by Justin View Post
Will look at that at some point, perhaps we could limit the UI to 64 sliders but expose additional as parameters.
Yes, that would be great !
sletz is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 12:53 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2023, vBulletin Solutions Inc.