RS5k parameter changes via API aren't registered in the Undo history if UI is closed

Buy One · 08-17-2023, 01:19 PM

FIXED in build 7.01

On Windows (added after FeedTheCat's comment that on Linux the behavior is different)

UI means FX chain window. In order for change in all instances to be registered, the FX chain window must be open. If a single instance UI is open in a floating window only change in its state is registered and it's the only one affected by the undo.

Other than that, provided the UI is open (FX chain window or a floating window), if the pair Undo_BeginBlock/Undo_EndBlock is used, changes are only registered with UNDO_STATE_FX flag (2), UNDO_STATE_ALL flag (-1) doesn't work or only works once right after the UI was opened.

Tested with Pitch offset parameter, same thing.

Tried including some track parameter changes within the Undo block and using -1 flag to trigger undo point creation with closed UI. The undo point is created but only track parameter changes are registered in the chunk.

For comparison tested ReaSynth and it's not affected by this issue.

FeedTheCat · 08-27-2023, 07:48 AM

This is a weird one...

UNDO_STATE_FX flag (2) doesn't make a difference here on Linux. Undo points are only created when RS5K is visible.

Buy One · 10-18-2023, 11:20 AM

Refresh

Justin · 10-18-2023, 12:20 PM

fixing!

08-17-2023, 01:19 PM	#1
Buy One Human being with feelings Join Date: Sep 2019 Posts: 1,405	RS5k parameter changes via API aren't registered in the Undo history if UI is closed FIXED in build 7.01 On Windows (added after FeedTheCat's comment that on Linux the behavior is different) UI means FX chain window. In order for change in all instances to be registered, the FX chain window must be open. If a single instance UI is open in a floating window only change in its state is registered and it's the only one affected by the undo. Other than that, provided the UI is open (FX chain window or a floating window), if the pair Undo_BeginBlock/Undo_EndBlock is used, changes are only registered with UNDO_STATE_FX flag (2), UNDO_STATE_ALL flag (-1) doesn't work or only works once right after the UI was opened. Tested with Pitch offset parameter, same thing. Tried including some track parameter changes within the Undo block and using -1 flag to trigger undo point creation with closed UI. The undo point is created but only track parameter changes are registered in the chunk. For comparison tested ReaSynth and it's not affected by this issue. __________________ ♦ https://github.com/Buy-One/REAPER-scripts (228) Latest: Jump to the directory of the file being previewed in the Media Explorer.lua Last edited by Buy One; 10-25-2023 at 05:46 AM.

08-27-2023, 07:48 AM	#2
FeedTheCat Human being with feelings Join Date: May 2019 Location: Berlin Posts: 2,523	This is a weird one... UNDO_STATE_FX flag (2) doesn't make a difference here on Linux. Undo points are only created when RS5K is visible. __________________ Featured scripts: REAPER Update Utility Lil Chordbox Gridbox/Adaptive grid MX Tuner RS5K Link MIDI Editor Magic Donate💝: PayPal\|ko-fi

10-18-2023, 11:20 AM	#3
Buy One Human being with feelings Join Date: Sep 2019 Posts: 1,405	Refresh __________________ ♦ https://github.com/Buy-One/REAPER-scripts (228) Latest: Jump to the directory of the file being previewed in the Media Explorer.lua

10-18-2023, 12:20 PM	#4
Justin Administrator Join Date: Jan 2005 Location: NYC Posts: 16,223	fixing!