TakeFX_CopyToTake doesn't cause LASTSEL value update in the chunk

[Buy One]

The issue is relevant for closed FX chain. In the open one selection does follow the movements of FX instance.

In the animation i'm moving take FX 5 (idx 4) up 1 position.

After it's been moved, the FX 4 which replaced it at index 4 assumes selection.

Didn't test with TrackFX function, but it's probably also affected.

Keeping selection intact makes sense when moving/copying between takes/tracks, but within the same FX chain i think it makes sense to have selected state follow the FX movements (especially when it does follow them in the open FX chain) or at least to have an option to retain its selection. This will obviate using chunk to update it.

(Other issues)

[Justin]

Hmm with the UI open the selection state is somewhat arbitrary and incidental based on the control/focus.

[Buy One]

In the open FX chain if FX is selected it keeps being selected after being moved with the function. Why should it lose selection in a closed chain?

[Justin]

Originally Posted by Buy One

In the open FX chain if FX is selected it keeps being selected after being moved with the function. Why should it lose selection in a closed chain?

How about an API to set the last-selected explicitly for the chain? I think that would be more useful.

[Buy One]

Originally Posted by Justin

How about an API to set the last-selected explicitly for the chain? I think that would be more useful.

As far as i'm concerned the more API the better and i don't object such function because it helps to avoid dealing with the chunk. In FRs i also recently asked for ability to get last selected with Track/TakeFX_GetNamedConfigParm.

But the problem described here is the unexpected, in my opinion, or undocumented behavior of the function. If not augmenting it with new functionality at least supplying with a note in the ReaScript doc that another function, which you propose, should complement it in cases where preservation of selection is required.

[Sexan]

Originally Posted by Justin

How about an API to set the last-selected explicitly for the chain? I think that would be more useful.

Sorry for intruding this thread with random request, but since you are talking about adding APIs can we also have GetSetEnvelopeVisibility?
https://forum.cockos.com/showthread.php?t=285018

I'm using very weird code with hacks to overcome the problem when envelope is "Inactive" to make it show since chunk/modifications are not responding anymore in that state?

r.GetFXEnvelope(TRACK, PM_INSPECTOR_FXID, p_id, true)
local enabled_previously
--! WEIRD HACK TO BRING ENVELOPE BACK VISIBLE WHEN CHUNK IS NOT RESPONDING
if not is_visible and fx_env then
  r.TrackList_AdjustWindows(false)
  enabled_previously = true
end
if env_chunk then
  local vis = env_chunk:match("VIS (%d+)")
  if vis == "1" then
      env_chunk = env_chunk:gsub("VIS 1", "VIS 0", 1)
  elseif vis == "0" and not enabled_previously then
      env_chunk = env_chunk:gsub("VIS 0", "VIS 1", 1)
  end
  if not enabled_previously then
      r.SetEnvelopeStateChunk(fx_env, env_chunk, false)
  end
end
r.TrackList_AdjustWindows(false)

This is all just for toggle visible on/off

[Justin]

Originally Posted by Sexan

Sorry for intruding this thread with random request, but since you are talking about adding APIs can we also have GetSetEnvelopeVisibility?
https://forum.cockos.com/showthread.php?t=285018

I'm using very weird code with hacks to overcome the problem when envelope is "Inactive" to make it show since chunk/modifications are not responding anymore in that state?

r.GetFXEnvelope(TRACK, PM_INSPECTOR_FXID, p_id, true)
local enabled_previously
--! WEIRD HACK TO BRING ENVELOPE BACK VISIBLE WHEN CHUNK IS NOT RESPONDING
if not is_visible and fx_env then
  r.TrackList_AdjustWindows(false)
  enabled_previously = true
end
if env_chunk then
  local vis = env_chunk:match("VIS (%d+)")
  if vis == "1" then
      env_chunk = env_chunk:gsub("VIS 1", "VIS 0", 1)
  elseif vis == "0" and not enabled_previously then
      env_chunk = env_chunk:gsub("VIS 0", "VIS 1", 1)
  end
  if not enabled_previously then
      r.SetEnvelopeStateChunk(fx_env, env_chunk, false)
  end
end
r.TrackList_AdjustWindows(false)

This is all just for toggle visible on/off

ah yeah, adding some ways to tweak these directly. vis/arm/active/show in lane, what else?